linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
To: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Seth Jennings <sjenning@linux.vnet.ibm.com>,
	Dan Magenheimer <dan.magenheimer@oracle.com>,
	Konrad Wilk <konrad.wilk@oracle.com>,
	Nitin Gupta <ngupta@vflare.org>,
	linux-mm@kvack.org
Subject: [PATCH v2 1/9] zcache: fix refcount leak
Date: Tue, 26 Jun 2012 16:49:46 +0800	[thread overview]
Message-ID: <4FE977AA.2090003@linux.vnet.ibm.com> (raw)
In-Reply-To: <4FE97792.9020807@linux.vnet.ibm.com>

In zcache_get_pool_by_id, the refcount of zcache_host is not increased, but
it is always decreased in zcache_put_pool

Acked-by: Seth Jennings <sjenning@linux.vnet.ibm.com>
Signed-off-by: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
---
 drivers/staging/zcache/zcache-main.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/staging/zcache/zcache-main.c b/drivers/staging/zcache/zcache-main.c
index c9e08bb..55fbe3d 100644
--- a/drivers/staging/zcache/zcache-main.c
+++ b/drivers/staging/zcache/zcache-main.c
@@ -946,8 +946,9 @@ static struct tmem_pool *zcache_get_pool_by_id(uint16_t cli_id, uint16_t poolid)
 		cli = &zcache_clients[cli_id];
 		if (cli == NULL)
 			goto out;
-		atomic_inc(&cli->refcount);
 	}
+
+	atomic_inc(&cli->refcount);
 	pool = idr_find(&cli->tmem_pools, poolid);
 	if (pool != NULL)
 		atomic_inc(&pool->refcount);
-- 
1.7.7.6

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

       reply	other threads:[~2012-06-26  8:49 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <4FE97792.9020807@linux.vnet.ibm.com>
2012-06-26  8:49 ` Xiao Guangrong [this message]
2012-06-26 22:36   ` [PATCH v2 1/9] zcache: fix refcount leak Konrad Rzeszutek Wilk
2012-06-27  4:47     ` Xiao Guangrong
2012-06-27  5:44       ` Greg Kroah-Hartman
2012-07-09  5:55         ` Xiao Guangrong
2012-07-09 14:47           ` Greg Kroah-Hartman
2012-06-26  8:50 ` [PATCH v2 2/9] zcache: fix a compile warning Xiao Guangrong
2012-06-26  8:50 ` [PATCH v2 3/9] zcache: remove unnecessary config option dependence Xiao Guangrong
2012-06-26  8:50 ` [PATCH v2 4/9] zcache: mark zbud_init/zcache_comp_init as __init Xiao Guangrong
2012-06-26  8:51 ` [PATCH v2 5/9] zcache: cleanup zbud_init Xiao Guangrong
2012-06-26  8:51 ` [PATCH v2 6/9] zcache: optimize zcache_do_preload Xiao Guangrong
2012-06-26  8:51 ` [PATCH v2 7/9] zcache: cleanup zcache_do_preload and zcache_put_page Xiao Guangrong
2012-06-26  8:52 ` [PATCH v2 8/9] zcache: introduce get_zcache_client Xiao Guangrong
2012-06-26  8:52 ` [PATCH v2 9/9] zcache: cleanup the code between tmem_obj_init and tmem_obj_find Xiao Guangrong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FE977AA.2090003@linux.vnet.ibm.com \
    --to=xiaoguangrong@linux.vnet.ibm.com \
    --cc=dan.magenheimer@oracle.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-mm@kvack.org \
    --cc=ngupta@vflare.org \
    --cc=sjenning@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).