From: Glauber Costa <glommer@parallels.com>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: akpm@linux-foundation.org, mm-commits@vger.kernel.org,
aneesh.kumar@linux.vnet.ibm.com, hughd@google.com,
kamezawa.hiroyu@jp.fujitsu.com, kosaki.motohiro@jp.fujitsu.com,
mhocko@suse.cz, rientjes@google.com, tj@kernel.org,
linux-mm@kvack.org
Subject: Re: + memcg-rename-config-variables.patch added to -mm tree
Date: Wed, 27 Jun 2012 16:02:05 +0400 [thread overview]
Message-ID: <4FEAF63D.1090503@parallels.com> (raw)
In-Reply-To: <20120626195647.GG27816@cmpxchg.org>
On 06/26/2012 11:56 PM, Johannes Weiner wrote:
> On Tue, Jun 26, 2012 at 12:21:07PM -0700, akpm@linux-foundation.org wrote:
>>
>> The patch titled
>> Subject: memcg: rename config variables
>> has been added to the -mm tree. Its filename is
>> memcg-rename-config-variables.patch
>>
>> Before you just go and hit "reply", please:
>> a) Consider who else should be cc'ed
>> b) Prefer to cc a suitable mailing list as well
>> c) Ideally: find the original patch on the mailing list and do a
>> reply-to-all to that, adding suitable additional cc's
>>
>> *** Remember to use Documentation/SubmitChecklist when testing your code ***
>>
>> The -mm tree is included into linux-next and is updated
>> there every 3-4 working days
>>
>> ------------------------------------------------------
>> From: Andrew Morton <akpm@linux-foundation.org>
>> Subject: memcg: rename config variables
>>
>> Sanity:
>>
>> CONFIG_CGROUP_MEM_RES_CTLR -> CONFIG_MEMCG
>> CONFIG_CGROUP_MEM_RES_CTLR_SWAP -> CONFIG_MEMCG_SWAP
>> CONFIG_CGROUP_MEM_RES_CTLR_SWAP_ENABLED -> CONFIG_MEMCG_SWAP_ENABLED
>> CONFIG_CGROUP_MEM_RES_CTLR_KMEM -> CONFIG_MEMCG_KMEM
>
> Yes! Thank you.
>
> When would be the best time to fix the function/variable namespace? :)
>
Andrew,
This patch forgets to convert some users, and my build breaks.
In particular, the ones in include/net/sock.h are not converted.
There may be others as well, my build break log is quite extensive =p
Just to be clear, I am perfectly happy with the change, just it needs to
be fixed.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-06-27 12:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20120626192108.2BB7FA0329@akpm.mtv.corp.google.com>
2012-06-26 19:56 ` + memcg-rename-config-variables.patch added to -mm tree Johannes Weiner
2012-06-27 12:02 ` Glauber Costa [this message]
2012-06-27 12:20 ` Michal Hocko
2012-06-27 12:21 ` Glauber Costa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FEAF63D.1090503@parallels.com \
--to=glommer@parallels.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=mm-commits@vger.kernel.org \
--cc=rientjes@google.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox