From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx162.postini.com [74.125.245.162]) by kanga.kvack.org (Postfix) with SMTP id 442DB6B0062 for ; Mon, 2 Jul 2012 00:34:12 -0400 (EDT) Message-ID: <4FF124A8.60509@redhat.com> Date: Mon, 02 Jul 2012 00:33:44 -0400 From: Rik van Riel MIME-Version: 1.0 Subject: Re: [PATCH 29/40] autonuma: retain page last_nid information in khugepaged References: <1340888180-15355-1-git-send-email-aarcange@redhat.com> <1340888180-15355-30-git-send-email-aarcange@redhat.com> In-Reply-To: <1340888180-15355-30-git-send-email-aarcange@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Andrea Arcangeli Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Hillf Danton , Dan Smith , Peter Zijlstra , Linus Torvalds , Andrew Morton , Thomas Gleixner , Ingo Molnar , Paul Turner , Suresh Siddha , Mike Galbraith , "Paul E. McKenney" , Lai Jiangshan , Bharata B Rao , Lee Schermerhorn , Johannes Weiner , Srivatsa Vaddagiri , Christoph Lameter , Alex Shi , Mauricio Faria de Oliveira , Konrad Rzeszutek Wilk , Don Morris , Benjamin Herrenschmidt On 06/28/2012 08:56 AM, Andrea Arcangeli wrote: > When pages are collapsed try to keep the last_nid information from one > of the original pages. > > Signed-off-by: Andrea Arcangeli > --- > mm/huge_memory.c | 11 +++++++++++ > 1 files changed, 11 insertions(+), 0 deletions(-) > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index 094f82b..ae20409 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -1814,7 +1814,18 @@ static bool __collapse_huge_page_copy(pte_t *pte, struct page *page, > clear_user_highpage(page, address); > add_mm_counter(vma->vm_mm, MM_ANONPAGES, 1); > } else { > +#ifdef CONFIG_AUTONUMA > + int autonuma_last_nid; > +#endif > src_page = pte_page(pteval); > +#ifdef CONFIG_AUTONUMA > + /* pick the last one, better than nothing */ > + autonuma_last_nid = > + ACCESS_ONCE(src_page->autonuma_last_nid); > + if (autonuma_last_nid>= 0) > + ACCESS_ONCE(page->autonuma_last_nid) = > + autonuma_last_nid; > +#endif > copy_user_highpage(page, src_page, address, vma); > VM_BUG_ON(page_mapcount(src_page) != 1); > VM_BUG_ON(page_count(src_page) != 2); Can you remember the node ID inside the loop, but do the assignment just once after the loop has exited? It seems excessive to make the assignment up to 512 times. -- All rights reversed -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org