From: Minchan Kim <minchan@kernel.org>
To: Rik van Riel <riel@redhat.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Mel Gorman <mel@csn.ul.ie>,
Andrew Morton <akpm@linux-foundation.org>,
jaschut@sandia.gov, kamezawa.hiroyu@jp.fujitsu.com
Subject: Re: [PATCH -mm] mm: minor fixes for compaction
Date: Wed, 04 Jul 2012 11:36:50 +0900 [thread overview]
Message-ID: <4FF3AC42.2000503@kernel.org> (raw)
In-Reply-To: <20120703161304.7734fbef@annuminas.surriel.com>
On 07/04/2012 05:13 AM, Rik van Riel wrote:
> This patch makes the comment for cc->wrapped longer, explaining
> what is really going on. It also incorporates the comment fix
> pointed out by Minchan.
>
> Additionally, Minchan found that, when no pages get isolated,
> high_pte could be a value that is much lower than desired,
> which might potentially cause compaction to skip a range of
> pages.
>
> Only assign zone->compact_cache_free_pfn if we actually
> isolated free pages for compaction.
>
> Signed-off-by: Rik van Riel <riel@redhat.com>
Reviewed-by: Minchan Kim <minchan@kernel.org>
> ---
> This does not address the one bit in Minchan's review that I am not sure about...
About this part, let's wait of Mel's opinion.
Thanks.
--
Kind regards,
Minchan Kim
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-07-04 2:36 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-28 17:55 [PATCH -mm v2] mm: have order > 0 compaction start off where it left Rik van Riel
2012-06-28 20:19 ` Jim Schutt
2012-06-28 20:57 ` Rik van Riel
2012-06-28 20:59 ` Andrew Morton
2012-06-28 21:24 ` Rik van Riel
2012-06-28 21:35 ` Andrew Morton
2012-07-02 17:42 ` Sasha Levin
2012-07-03 0:57 ` Rik van Riel
2012-07-03 2:54 ` Minchan Kim
2012-07-03 10:10 ` Mel Gorman
2012-07-03 21:48 ` Andrew Morton
2012-07-04 2:34 ` Minchan Kim
2012-07-04 7:42 ` Andrew Morton
2012-07-04 8:01 ` Minchan Kim
2012-07-11 20:18 ` [PATCH -mm v3] " Rik van Riel
2012-07-12 2:26 ` Minchan Kim
2012-07-04 9:57 ` [PATCH -mm v2] " Mel Gorman
2012-06-28 23:27 ` Minchan Kim
2012-07-03 14:59 ` Rik van Riel
2012-07-04 2:28 ` Minchan Kim
2012-07-04 10:08 ` Mel Gorman
2012-07-03 20:13 ` [PATCH -mm] mm: minor fixes for compaction Rik van Riel
2012-07-04 2:36 ` Minchan Kim [this message]
2012-06-29 10:02 ` [PATCH -mm v2] mm: have order > 0 compaction start off where it left Mel Gorman
2012-06-30 3:51 ` Kamezawa Hiroyuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FF3AC42.2000503@kernel.org \
--to=minchan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=jaschut@sandia.gov \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).