From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx201.postini.com [74.125.245.201]) by kanga.kvack.org (Postfix) with SMTP id 51BF66B005D for ; Wed, 11 Jul 2012 15:30:18 -0400 (EDT) Message-ID: <4FFDD456.7050809@att.net> Date: Wed, 11 Jul 2012 14:30:30 -0500 From: Daniel Santos Reply-To: Daniel Santos MIME-Version: 1.0 Subject: Re: [PATCH 05/13] rbtree: performance and correctness test References: <1341876923-12469-1-git-send-email-walken@google.com> <1341876923-12469-6-git-send-email-walken@google.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Michel Lespinasse Cc: Michal Nazarewicz , aarcange@redhat.com, dwmw2@infradead.org, riel@redhat.com, peterz@infradead.org, daniel.santos@pobox.com, axboe@kernel.dk, ebiederm@xmission.com, linux-mm@kvack.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, torvalds@linux-foundation.org On 07/11/2012 01:14 AM, Michel Lespinasse wrote: > On Tue, Jul 10, 2012 at 5:27 AM, Michal Nazarewicz wrote: >> On Tue, 10 Jul 2012 01:35:15 +0200, Michel Lespinasse wrote: >>> + u32 prev_key = 0; >>> + >>> + for (rb = rb_first(&root); rb; rb = rb_next(rb)) { >>> + struct test_node *node = rb_entry(rb, struct test_node, >>> rb); >>> + WARN_ON_ONCE(node->key < prev_key); >> What if for some reason we generate node with key equal zero or two keys >> with the same value? It may not be the case for current code, but someone >> might change it in the future. I think <= is safer here. > No, it's not illegal for two nodes to have the same key; the second > one to be inserted will just get placed after the first one. The > rbtree library doesn't care either way as it's not even aware of the > key values :) Right. This is strictly a function of your insert function. In my generic rbtree patch set, there is a concept of unique or non-unique keys, but this doesn't exist in the rbtree library its self. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org