From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BB12C05027 for ; Fri, 17 Feb 2023 10:44:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E8C816B0072; Fri, 17 Feb 2023 05:44:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E3C8B6B0073; Fri, 17 Feb 2023 05:44:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CDDEB6B0074; Fri, 17 Feb 2023 05:44:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id BBE776B0072 for ; Fri, 17 Feb 2023 05:44:17 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 902E6ABD76 for ; Fri, 17 Feb 2023 10:44:17 +0000 (UTC) X-FDA: 80476449354.07.83455DC Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) by imf25.hostedemail.com (Postfix) with ESMTP id AB6FBA000D for ; Fri, 17 Feb 2023 10:44:15 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=B5kHP7Un; spf=pass (imf25.hostedemail.com: domain of mikoxyzzz@gmail.com designates 209.85.208.44 as permitted sender) smtp.mailfrom=mikoxyzzz@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676630655; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7rE7bT9WEg/+TbqsUj9EwOlEC3od43qcgOlWqD+ziDg=; b=5R2SMw4CLNO+pwv82X+Hwaut31VJVJ5BYKY0WGqmWQoEldckFfagJq5EsZKemLCIVH+Kfn ExUlSaA9MAizvzwWpWk3edlcs4iFrLKc9nHXy19zxZGnerk07x1wJXEqg+Ocz8lq9luC3c SUHTLqd1iSPNzkqsNCC1STMu51F9yZ4= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=B5kHP7Un; spf=pass (imf25.hostedemail.com: domain of mikoxyzzz@gmail.com designates 209.85.208.44 as permitted sender) smtp.mailfrom=mikoxyzzz@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676630655; a=rsa-sha256; cv=none; b=craagv2xUK91evjcr/Nfp3ENWqb2NCa709xQtlhm075O+H5yJ3SBMn73GVdMLSq/XsgOmn CdvBAN0OCalG409Lhvz9/j5eo9Kxye4p0859xJxmo2hq0KnhUJcX7/Y7QObBoM7o8Nfg2I W1ROrjJRFrZho7CAukAB2gD4Y/VNNn8= Received: by mail-ed1-f44.google.com with SMTP id eg30so2418832edb.7 for ; Fri, 17 Feb 2023 02:44:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=7rE7bT9WEg/+TbqsUj9EwOlEC3od43qcgOlWqD+ziDg=; b=B5kHP7UnfBqJNd8H6FkzPzzeVotw1V3dJejxfiO3kuKOBJQ11PMaOvO3coZuCnpCp2 AbTnOR+Bp/hWkeB5nE/8hvxx8RaEFqSpf8siz9tTZAZhiu8wPT4FS0zF1hA5Jq6RI/Cj j3FCX2MC/CTeOcM9GDu4B5Vl6WHxKTQvV1y2Bvq03zzRHgDs5BS+7q8yoiOU9/6gJDsg MkMjH+V8G4sTfpz02o1zug5qMNf1zIMGEFF3P1BWHFNMQ1b39Ypq+8OWUbEyreA+9BN5 azcGxIaiNRfbzp6EMP3ca9BvVXRd5GKzRpYHaQIK7qdUY/KydGFfyy8VncfpFYPvvVgy rSxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=7rE7bT9WEg/+TbqsUj9EwOlEC3od43qcgOlWqD+ziDg=; b=1xGmLmUbFGaPuAZmVwQVk2ia+ARXPXE+Uh2rkLjxC/BaZFRMhSybvxcl6ZDg2VpdgU WnZbY30dMJ7VAvyx6/Nyzw+0TzTkC6USJR0rOpVppFo7r2Gme9P95F7aogDr6tErm0gq pniaiZ4FTVPE5sDvymtwIYH1T+1EFMZ+GFSlm3y3fx36qyEM4dSJSF7Mxu3ePdkSFAch KtqHva2rSdk3hAHawADXMr+Exz2csHArhkI7Jd0d1KFvuIcikZHbwMldZU0xGAkqAY7W 3fOLVE6Tgb6JYimDG9ltoabvZsNY8uszeffeIVSSXXkslJJPex3M6TEEwxePBDbbERIN gU2g== X-Gm-Message-State: AO0yUKVnn8uJgN9lJjUD0jIBErvD14npJ+WLUzrgoRATWLarWMu714Wd g7gK9IboPnoeN1LDPV+B8Fc5IiwbJ24= X-Google-Smtp-Source: AK7set/nio4nlFZ4oEa0H3lL26/vUGsioY7JyDCQbNeBl0ZNyDfqs4DYEkZV60gPWmOhlRKW6TE+Gg== X-Received: by 2002:a17:906:5653:b0:8af:2d2e:5d31 with SMTP id v19-20020a170906565300b008af2d2e5d31mr8533699ejr.31.1676630239387; Fri, 17 Feb 2023 02:37:19 -0800 (PST) Received: from sakura.myxoz.lan (81-230-97-204-no2390.tbcn.telia.com. [81.230.97.204]) by smtp.gmail.com with ESMTPSA id ss17-20020a170907039100b008b1329cd4cdsm1957916ejb.190.2023.02.17.02.37.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Feb 2023 02:37:18 -0800 (PST) Message-ID: <4a5c8cecb87735a6d697b3ff0da724cc73015669.camel@gmail.com> Subject: Re: [PATCH v4 0/3] mm/khugepaged: fix khugepaged+shmem races From: Miko Larsson To: David Stevens , linux-mm@kvack.org, Peter Xu , Matthew Wilcox Cc: Andrew Morton , "Kirill A . Shutemov" , Yang Shi , David Hildenbrand , Hugh Dickins , linux-kernel@vger.kernel.org Date: Fri, 17 Feb 2023 11:37:17 +0100 In-Reply-To: <20230217085439.2826375-1-stevensd@google.com> References: <20230217085439.2826375-1-stevensd@google.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.3 (3.46.3-1.module_f37+15877+cf3308f9) MIME-Version: 1.0 X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: AB6FBA000D X-Stat-Signature: aapitx3j1exoipkprbm38mnszkf9tc1y X-Rspam-User: X-HE-Tag: 1676630655-160904 X-HE-Meta: U2FsdGVkX1/P5ZBWoHeN4OzhomzJ94Wue/bjiPwdZ1HceJTF8p5p611oBlvmpDKUTgDXhb36p4VhOwL6UjyZpc/x6m4Vg9iddpxg5v/vNdRfSn7vM5J0giozLkziQXUeJRy9hvP2WjyuQ94sHtNw3N4fYOT3/fHyfz7rOIfDE6LvO4cTDd4tyGvGnazU/2pe8b5aq1CrVVVWKAAmQNpE1q7My5TedQxNbK8uvzEGIuBTGRy01atTOFNIvgAmFuo1ak2O8BxUVvZybt5l5Sofqs9ZNo899tE50UfIffI/TtX5ehcn0EIZdha0VfayS8nN1R5WGmvDqc9vCnG8puGrHNxqmP/TUsWxpUdutOkmcYUjRZjZJR1xF26jyUEyP3r6068JU3eRKt4+ZoyXYkLBDscBBSOxK/fcK3ScOSFzNsvNGPLD8XKht/4jNYjahr13EQ/c7LChkjwqcQgArzXkX/40BkMWMcnanhOJeCEbZAsDidyRkvCs33XSsTidNEsXUQbHLYO+3FOT59PgSHjVJJD2WKLoDqUBNEsBPDJ0uOXXLAz1ymxNDKJ8/gRVCM8aiOo3Jlkx5oQYAvL7m/i4sH8uv7CmLVQQn4aZPLt2mZ4fS2X9UQF+NWE8HJSbuxzwhylgf9xMemY4zr1yE1e08yAf60QPJmGkBIvhKuJ3Vfid1hzlJVdE68NkAU1F8yDw92qMmZzmFWAgxUtR2ehD6zHCfLfMWEEy8EE+9j+C47bxh1yb0n2cwGMdDebul9QbFtwFAbSolV1G22eUg02lGFer5CFGc3Z50UNn/zy4tTWVUeaub/EzO0Z6H1d9UDokQdyTP6QinNQ/9g9/bwt4FuHwbv+fGTVnU5avKJ+yaAGkm5cDjvq1MSGVUGZaJAUUMqwKav3TqW0TE2adlN8mBlhyXzBhg4W+xXH2uOFNYleaAljP66fBzXV2VP7sNRDNbEzUqgIrcFW0JsNfzKq Y8RuDSs0 mwV1JSVfxPCpuZGf7+PXtytPZfrgXjxtKVXQjUMNyjItcGLcWUQ6jQEXO/nnXIZvCVeEHUIpeB8GUY0Vf/ddsQtPbdUBKZX2w8ozUY8LRrufeC7A0I1fzNW0OgX6G9i2ZujE0jnX1PS6sEZtF0d23NwU5g1wOWcvKc84ZGo1O143qZu+0VDO1ckaOycSKz9VR5WVZxkb9PKzhSwL4VTS9/q/QuJiBHhaxmNQmEE2l9KDAZ+AsiPAhhfL943cvaL0wzmg8TA7noSHgsGJJ/YfJxxbw+BGAwntUgEPc/9uiMp00o/ehMir8BGlTbTC7TMqV3bF6OlunQG471Ksexy8YiSHizksHBg6aTSuRFPd/vhkYc2eqVAFj3FvUDYYhcPp07SUxi5lQ8wpSQq+C2oix0hVe1MiVLmaFyyCG+uJD733b1WH/K9uYMie3vakYUCThyznbv2ChN3BKVWLouCNi29bH8X+1z5W1LjoimrcWh0UVeC6EEdmqQS/HY+6RX50p0TgV X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 2023-02-17 at 17:54 +0900, David Stevens wrote: > From: David Stevens >=20 > Fix two races in khugepaged+shmem that cause issues with userfaultfd > and > lseek, respectively. >=20 > v3 -> v4: > =C2=A0- Base changes on mm-everything (fba720cb4dc0) > =C2=A0- Add patch to refactor error handling control flow in collapse_fil= e > =C2=A0- Rebase userfaultfd patch with no significant logic changes > =C2=A0- Different approach for fixing lseek race > v2 -> v3: > =C2=A0- Use XA_RETRY_ENTRY to synchronize with reads from the page cache > =C2=A0=C2=A0 under the RCU read lock in userfaultfd fix > =C2=A0- Add patch to fix lseek race > v1 -> v2: > =C2=A0- Different approach for userfaultfd fix >=20 > David Stevens (3): > =C2=A0 mm/khugepaged: refactor collapse_file control flow > =C2=A0 mm/khugepaged: skip shmem with userfaultfd > =C2=A0 mm/khugepaged: maintain page cache uptodate flag >=20 > =C2=A0include/trace/events/huge_memory.h |=C2=A0=C2=A0 3 +- > =C2=A0mm/khugepaged.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | 263 +++++= +++++++++++----------- > -- > =C2=A02 files changed, 144 insertions(+), 122 deletions(-) >=20 Might want to Cc this to the stable mailing list. --=20 ~miko