From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFAF9EB64DC for ; Mon, 17 Jul 2023 10:27:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 586646B0072; Mon, 17 Jul 2023 06:27:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5346C8D0002; Mon, 17 Jul 2023 06:27:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3D64F8D0001; Mon, 17 Jul 2023 06:27:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 2F3446B0072 for ; Mon, 17 Jul 2023 06:27:07 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id F40D8804A7 for ; Mon, 17 Jul 2023 10:27:06 +0000 (UTC) X-FDA: 81020726052.01.C215C11 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf11.hostedemail.com (Postfix) with ESMTP id BDF354000C for ; Mon, 17 Jul 2023 10:27:04 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dYO9vPEQ; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689589624; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QcjXX5GWlegc91aegHozDG5ys9NXk4J7QfyGnNAR82g=; b=6hfyd+sGLX7NujiyF8b78qi6SP//nPwhsV6uwOJ4rl/isqnTtUTL+Mt9JnXopalUjrvu89 tvUCOO/qFH2eFX7zOxoYiHXm9/J7E8W23+e6dD54uilN+Zs7ntuDz+MiO8x9CCyNWOS0xY jEy0DlI3XFhuu1M7TFsLSbZYCbvLryw= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dYO9vPEQ; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689589624; a=rsa-sha256; cv=none; b=0gci0EzMMFWd+fPH2e/7fbhdcoX+p4nPxMXqz4o/Gj+V6hoK1oKAw6QADdRmpJuqA+kfgW YO2vgTP/CuitSzi4rL6Fuk5YrBnu5/6N64gE0KqjdowGQsCAkTuRvggHAp2KWazdHaZ9j5 u7gLduJuryQ/aEIoso+GbFdrZhY5SdA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689589624; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QcjXX5GWlegc91aegHozDG5ys9NXk4J7QfyGnNAR82g=; b=dYO9vPEQ9aBrRgwhJA4UFoIVWNRmnuTkVGxlGqlXlBnGfNKj4QVMjKJ01Z8/S3ntSegH4T b08mpRf0oh/SebhXLCPkDRJ8hKgHH2a66KqkNb+4vLHi7tiv4Iq7Hf8fgo7UmDTeggiZRl jjTBCcBfCHqoGEdLOru+/aguAzLPAzg= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-370-sgnYyKDHNAqWjweH4lu71Q-1; Mon, 17 Jul 2023 06:27:02 -0400 X-MC-Unique: sgnYyKDHNAqWjweH4lu71Q-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-31444df0fafso2678264f8f.2 for ; Mon, 17 Jul 2023 03:27:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689589621; x=1692181621; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=QcjXX5GWlegc91aegHozDG5ys9NXk4J7QfyGnNAR82g=; b=HAclpd2GtEAK1yPfeRmPeh1GdVHaHl6K3T/Nvk+McTF5Jzs7kpUnV1xT127rsMwocj oztXfRk/FSPm86EtzRUddbv8/fLYcADD6gzvgy2zU6XBHjNyGMessQ8wZE664mi7Cehp QterqZi+B1XdZUnBT638FTwA5yPPAPO5PSSaxgSxAPIPEn8kwGJxM+O2g5gVpG6iujaq EDqPKgsOTciTxOt7tGJKNAUDw4zoVD0FmaVeWmul0Q2nCedrng6n7+uu8rBNgEmuzGAl upuwLESNiulxI1poDHFubkDkF5EDAPXTaqgXV/Ky1d59yi+VOIGlBCEXhVH1gsLc9pY4 D2mQ== X-Gm-Message-State: ABy/qLbG4QqKwh8iYs9un5I61WYkNF2Yp28Hra384yFJq3Rrb8vGMieK VIMoihHAWzrkmDlMbVj8WB3bWi2v4YCimjAp3KZ7LhsiZCVfF3Z+zcvtxrJbVHbTJkqwoMiJXjX xGnuTEj4BA1K0PjvCPlg= X-Received: by 2002:a5d:6a49:0:b0:314:2c17:d921 with SMTP id t9-20020a5d6a49000000b003142c17d921mr10297823wrw.38.1689589621623; Mon, 17 Jul 2023 03:27:01 -0700 (PDT) X-Google-Smtp-Source: APBJJlHg4QSrt7ASwOV1fEBcNK4Q/NKk0aYoKscyfvU06BxfjAob7ZBV5ewkV0pAvLD46ImkfH0r8w== X-Received: by 2002:a5d:6a49:0:b0:314:2c17:d921 with SMTP id t9-20020a5d6a49000000b003142c17d921mr10297812wrw.38.1689589621295; Mon, 17 Jul 2023 03:27:01 -0700 (PDT) Received: from ?IPV6:2003:cb:c735:400:2501:5a2e:13c6:88da? (p200300cbc735040025015a2e13c688da.dip0.t-ipconnect.de. [2003:cb:c735:400:2501:5a2e:13c6:88da]) by smtp.gmail.com with ESMTPSA id v16-20020a5d4b10000000b003143be36d99sm18839549wrq.58.2023.07.17.03.27.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Jul 2023 03:27:00 -0700 (PDT) Message-ID: <4a7feeb3-0c9e-0dba-1023-4f0ae1bfe471@redhat.com> Date: Mon, 17 Jul 2023 12:26:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 1/5] mm: introduce vma_is_stack() and vma_is_heap() To: Kefeng Wang , Andrew Morton Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-perf-users@vger.kernel.org, selinux@vger.kernel.org References: <20230712143831.120701-1-wangkefeng.wang@huawei.com> <20230712143831.120701-2-wangkefeng.wang@huawei.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230712143831.120701-2-wangkefeng.wang@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: BDF354000C X-Stat-Signature: eunjh4gbibkimwwru4qy1xh7cbnu9y5k X-HE-Tag: 1689589624-382168 X-HE-Meta: U2FsdGVkX1/K84sEgGHj4c3uEWqeStiW+UHv5vUe8ejTcjMICxlAV87mKmo1bPJcA0wHVl+SzEK0ZiLyxVsGIDU9Qq9vIx4t02etpGJGELwwDkhLpuu1DGx0LdN1BKshq76UcktOzn4q3zM95Fd//h3Gq4NUXl1L/91ajf0i02fI0ZXIqdVxJrRrT4ASN4AJJlgQ2F3wDwxpQUcyWQu0FEGu3YITWd/VnOhSpTLcDtbP5mV1O5pwzvP9aVu3W7cL3Eq35KTDJ1pUJTNzPLh2GtRDFKjXnIu6C3yseH8VA61lhK9V0Dqa73PcwSJ2sGpUM3yVQyciSj1WQx9laVLIz3/9PYp2Wnlrc7d4/jwIy2x3AACvbO5vbRCYoha4BDN4l5CrIhxA9qDG+IvY062j+WO/tz6e6P5w8DDUAFlsr/3ZhIa919EcSN+90RA0z7Th3k9CENuRPnSRfdgxaj/7laInbE7n6+/rC5Cna1Xhlfk/qPdOYzYMKpnsfVCPnzMiATfMO4elHdmgpx/Vc+oJ9heBNPLFpEZQvEdm9zuXvIALbCq785hsYRXKMHImb1UWwRCtqUSgb61znACDRYahiXdgA/10lElhnGRtUu+lKmA/9sbBhdFZrqTDMfQ8G7sAlWspFuCkVKAqo0tXFxfaA3Gogo2+OFEBFnLigo2GTdBlW8r0IrDCKLwhN7uMmI+mlDnPm70UMvue0T7TsqHYVyzuXQET2J0KDZvH67m0zVT7yXpJI3J5HyDrQQROMThMp0G9WATua1CUuej32Sr2P36EyD3vBsBFrJjJ/LJpgSHaFepfwCi1t/KvTpq74P5qB6RFO7k4RgWZ2BnnStbI/bPVcgV5Aw8/KYl5gVnYu12n9X2T2QQuWtLF2if4oxJSAfH3SSm2RFOFEtrR21wMh6hOdqmLFDjumG1h34G/8KX69ZXfY8xSOpx1kosevOdrBPHDDOc6/rjLTwWlm43 ttpdEee0 A6N8IrFTm8t5SdSXpuLrW1VANh6WvL7FX+YLGRVwf8f8u10eyrwtsQ91eVPZs2X9pIULryXtSj3A8WM3irPLgs8nORjoob0ZsXfSfxLDQBGsxAZKDermJwDBEOxSo+GRrvrdRvGfW6ZdPXNbCpii9lyTvI0EjqrcoZpHM+/pM4pAuIrJvGR3mImuGpSLtHB008Dv6thCOQIA/FJdYVxWnD3g629LpMwCO8GZwqiBPHPPB2qwhowU1Rexlk1UYaLL0zMOgZov7LcOKlOXDhzt2ZoHd+mYisS64NlMxsh7u80Ny+SCfY4lCvm392IfhFfhi7CyZsgqss3epjpb8LR9zcJK35qJvcIoyyOhHCImNYXvmFrc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 12.07.23 16:38, Kefeng Wang wrote: > Introduce the two helpers for general use. > > Signed-off-by: Kefeng Wang > --- > include/linux/mm.h | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/include/linux/mm.h b/include/linux/mm.h > index 1462cf15badf..0bbeb31ac750 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -926,6 +926,18 @@ static inline bool vma_is_anonymous(struct vm_area_struct *vma) > return !vma->vm_ops; > } > > +static inline bool vma_is_heap(struct vm_area_struct *vma) > +{ > + return vma->vm_start <= vma->vm_mm->brk && > + vma->vm_end >= vma->vm_mm->start_brk; > +} > + > +static inline bool vma_is_stack(struct vm_area_struct *vma) > +{ > + return vma->vm_start <= vma->vm_mm->start_stack && > + vma->vm_end >= vma->vm_mm->start_stack; > +} > + > static inline bool vma_is_temporary_stack(struct vm_area_struct *vma) > { > int maybe_stack = vma->vm_flags & (VM_GROWSDOWN | VM_GROWSUP); Looking at the comments in patch #3, should these functions be called vma_is_initial_heap / vma_is_initial_stack ? -- Cheers, David / dhildenb