From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BB0BC83F10 for ; Sat, 12 Jul 2025 11:58:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 692846B009B; Sat, 12 Jul 2025 07:58:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 66A736B009C; Sat, 12 Jul 2025 07:58:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5A7166B00BE; Sat, 12 Jul 2025 07:58:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 4A3076B009B for ; Sat, 12 Jul 2025 07:58:22 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id AAF691401F2 for ; Sat, 12 Jul 2025 11:58:21 +0000 (UTC) X-FDA: 83655464802.27.FD76EAF Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) by imf16.hostedemail.com (Postfix) with ESMTP id A2F8E18000E for ; Sat, 12 Jul 2025 11:58:19 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=aHcPNqnj; spf=pass (imf16.hostedemail.com: domain of asml.silence@gmail.com designates 209.85.208.42 as permitted sender) smtp.mailfrom=asml.silence@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752321499; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hP+xr8zzqNCzMu2bRqX5AggMpbifXKPp5N+26RWR9n0=; b=eCZNvSBty/BrlqIrJLzrQzCwu304Vc+Gw0pPSRROkja7QJw8QOtwHk+bpb0ZdJ8GBZqJ+b E/EzJLNDfMj1Wh7m/7X0wMliGO8RtdsgAgToGVxDtqALVXaM6jk4HQ9I0hjfSyenvG4n85 VPgRIlwxLfEmfXZOqQvzqpnu3DPyeSk= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=aHcPNqnj; spf=pass (imf16.hostedemail.com: domain of asml.silence@gmail.com designates 209.85.208.42 as permitted sender) smtp.mailfrom=asml.silence@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752321499; a=rsa-sha256; cv=none; b=VT+d9w+gOtYStwNF0MXrig5ZXraY5H3n+FFr9VXjAa5cWPFET/lfhFVolktODAg5TzQ0ZV MXf5xFIR13r+rZ4ZRywnhvnJi7uddtv9RZgnCZ12GEkX3maD0Zso/j3WKLGEKawFg8Jkma YI4jEHF26q4j4i8Uj6FWAa7gmbcocvE= Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-604bff84741so5499116a12.2 for ; Sat, 12 Jul 2025 04:58:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752321498; x=1752926298; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=hP+xr8zzqNCzMu2bRqX5AggMpbifXKPp5N+26RWR9n0=; b=aHcPNqnjM3BcmDb7J1jwDYnnUr2XbRVqoUM/siMURnXQZ9mPPLULtYLoS0xFCcMfoW 1PyHZtMDfoLYNdX+BMngLv3XXglxvybwQCcoUV2WJl5JO0WLuGZvO3WQ7jBHQ4AE1ebf +lSv7SDcgVMcVhjo6Jb58uchamMjZHoZCmIaFEN8zXVDuD3YyyWIG50dtE7Wi0+NGfK2 MBGCt6qnEWHo0V6Db60+LbCX0HHc9GazIAqn2EGdS6jYtUoEfwhriZ4qIPTMCqS9nzv9 2gQQ6I87qK9HU6FYFHPZ6gFR6QgTU1phU9bK79WCrdJu4YPEKj61wpeRqp7QeNB3arWZ 33vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752321498; x=1752926298; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hP+xr8zzqNCzMu2bRqX5AggMpbifXKPp5N+26RWR9n0=; b=PxGsgN+gOkrB6zKDUT/ZDWYfKimNnqnV1QuuRAy1eGT/FmUw+dblstt5e0PN2zqJ3b DZtjH3hBJlCAVCMEV6EZ7yIH4Ut17hLbIm5CVnDzy6IvcLhmGZFBtLIUzPWqE9IKcK9l mYbpbgj5hCCS43wFDsUlSKqVpSvKDpvsqpeV1fBPlFFed1WctvKeJb1jiZFNVeAhhepB 1jvZRiyQOUA03FvLz01k2wKV5sm8LNgkchCSgXkHLbedV1EJMGaVmWG70kG/fD9Y4s/Z HJzad0bgjw/BYwsQlBeAt6iY5+CQSTF510DA2WjO5WZQNdMY4kjRjWSFBJqDFauOmSaN kYIw== X-Forwarded-Encrypted: i=1; AJvYcCUd7MZYLGmetqKnzhjSwfo1sbV/lxW5ysvvs7f6nm/fLP5JPMyloT5I2UVT2gQA4c4p8nfHFnjWZg==@kvack.org X-Gm-Message-State: AOJu0YzmD1thsXIPMtYB0/QogL2p9G6posWlhXjsnc72zD7HhnYKYGWO 3henQsvrRpMS14R7LdMgegn6+xtSE+zZid30qnryb5XcON2p1V7uggwL X-Gm-Gg: ASbGncvk23vzJiH58f4i5GHjzf0zv8IXXQglD9zMPGvVOw+w7hobueodRdkoZbBOrNn VBouUAsFx2jv1MOiyvimPAnj6fpLWngJykWE36hoQKqWTUTue3wqByKImOOgXEImDHKGISUZq+I hVhl0R2Cw3iGJuKLHOVaT2NT7gfevDelyI+N5KxqypQiLpmZa0W06Y+r4eDkfD2XwEx4zS3f0ae OtoIc4Li1nOqCJUMOAjnsFJEWCv9VXInrlkPu6vs20B3wrbtkMEA0Roxx7dpILNfytez8J7lLul wCOjZ9hbuYqmWoj903+2jsQ3tNoW0o/7wb5v8WjVKLtHGHrLICxoGPDWzrAD4A/Xm1bJHbb9wqJ 8ajYm5yD2N1LMff/NstC6Gx4CsLrrzk1W1Is= X-Google-Smtp-Source: AGHT+IGIng8Jp0aA3rpk3u1fXyOC8/wF9+m2XwqL2YDV2mg0DsuWIhpzPrj/i3XlLVi8Cw4TUs0HjQ== X-Received: by 2002:a17:906:9f90:b0:ae0:d4f2:dff3 with SMTP id a640c23a62f3a-ae6fc219a7bmr636252966b.58.1752321497701; Sat, 12 Jul 2025 04:58:17 -0700 (PDT) Received: from ?IPV6:2620:10d:c096:325::1ac? ([2620:10d:c092:600::1:b2ad]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ae6e8294bf2sm467992366b.122.2025.07.12.04.58.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 12 Jul 2025 04:58:16 -0700 (PDT) Message-ID: <4a8b0a45-b829-462c-a655-af0bda10a246@gmail.com> Date: Sat, 12 Jul 2025 12:59:34 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v9 2/8] netmem: introduce utility APIs to use struct netmem_desc To: Byungchul Park , willy@infradead.org, netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel_team@skhynix.com, kuba@kernel.org, almasrymina@google.com, ilias.apalodimas@linaro.org, harry.yoo@oracle.com, hawk@kernel.org, akpm@linux-foundation.org, davem@davemloft.net, john.fastabend@gmail.com, andrew+netdev@lunn.ch, toke@redhat.com, tariqt@nvidia.com, edumazet@google.com, pabeni@redhat.com, saeedm@nvidia.com, leon@kernel.org, ast@kernel.org, daniel@iogearbox.net, david@redhat.com, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, vbabka@suse.cz, rppt@kernel.org, surenb@google.com, mhocko@suse.com, horms@kernel.org, linux-rdma@vger.kernel.org, bpf@vger.kernel.org, vishal.moola@gmail.com, hannes@cmpxchg.org, ziy@nvidia.com, jackmanb@google.com References: <20250710082807.27402-1-byungchul@sk.com> <20250710082807.27402-3-byungchul@sk.com> Content-Language: en-US From: Pavel Begunkov In-Reply-To: <20250710082807.27402-3-byungchul@sk.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: A2F8E18000E X-Stat-Signature: jrjdr94hum9tmee7jsk8jkbr1ohg48ps X-Rspamd-Server: rspam02 X-Rspam-User: X-HE-Tag: 1752321499-132543 X-HE-Meta: U2FsdGVkX1/ayxSVDUumpgpLcmYGFVhlZhfae5zJq52ZIMAU0FbUv4RoYmP5BwkxpH/KXEXd6yxGI3knn7AyHoHW+o4GMU9b8Pb80EHw6wL8Db2MPZuXLM7yEImGCXQt8TTQdHdpNXZu6v4V/M/9DEBEdhZO3tnb5ej3ZJ2kC8n4v0ectjWL++iOga4Ft15lLcu8oyNiNUCmwnjPSQoQclRGMz2sMLwcdwiwYTk+To95TH2HRqK7siukoE4JUSQhH6zAtS+9e6flEZV0xpGPYsbSY6chYR8rtgX+yEy/52nkYS04GDO6VaZMdp1VePdb1gEZhEhmTqo+xICBPbZF5br79+HT3fkX46hvgudLZJta+FseqH2m+hsZalFRrsj55okGpqCS991eJ7pktVGAqoRuW9GBdllFmdRU75SpI4xB2blwnXxrgJ5MvfdKZtJHl7ZDlthk5c3asxOTwlThcY+3OvtCn88aundFTHclMokDGYl5epAYU9j1TsLhr0Erxflrkf1iikcAvnnA5sfeY/KQzK9WCxJEh2grR8UmELLSCvSpAQkx+e7E+VGbyHHqeD59m80G4DZEbk2ArRzvVY2iu+mvrjLUmt3ozOeJij/AXZ8Prtx7+WogCvQPNMHq7+rG1qZq6e6iZiH72Rz9yqbmUFcHgnrPX9MgfSIFGdat5T4pRQT5piuGAI2/qAm94wni+QaYB3pRwpk1KW4X0zUHxr4k3/82sEH5kQuNy4+eOa3FhRLm7GG5VwHgGmhevfClAyK1fcGovtHnB8Hl4zsg7broBqsJUlqSG+PO9ZIGMeeimIPDVkci4o2gYABq4ZySSc5tKDXx7/14fHU9ByCwXTHRP7WMX1CuA2NPHndf/Cl5LE8J0MNg4Ip6mjq6yvgFkeXiVSuJit8tnFNSIzxT+3UwoqVFrwvRI00fMpFpcacBD+ceQbAH+8ScFoC4sf5Xpyi+OPkD4kDwUkT sS0Rp1Wi uOU0klSx9hcnGP64SFuX+dUxi+F8NsD4H1d3+tPCtztFdfv4a3XI5R2M0NODeFaAzXUmiNyUQjWum0gWs+GQ51g5o7q4iOV2GkW55ME3B5O+72wRQ/lNhd9C2YZ15QhZy/SS2QByk9xbIOCldb4+VMK4wXwVEn20tNMvyp1uzyRY3b76evWJSA6OId63QNCkSvGYCGjjOpI/uYBo/NTYe/q1aWb7vvFQUQSB06HJ+arVqJoSpAo8QJJV9L7ik1giZwNULZoCElsY2iMUObwvSg3+ffoqFMLfnfsYo1wCpycin1Vaq2Dh/uQ89IDtlw5A9b8NgUIT6NBxLmVlxfVsyjrxRVwueCteVMZ012q7awV02qvO8F1Q6Gv/GaZJlJD9q3LdXjS6j0EF1XO4MVugrdHFNqjPkndV/aXBtIwhyF55LR/x3XFmG+H04HFfxvWAhCwAE8ea5QhfTOIWGT0ObSaibidn3euIaHtMVgxxqfLcP5zpUry8VjbrrpBgUQ8uJ8ot/erJeWz83KFYtRA4RyLD+x+ntPNzY5IsWalfNTbpZIDqqU2w4HpWLvZ5P1JwDbRUnftuDk9ow2u1MLe5Hj6ra95x7k1PtWgGFHjgb0nBMV3tOTuyrIf7tpdnrce/JwMmgjXS+fRp9hn0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 7/10/25 09:28, Byungchul Park wrote: ...> + > static inline struct net_iov *netmem_to_net_iov(netmem_ref netmem) > { > if (netmem_is_net_iov(netmem)) > @@ -314,6 +340,21 @@ static inline netmem_ref netmem_compound_head(netmem_ref netmem) > return page_to_netmem(compound_head(netmem_to_page(netmem))); > } > > +#define nmdesc_to_page(nmdesc) (_Generic((nmdesc), \ > + const struct netmem_desc * : (const struct page *)(nmdesc), \ > + struct netmem_desc * : (struct page *)(nmdesc))) Considering that nmdesc is going to be separated from pages and accessed through indirection, and back reference to the page is not needed (at least for net/), this helper shouldn't even exist. And in fact, you don't really use it ... > +static inline struct netmem_desc *page_to_nmdesc(struct page *page) > +{ > + VM_BUG_ON_PAGE(PageTail(page), page); > + return (struct netmem_desc *)page; > +} > + > +static inline void *nmdesc_address(struct netmem_desc *nmdesc) > +{ > + return page_address(nmdesc_to_page(nmdesc)); > +} ... That's the only caller, and nmdesc_address() is not used, so just nuke both of them. This helper doesn't even make sense. Please avoid introducing functions that you don't use as a general rule. > + > /** > * __netmem_address - unsafely get pointer to the memory backing @netmem > * @netmem: netmem reference to get the pointer for -- Pavel Begunkov