From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFC2EC2BBCA for ; Wed, 26 Jun 2024 00:37:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0EDB86B008C; Tue, 25 Jun 2024 20:37:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 09BE26B0093; Tue, 25 Jun 2024 20:37:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E57946B0095; Tue, 25 Jun 2024 20:37:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id C884A6B008C for ; Tue, 25 Jun 2024 20:37:16 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 40B151A0824 for ; Wed, 26 Jun 2024 00:37:16 +0000 (UTC) X-FDA: 82271175672.04.3819DE4 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf25.hostedemail.com (Postfix) with ESMTP id 20903A0012 for ; Wed, 26 Jun 2024 00:37:12 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=CEYrEq53; spf=pass (imf25.hostedemail.com: domain of gshan@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=gshan@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719362218; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7XSa6ZpfJ2JlPT3g8OgBf9PZ5iAj39OSQpGesaTNmpY=; b=yLhnUhmmuzP81tzQMxqrDQk0NqpryJ+Mm7oSaGtRUYkhRdz+wYeYDYZyBAPtyksMmrgUkg V5vBHck0A9Oaa203Y6h6SYRHWtzfB5+TeiE/RqYBuBpW2uCEdzRTtS3HTK+RDnrWhgDnxc Z9oeRt62TPeJNtH+ZqevcucSqYNjmIs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719362218; a=rsa-sha256; cv=none; b=JSV+pyaBr5rutIpp8BKbhhQlaQrK+ZfUiVP8X/3Vk/RQeOAE+UK7/y5hm21gioZofP/PGh yZCr6S+raB7EDL6iWD/HiuQqCFX8X3IMtUYThCybkytycUaJm8feSHOOsOD8B883o7DHQn uoMtg4RgTO8VzALfYSiBT2sUbVNSQPQ= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=CEYrEq53; spf=pass (imf25.hostedemail.com: domain of gshan@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=gshan@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1719362232; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7XSa6ZpfJ2JlPT3g8OgBf9PZ5iAj39OSQpGesaTNmpY=; b=CEYrEq53tMy7CAGHcQmPDVWdh7QyKtUWVDN97eX7VvD9X+ha877eKLXSRVKBU7wyRNmHAx MD2sbNQR1WbTXJOsByC0AQkEt3M+X36NfbRKVpXuVRjapwULL5cyN1Yy2bUkWg7cMRhUsO CPovP0dPZEoICMCP+pgmAhTDxSynyfM= Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-369-bp-sgsiROZqKiwsU0fHhEg-1; Tue, 25 Jun 2024 20:37:08 -0400 X-MC-Unique: bp-sgsiROZqKiwsU0fHhEg-1 Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-2c1a9e8d3b0so7788561a91.0 for ; Tue, 25 Jun 2024 17:37:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719362227; x=1719967027; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7XSa6ZpfJ2JlPT3g8OgBf9PZ5iAj39OSQpGesaTNmpY=; b=GDickU6WIdg3iuKi4nOFuAYZdDB854XBtEpaQocKLZg8pAWKaOtxEBZPhreHSZbLtr DttkFelLrzoNlijcOFG4ewBcgtL2Ap/ryPl76Kc9zqCEdZu+nabshoZeh/TV77iEkyR6 tTY0JQo+jbbh9Gqp1GSnZbDWPtG2fbWnymNo5zYuitYfiFOrUbeJq4XvZoryKtv/DuYX PW5aOCju0/UTnCJQklU82guT7V34p+Kh68amJWX9iTHvw/EMymnclsVaRPGxg/lwjWsN 1XsAQqRFZQlG0151kJjFXcR+GVLT+Bn/Bk6tm3uIcxGrj+gOuPPoQDl8pTT5gCY+2UXP 6jxQ== X-Gm-Message-State: AOJu0Yw7YAH09sMlpzCzXrAvSo1hPVh+LgY+9nZ6bfV/ouUzW/D4L9l+ 11scT3bvllt19VOKnUGEX7I4vhgONpCqbeW86CDw+2mvAeani+wyzgRW+nSe1deYoHugL7Zzd+l WdVjY65P+AJlw3ofWGywljm8LvgD16njsHFEK8qIie0j4yIs0 X-Received: by 2002:a17:902:ecc8:b0:1f9:c289:737c with SMTP id d9443c01a7336-1fa1d683c1emr106652805ad.60.1719362227390; Tue, 25 Jun 2024 17:37:07 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEDjNcz0viQEwIaipBp6N0yRlPUsIKoKAYuglwG9H2KqNectD+G314m4fAwmTDdbJQL9ffogQ== X-Received: by 2002:a17:902:ecc8:b0:1f9:c289:737c with SMTP id d9443c01a7336-1fa1d683c1emr106652695ad.60.1719362226970; Tue, 25 Jun 2024 17:37:06 -0700 (PDT) Received: from [192.168.68.50] ([43.252.112.224]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f9eb3c6ec0sm88110985ad.169.2024.06.25.17.37.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Jun 2024 17:37:06 -0700 (PDT) Message-ID: <4b05bdae-22e8-4906-b255-5edd381b3d21@redhat.com> Date: Wed, 26 Jun 2024 10:37:00 +1000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/4] mm/filemap: Limit page cache size to that supported by xarray To: David Hildenbrand , Andrew Morton Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, djwong@kernel.org, willy@infradead.org, hughd@google.com, torvalds@linux-foundation.org, zhenyzha@redhat.com, shan.gavin@gmail.com References: <20240625090646.1194644-1-gshan@redhat.com> <20240625113720.a2fa982b5cb220b1068e5177@linux-foundation.org> <33d9e4b3-4455-4431-81dc-e621cf383c22@redhat.com> <20240625115855.eb7b9369c0ddd74d6d96c51e@linux-foundation.org> From: Gavin Shan In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 20903A0012 X-Stat-Signature: 67o941p3s8bzy3pzpjf89a3a4gyawk6d X-HE-Tag: 1719362232-107421 X-HE-Meta: U2FsdGVkX1/q79Bro64UkGNOwBTYe/N2aMIw/16TZ4ZbZODPQnAPDbR4hN7QM6u9zSZvdcm1JsOHAh6PTGQTK3zupW8ibBHBskXnzGCYUeyOiqzrTZ9imYR2WGqyeUx0DDdApequYjOe1CCGaBwKDTsLhqtVAJl3xWPLAPkdDbSwxmdK2wZ+QHgYNA4Coo8VbojktX8Ssyzqmm5M4R4nPPESEIMYR3LlQSLGMK6Gky5NU9mFtsA1c75QJqW4soLQxOHVWJnRSfK6F0rzgYCDFe5AfwbFiZdpGmdc7a8Q+xsIzwi7ttsG2jHylTtAOR67g6AWpotlt7M7ixyJUe6RpQL6fT97h2XPK2gIkgZI/IGzKWijJ/sV7MB2tUHFPczWpj9HCwz98iWg1TzR9JUDDV1Ss/G5VYcH7fuP4Wwljedb73fCG/h4zRiBCGpXriVF9xzhubZf23udGU+bTEFnA/LvXr+VWfYHD2C+0070K8M10+pfgU423I+sKRUImleGAbcui4eDigcBv9TY+8qOj6jOr5IM9srVlLH1xeqrZW5ZfB0Dj+3X+/1l9gJy2A1zVSAISAFOQ2qxxTyYJB+AAULappJ12/vt+J5NYPziLAXtspeTT58h1JUgtyD4/cRCDRUR6Wkr3ZgGLB4uTsXc5LNRTY/81NN9gh5qxim8+/IWA97eXqwg13wsd9+9qC4+7v2tuuuHNZFzrU+zU10RczJgEBkknh0D0pi53KSdeoAuhSTA+UzIOed1fPh6A/EiY/+U9ddP2aEKZUfK3FE3FUuV0iW5TJjpTPALEs5UEGcYba5n0UUoMDTLTLh8qgJWViv9LiM/iQ67UUXqS2bX181pHMSbksSStSHLLiJb/veKnnoWG+0hpKZkDrhch6uWzCNFTSV8F1SZhfZ5CwllfOwaP2j3gnWixc5+OZMzBcbDLAekti0XAH5dv/EQCAfIBfs1yqp3goVFUybsmOX UnOZHb85 omGxLhb0/a6b5IyLxYcefLA60iE8oR5ob1nusLDGI/rnbjckxD1ORHFBUeEB686jSVeu85icQyUd0DrT97pTBXSXMIiFn/IUdfueTEtUzPS67F25otguIq3X1umyEhcoYP75d0KMCq3AgVMA3cJCQDm75BZyVshii8OkQ9Dp36oUaXw3ipwFlgECgy4VkD5Kv06cNfycJwMzXOAajnx4mDVyibcKmIa4gwEISrsii3txd1/ForJUB4CyxSxQMkhS8Vzu+9cPXDiHmJDYvP6cFimym7te7D7siVpz8dGObXUhPtJss0Q8rSzDWCiAY1EuUp98jEGyA413DG0Kh3LidiOaLfIpsdMRguYXBl9EpNzaQfdW9tPxbh96A1W9oLN6tABVcxah0jXprHvUoDEEUIJLKabRGyaotTL3gjePq6j0exHeedWqlJ118vKia96N673qA6WwrjVmbzARM6JnQhVtjJRQXsXNCMBL6hXGTWoRkLFI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 6/26/24 5:05 AM, David Hildenbrand wrote: > On 25.06.24 20:58, Andrew Morton wrote: >> On Tue, 25 Jun 2024 20:51:13 +0200 David Hildenbrand wrote: >> >>>> I could split them and feed 1&2 into 6.10-rcX and 3&4 into 6.11-rc1.  A >>>> problem with this approach is that we're putting a basically untested >>>> combination into -stable: 1&2 might have bugs which were accidentally >>>> fixed in 3&4.  A way to avoid this is to add cc:stable to all four >>>> patches. >>>> >>>> What are your thoughts on this matter? >>> >>> Especially 4 should also be CC stable, so likely we should just do it >>> for all of them. >> >> Fine.  A Fixes: for 3 & 4 would be good.  Otherwise we're potentially >> asking for those to be backported further than 1 & 2, which seems >> wrong. > > 4 is shmem fix, which likely dates back a bit longer. > >> >> Then again, by having different Fixes: in the various patches we're >> suggesting that people split the patch series apart as they slot things >> into the indicated places.  In other words, it's not a patch series at >> all - it's a sprinkle of independent fixes.  Are we OK thinking of it >> in that fashion? > > The common themes is "pagecache cannot handle > order-11", #1-3 tackle "ordinary" file THP, #4 tackles shmem THP. > > So I'm not sure we should be splitting it apart. It's just that shmem THP arrived before file THP :) > I rechecked the history, it's a bit hard to have precise fix tag for PATCH[4]. Please let me know if you have a better one for PATCH[4]. #4 Fixes: 800d8c63b2e9 ("shmem: add huge pages support") Cc: stable@kernel.org # v4.10+ Fixes: 552446a41661 ("shmem: Convert shmem_add_to_page_cache to XArray") Cc: stable@kernel.org # v4.20+ #3 Fixes: 793917d997df ("mm/readahead: Add large folio readahead") Cc: stable@kernel.org # v5.18+ #2 Fixes: 4687fdbb805a ("mm/filemap: Support VM_HUGEPAGE for file mappings") Cc: stable@kernel.org # v5.18+ #1 Fixes: 793917d997df ("mm/readahead: Add large folio readahead") Cc: stable@kernel.org # v5.18+ I probably need to move PATCH[3] before PATCH[2] since PATCH[1] and PATCH[2] point to same commit. Thanks, Gavin