From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 721AEC48BF6 for ; Mon, 4 Mar 2024 21:58:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0475C6B007B; Mon, 4 Mar 2024 16:58:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F3A7B6B0082; Mon, 4 Mar 2024 16:58:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D65CD6B0089; Mon, 4 Mar 2024 16:58:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id C3C266B007B for ; Mon, 4 Mar 2024 16:58:58 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 6E31114010A for ; Mon, 4 Mar 2024 21:58:58 +0000 (UTC) X-FDA: 81860722356.29.372F1E8 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf04.hostedemail.com (Postfix) with ESMTP id 54E6A4001C for ; Mon, 4 Mar 2024 21:58:56 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=bfyvP5nn; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709589536; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=c7hzapgUftSzJ0qDTm+HnWc7FvIKdeON3ZcB5/QmFJc=; b=6bh0Yb31iDBAzzgw8uONxtLEeGAUzpwjr2gEmWuBif6IdB+hoLhwk1qP6y2B/QQA9aWFT5 HbKQo86sLrs3rsWSw7H1ZR+uuzfliUcjiCZwTIfp7EkSL6xDI58S1/CKBxftoWbgO6slcj BmPWTJ+hNAqpa2C5ZOur4ln+9Vdbz1Y= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=bfyvP5nn; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709589536; a=rsa-sha256; cv=none; b=xpWOUcAm7AgqNC/q6WgUPszBwais2Y3Pfg/+rDHgmvUt8irc6DyQ48KgCoW2yTT+lLVKSp GJIlpWk0evq2tyjw2XDo7S1b3L86JObc0fi/K1NiJTHynaPOqAEE2p6h0e6oLb+Eh12c6/ 0MKOXCuzkthTn192njIAHu8xDadbJy0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709589535; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=c7hzapgUftSzJ0qDTm+HnWc7FvIKdeON3ZcB5/QmFJc=; b=bfyvP5nn3A3pMM40spBfZkHDz6Rxejx122UdRCsfy/aHy5/cREzSiIBISwxrWQyEf7DSFr w0JyGtMq/7io4ikVcbWHgUQQJf1Hv+d/ZUFQ09+tSp/GIRgxhB97aJFhlSvwawNzmZyqHy NyUK2mAU2RKf6TX+fJILmOTFgJGWBCs= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-693-3ao37qMrPxaG5fJV0QgSkQ-1; Mon, 04 Mar 2024 16:58:53 -0500 X-MC-Unique: 3ao37qMrPxaG5fJV0QgSkQ-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-412dbc77740so14679235e9.2 for ; Mon, 04 Mar 2024 13:58:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709589533; x=1710194333; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=c7hzapgUftSzJ0qDTm+HnWc7FvIKdeON3ZcB5/QmFJc=; b=nln0s0mlskmPin4syyA2j1cAkrj6O77X5xlt6xPGyT4fxXfb3SyW49vgG3kcP23KGK COnHA6+Gi2MM//4q1j9f2Jj8UK5nPM/ILQ9XTcmoQrcsReu/pofoEcJ5FPvaBvAHggCs zoG5M0RfZT0dp5F1mG7sYni47U/55kTUypi9qwC18tt0wF0X2UZ5IvEZDqW8ilYIqxW7 KGrpsVx3gAMEqmoP0DX3kQYjdXzCoEonHWUsd/I/ec8ZCMHD8G8dLoj6plpk6VTimA6n s24VaAY6cWNiVwsBNzQPS/wrt/fZsnYZm/Iz0NkBvJKGQd3xYATHObgCPJpOynqFLgm1 Fn7Q== X-Forwarded-Encrypted: i=1; AJvYcCWk1y5p/0CuQlRz+7EpJwdIE7OE+3EYuEnexQRDrXM9uVLEvmcc1Nsdcct5KRNYOC2he9Jgm6QeGZRDfpYcAMCzTw8= X-Gm-Message-State: AOJu0Yx7FqAxDP+VBmxUNwqxM8C1681ywfWzTyn4oDeC2O+Cdj/bZ78S yreodJKuVw/0j/YJR+n5nlyGA6fw05H8n81cK/pzYZCxU+F1+Wl7MeGwZP+ExCHJfPqCIcPoCmL pw+6q97ZnkrKuiQtJK8jEDINuhgi11h5nQIkhBJc1zx/LjPgD X-Received: by 2002:a05:600c:458b:b0:412:bd3e:9fee with SMTP id r11-20020a05600c458b00b00412bd3e9feemr7756058wmo.0.1709589532802; Mon, 04 Mar 2024 13:58:52 -0800 (PST) X-Google-Smtp-Source: AGHT+IHeR9iNvn8pXEWlnFCd66j+Wfk1BNaSWBq6GIz+i8Gto5IYxfyk5HuG+1KJY42N/oDLcJpYtQ== X-Received: by 2002:a05:600c:458b:b0:412:bd3e:9fee with SMTP id r11-20020a05600c458b00b00412bd3e9feemr7756032wmo.0.1709589532340; Mon, 04 Mar 2024 13:58:52 -0800 (PST) Received: from ?IPV6:2003:cb:c733:f100:75e7:a0a4:9ac2:1abb? (p200300cbc733f10075e7a0a49ac21abb.dip0.t-ipconnect.de. [2003:cb:c733:f100:75e7:a0a4:9ac2:1abb]) by smtp.gmail.com with ESMTPSA id i5-20020a05600c354500b00412e668b0dasm2956081wmq.43.2024.03.04.13.58.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 04 Mar 2024 13:58:51 -0800 (PST) Message-ID: <4b0fd46a-cc4f-4cb7-9f6f-ce19a2d3064e@redhat.com> Date: Mon, 4 Mar 2024 22:58:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: folio_mmapped To: Sean Christopherson , Quentin Perret , Matthew Wilcox , Fuad Tabba , kvm@vger.kernel.org, kvmarm@lists.linux.dev, pbonzini@redhat.com, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, viro@zeniv.linux.org.uk, brauner@kernel.org, akpm@linux-foundation.org, xiaoyao.li@intel.com, yilun.xu@intel.com, chao.p.peng@linux.intel.com, jarkko@kernel.org, amoorthy@google.com, dmatlack@google.com, yu.c.zhang@linux.intel.com, isaku.yamahata@intel.com, mic@digikod.net, vbabka@suse.cz, vannapurve@google.com, ackerleytng@google.com, mail@maciej.szmigiero.name, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com, suzuki.poulose@arm.com, steven.price@arm.com, quic_mnalajal@quicinc.com, quic_tsoni@quicinc.com, quic_svaddagi@quicinc.com, quic_cvanscha@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, catalin.marinas@arm.com, james.morse@arm.com, yuzenghui@huawei.com, oliver.upton@linux.dev, maz@kernel.org, will@kernel.org, keirf@google.com, linux-mm@kvack.org References: <925f8f5d-c356-4c20-a6a5-dd7efde5ee86@redhat.com> <755911e5-8d4a-4e24-89c7-a087a26ec5f6@redhat.com> <99a94a42-2781-4d48-8b8c-004e95db6bb5@redhat.com> <20240304132732963-0800.eberman@hu-eberman-lv.qualcomm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240304132732963-0800.eberman@hu-eberman-lv.qualcomm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 54E6A4001C X-Stat-Signature: hb8fikqkkbntdw4fmwnwjs4qt518gjqs X-HE-Tag: 1709589536-916625 X-HE-Meta: U2FsdGVkX18Avz2eXICY68Gp55mS4s/+EMveH6dQ3HgpAb+CKL8/qVR82iuqAgyl21B9dGJ6fthC0BjRGpY2AZxr42eCL/khqvsLgUpvu+TRen/SLa2L+Gq99PllAFmdKiw7jVZH+wyJzydp0KLRKY5C4Wt5Mg3ZaH0N206+5DTajBplayNdYpY2Z3nutfCLkUJSkD4AaNt2TEQzCk3oZw0bbfD1XAj3G+mtikSNb8Sb8rTGblUwcQTGlqHv4wT+KLMf6sjVT0hpzqXxdGoXULdgyn3SlZCpeSE/knTVxI1FlqSAsAE4ys7hQ7efXmLlbvsB/zBYXNyjcJcS76bcHl6CUHyJvYTTDPFUoV7skmzxUNXsa4ykouc6QgCjZU3E2ELsM2cgvhVtkpKh7toqomKac+7LvelokkUMH2UQ2XFTylpUGc70hvaYMux699Lqub36FNPDWA05IVmmCCc4n8BCkYcO6ot22AeCJx6TjT5EU2ctGHV1+/HkNOh8C7frP3iKYb1Ia8Y8Uy1K+hyldFpwAUJj8wn91Aqt5Zs05HqgjD/htkP/J2oUJFk423kPqyyGgSF2NNmmi87gcBURf9A6R/GKlofRaiNLvSEA8fw3+nNYEixfsYMT/REFrJ8sgNKe1A5fpjvRNFgjx6L4l1FVFrNBxjWUEKd3vRyWZ/LlekNbBBrn746xPyI/lwV/Vs6Shokor2nTEhSUKhfGAxtF6zcGWXVOJeriqii6jI56XLgBtLCxVZ3arat+6ZQAh7042rW8Sz0Tcs8SXF5eyiyfmT0DEIuBEG8Uhr5RmJiytgIfZHnAtaiZ+4eXx5hVGQBVBsCFjn3po5pXLkEdDgpQsy8wu78f7lO8+X/joWcZRY3MigNwy2BN6LAp7agy3XnyQqzqPoJVXHrQca4yr6hK9u7yefwOgAoQAC7kPUr4WAck4UnU0xacyAIwc/GhRMY2DqUZ3Q3cyPsw53v ZiNWkMkh RrqZvFV7LT32U+nSerUozGF1XHwOAkBBkOqxXj4sXJv/TRYjP8OceDQBzgDAFUtKwZcuwOzN0z3R8Ok+FmunOg/v/FYD8iDNMV9c72I1RPlV9frexYKsqlaQywwoNZ25D1I47p09/byVFlfhigY6/tU+PE6hlw8RlkRoV088DvlwrjYpq3ts+LpEhthvV+Ek/odidhw2J6nN5MIn+Y/NuBHtewpjz8BznzZPSdyTJGhxlCrKTL2p0B//9Ru4rLS8XaE2AyIK4WSEuG65eRfWm9AX3lbO2UR34cCq/ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000012, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 04.03.24 22:43, Elliot Berman wrote: > On Mon, Mar 04, 2024 at 09:17:05PM +0100, David Hildenbrand wrote: >> On 04.03.24 20:04, Sean Christopherson wrote: >>> On Mon, Mar 04, 2024, Quentin Perret wrote: >>>>> As discussed in the sub-thread, that might still be required. >>>>> >>>>> One could think about completely forbidding GUP on these mmap'ed >>>>> guest-memfds. But likely, there might be use cases in the future where you >>>>> want to use GUP on shared memory inside a guest_memfd. >>>>> >>>>> (the iouring example I gave might currently not work because >>>>> FOLL_PIN|FOLL_LONGTERM|FOLL_WRITE only works on shmem+hugetlb, and >>>>> guest_memfd will likely not be detected as shmem; 8ac268436e6d contains some >>>>> details) >>>> >>>> Perhaps it would be wise to start with GUP being forbidden if the >>>> current users do not need it (not sure if that is the case in Android, >>>> I'll check) ? We can always relax this constraint later when/if the >>>> use-cases arise, which is obviously much harder to do the other way >>>> around. >>> >>> +1000. At least on the KVM side, I would like to be as conservative as possible >>> when it comes to letting anything other than the guest access guest_memfd. >> >> So we'll have to do it similar to any occurrences of "secretmem" in gup.c. >> We'll have to see how to marry KVM guest_memfd with core-mm code similar to >> e.g., folio_is_secretmem(). >> >> IIRC, we might not be able to de-reference the actual mapping because it >> could get free concurrently ... >> >> That will then prohibit any kind of GUP access to these pages, including >> reading/writing for ptrace/debugging purposes, for core dumping purposes >> etc. But at least, you know that nobody was able to optain page references >> using GUP that might be used for reading/writing later. > > Do you have any concerns to add to enum mapping_flags, AS_NOGUP, and > replacing folio_is_secretmem() with a test of this bit instead of > comparing the a_ops? I think it scales better. The only concern I have are races, but let's look into the details: In GUP-fast, we can essentially race with unmap of folios, munmap() of VMAs etc. We had a similar discussion recently about possible races. It's documented in folio_fast_pin_allowed() regarding disabled IRQs and RCU grace periods. "inodes and thus their mappings are freed under RCU, which means the mapping cannot be freed beneath us and thus we can safely dereference it." So if we follow the same rules as folio_fast_pin_allowed(), we can de-reference folio->mapping, for example comparing mapping->a_ops. [folio_is_secretmem should better follow the same approach] So likely that should just work! -- Cheers, David / dhildenb