From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D832C25B74 for ; Thu, 16 May 2024 12:15:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E54806B03AD; Thu, 16 May 2024 08:15:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E041C6B03AF; Thu, 16 May 2024 08:15:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CCC2C6B03B7; Thu, 16 May 2024 08:15:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id AEA6A6B03AD for ; Thu, 16 May 2024 08:15:26 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 4DDB5A0825 for ; Thu, 16 May 2024 12:15:24 +0000 (UTC) X-FDA: 82124154168.06.89F7E58 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) by imf16.hostedemail.com (Postfix) with ESMTP id 6957B180021 for ; Thu, 16 May 2024 12:15:22 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=WEQ1BZTP; spf=pass (imf16.hostedemail.com: domain of seakeel@gmail.com designates 209.85.214.175 as permitted sender) smtp.mailfrom=seakeel@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715861722; a=rsa-sha256; cv=none; b=oGjd2CiaK6/dlv00DCnBf4n6qxwl/5rfg6+2pyzeNvYuYoaCSEEIv1mtxn7qY5PodQrT+8 d8rk+lMNgVMSQ73l7fMqdwDJOsJ4vf3oObGzQQlYLFvU4YVfwGXoyQ9ZY+uFovE+zi76+S J37N7TN82StceT4D3oysAGrOSkgU9C8= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=WEQ1BZTP; spf=pass (imf16.hostedemail.com: domain of seakeel@gmail.com designates 209.85.214.175 as permitted sender) smtp.mailfrom=seakeel@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715861722; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0ioNigop+YRs/yu7C5J4vy2YtEovm2LIax4d5nifJqE=; b=Db2Zy/6someFdZhZgdBIn6IKGSwFGpSIVfuwBa4J/Ql4a4mqK+5MXJiybP5+3CVSW/a3zf hb4Ci41Zii+zo0Pn/GC6FvtTROlINk6GMHo1KcREm7g7DOjeB9vNay3d3XN/+CD+W5I+nV +Kig+spi+vuymjzd4GSUbZKyS9MGJxA= Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-1ee42b97b32so66060855ad.2 for ; Thu, 16 May 2024 05:15:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1715861721; x=1716466521; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=0ioNigop+YRs/yu7C5J4vy2YtEovm2LIax4d5nifJqE=; b=WEQ1BZTP23wmwf7GFVlwuX1ook+SC/V36EQRbSpMoAoNa4lDKWJLjkndvnT99zeMrc otkqVGI9Npg+ivs1jyiHeEcvsuXpn0Q53UritJ4w6Exe1rL9bKBg83frWNGFFoGAi9GZ I34mm83vHGuRkobfvgsW+2UftLfHnz1oUtP6Y7e3vnZxrWNRBRHyrEAGBdXUP5VaMJ+2 IrfSwFCR7mMNB7ReG8sYdYuoom70aDn6oja/samPmfMaszoJK5Q4TcgdASvwj1oMZfMF X/FxOOQLUv7ginPygjG6Kg6VV1bez1NEDqdjYuZWxR6Nu+g3m0jFJYl9RYuBSsMEtV/i 8z7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715861721; x=1716466521; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0ioNigop+YRs/yu7C5J4vy2YtEovm2LIax4d5nifJqE=; b=fAW7HfAiayCfpI/BRHLse3o1Ohr8nFWfJGN8zfn0Glkp7kO+1jcg/SaYgk4Mc33+hx WtM11KA+oHIeSXZgquoZl/8TiMz7qCzmgCyQ1mRXqxKSoFCtK9WVqFiXoYCEZEOK7f0l S8u0KtN15917k/MCu4xbD9gUVcewc7ddYL1Ian8R0XxqmGhqiqCyP24ezogRKryOifHY jaOvsv3MOMrGrgd9ge7HGoTLIvUPEnQUD7b4ucpJtXgG8wVtgig/GUXOL6Ofej8xwXU7 Av8YcE7ua6rTtHJ+J54trOU3NdRiR6hYMY2RjR7qTQ/u1nGW8tGT/O6SugAwdNyRaiFh qFHQ== X-Forwarded-Encrypted: i=1; AJvYcCUVhjHgqIDWQ4iNFiH45op+2LxcNI2wSKVUCHXngQ8ek65C8CPAJyHTEUEsKT+ZfDRHxW6s6EO0LXhOxp4+j1Ef0qU= X-Gm-Message-State: AOJu0Yw54MKn8gQTxvmTUi3gmQ3aWP/d7lUCLYirXqSf2vpHpkNO+brU mXjlVKmDLqyUrQfWI1Z75QgaUQpG1D9BffjUmg4ci1XA3FFqaAi0 X-Google-Smtp-Source: AGHT+IGV6HzPxZ3Fqfjo6kNHJDzLjJZs4he76NtC0LWoZCoSKgKfFZ54pjEXlzHLBo1kc50FRScyGg== X-Received: by 2002:a17:902:ecc7:b0:1ee:fc5e:5cfb with SMTP id d9443c01a7336-1ef43d185f5mr234625965ad.19.1715861721116; Thu, 16 May 2024 05:15:21 -0700 (PDT) Received: from [192.168.255.10] ([43.132.141.24]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1ef0bad61c7sm137634015ad.68.2024.05.16.05.15.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 May 2024 05:15:20 -0700 (PDT) Message-ID: <4c255baa-99e3-4f48-9303-13edb99adc89@gmail.com> Date: Thu, 16 May 2024 20:15:16 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/4] mm/ksm: rename mm_slot_cache to ksm_slot_cache To: David Hildenbrand , alexs@kernel.org, Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, willy@infradead.org, izik.eidus@ravellosystems.com References: <20240428100619.3332036-1-alexs@kernel.org> <20240428100619.3332036-3-alexs@kernel.org> <2e074a0b-7ab6-4381-9216-31f68a738a07@redhat.com> Content-Language: en-US From: Alex Shi In-Reply-To: <2e074a0b-7ab6-4381-9216-31f68a738a07@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 6957B180021 X-Rspam-User: X-Rspamd-Server: rspam12 X-Stat-Signature: uwfn4f51hgjftqu3p7rrqxb15gpkhxq3 X-HE-Tag: 1715861722-97842 X-HE-Meta: U2FsdGVkX1/SCIqRsgpWd6p+JEKOLiT3pt+sbscQmgkOYwA8woihG0btxq2QsLAMlhqifYfZ+S9HcF3M4rXaK7AWYR9y6n5LU2V+Iw+sOyX8r4XWYT9WsZfEekRtk9kLnydudd8WMCwlr0/GscplWaX8aPnHmHDlfIL8kes2NuARe08ZXdMV/BYvmjWqSIQqC//wD8dh4X+0JInjNChAecAmqjgGpShsisJqNW6nRmlOt5LGCW++ScJgv0Y9AfTx1EFNC30PUP4iXbHI15y/cNKJThFHG/jXFTdnHUVJG2tlk5zqfKfm83VfSykKQvO9CLpHlA9JhHV+8m6F5w6gM6v8NyX4qAYIU3b5JqiLOJrQrC73Fepvukf9gtUHJ1C40WzqQTd3rUdqlHr1l8AgYlehcx2F335bDi3SAqnv8XAcBDBieN/6nNUSkKlIsUEhpk09EJsq3Ee2zGPCZ104xLkfhZkdWb8jXAy5v7nlX+gP9qQKtZXsottDHgshIkz8RfFii43C4UHHUTq9fefSVCmxipeswMOMuxYHt5x9iBmfollvIJf9XDCUpv9heFrfQ4uyqLmFovkLnnCVMpeA7fR/YeP+7SJ4Mv2DB5lfO+MNmMQDdsZd7JSbL+sIxPoo93szATdRuuSAYDsgjnYJkCmg+bWh7QQ6B3+/8F1Nt6hWu/i9Y3G9ByYJYD2AIK3zh4ganE7sYt/1+6rCSci3KF90j3JHKUWETab0UtXO0E3Ov7TSxR5agfCjiXV9wDRJhWjNe2Y+/1sxhJ+G/ZsPp0zR8L115nE0Z2n0exiZMZKhaJV2usOu7sbb/S8ovxDmZL705BisPc6j+6vvupXlwZ7GLyELnEYlzfjOvqpXl4mvhBjx8+1DHHrzou4+eliL4B9f1eiIFeWzFEMwk3ibyi2hz6qHvL0kUGDu9v4ubKYWyDjx1qI/16gb+L9y1j2391+peYGNZgCWFHKK4vE 8D7s/Q16 N593URf/vCgvXCyo8oyzQYhKIQ3WGfdWu73Lq1GavzqYd9HD/Hz+wMGr+OOlwHP2QgCucgiYe931k1rEvsP81+n+hj67FQhyC1V+glUzMIsNPHdMwRY1792TVmKhFm+qZsKUEbPNX9TZExNfcEwhApT+QbgSGYcPEx1mKhxmdr2/gsmWcX1Qm0UlYfh51oe4E1b8rvUlMRhIz5/m64uCSInklStf3wbB1NNgmXZqlTfQnWtLyWRt+iBhb6rFBg7/hkVVM1Nazkv85KPChTuYqN71DeIoln2/e8ym++CLVUplT5PTkD72zgsa8vurk33wmpvq56wVWhmrhwnr5e96DJL+OhuggKV9irG/1IBUR66bop/c/81K6muyViWEycyw+w21SY+XOa8GZN5WNrG4IwG610wxXG+czvcUrtTvv1Wvlg6MpYXtcSWfemOYryeIvDDZPsQBi2k01tJtP03Ct5XGb/icLGZ3FVwKug0Ra4Feojjs5i0QOF89wtsf5F2N2PS/rghtDxEWQ3cX/e8bthjIj/nLaNXcubsiN X-Bogosity: Ham, tests=bogofilter, spamicity=0.000585, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 4/30/24 8:57 PM, David Hildenbrand wrote: >> >> @@ -2972,7 +2972,7 @@ int __ksm_enter(struct mm_struct *mm) >>       struct mm_slot *slot; >>       int needs_wakeup; >>   -    ksm_slot = mm_slot_alloc(mm_slot_cache); >> +    ksm_slot = mm_slot_alloc(ksm_slot_cache); > > Similarly, this makes the code more confusion. The pattern in khugepaged is similarly: > > mm_slot = mm_slot_alloc(mm_slot_cache); Could we rename it to khg_mm_slot_cache in khugepaged? > > I don't think we want these renamings. > > E.g., "ksm_mm_slot_cache" might be a bit better than "mm_slot_cache". But then, we are in KSM code ... so I don't really see an improvement. Thanks for comments and sorry for response late. yes, ksm_mm_slot_cache is better even in KSM code. As a cscope/tag dependency patient, this change could reduce much of confusing in name searching. And that's why a one-side change satisfies me. Yes, maybe better naming could make it more readable, any more further help? :) Thanks a lot! Alex