From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67C51C7115A for ; Wed, 18 Jun 2025 17:23:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E41C96B008A; Wed, 18 Jun 2025 13:23:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E19826B0098; Wed, 18 Jun 2025 13:23:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D08626B0099; Wed, 18 Jun 2025 13:23:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id BCCA66B008A for ; Wed, 18 Jun 2025 13:23:38 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 1CEC616079B for ; Wed, 18 Jun 2025 17:23:38 +0000 (UTC) X-FDA: 83569193316.28.2165E52 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf12.hostedemail.com (Postfix) with ESMTP id A41F740004 for ; Wed, 18 Jun 2025 17:23:35 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=aYNGzA5A; spf=pass (imf12.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750267416; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IZPpWXUlnKeNwN9q+QSTXWJIm5lmGOFm2ysA2/qMU74=; b=q+cb5ZHLS16fxGzgehjJiXDJr9lP5oC1DdCBzXFEElyFc1ZaJSPb0cox3r+OUONQGV6F5R xwKbJyjGpWQu9cgSn/mvvQyQ5/Q/IGQchZRGPac8L1ZbkXw/BZqNwbcoGNKbig7bmw7QGk t2o0MaI3HQDTJwySWkeB6spJ0byEvsI= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=aYNGzA5A; spf=pass (imf12.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750267416; a=rsa-sha256; cv=none; b=nONo2hXEH47hWVDxcKYLJwkq5tlh0m6F9w0Jr/wZJFOLf64Td8YgXxlFcJh35FwuPo2c/f VFvpnHSPbabE4Y83yMvkHXlQ9pc7LjQg1YrsMemeenW1AlcVN3q0j6PSHJWkk+Eb3SPOW0 Jl1QVFEcbSh8UyLpz96tcaRxXmVXwWQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750267414; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=IZPpWXUlnKeNwN9q+QSTXWJIm5lmGOFm2ysA2/qMU74=; b=aYNGzA5ATsKWmrBR9ik8Gvfti+uuGOFM+6qap8QAavz460FxVcVNc8B689U+yTD6f53e3M AnO3g+sLkXErjL67qvI5detY7N9QdDCxIusZDmBoN0oe8FNoBdFq0Q4uEtLnyrHTojmHj8 F6gCNeEBBDmuFouZ2H75BSCuP9BqH3k= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-12-JVYmzmx6NQScvGKEP5d_Zg-1; Wed, 18 Jun 2025 13:23:32 -0400 X-MC-Unique: JVYmzmx6NQScvGKEP5d_Zg-1 X-Mimecast-MFC-AGG-ID: JVYmzmx6NQScvGKEP5d_Zg_1750267411 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-43eea5a5d80so43023005e9.1 for ; Wed, 18 Jun 2025 10:23:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750267411; x=1750872211; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=IZPpWXUlnKeNwN9q+QSTXWJIm5lmGOFm2ysA2/qMU74=; b=G6O2UAsEHy6TToMKVEbeVMh7z0p2vGIf2PVIcdo17z1X2d+EEvoWSaXFIcqADFytBD bBBrIUqMV5nr18zKfwrk95IcNI+jISHLVnp33jQ2mPxuP0b5nc3Ehmd5rIJfcD2BRSan q6TErCqdDIvj1NQkUdIbAwE+rz/w8E184Ww9/W1zwQbp+q0SUQkKSTkJO2V81L7T31fQ YMEdWET1d2hcORY7siviMoKXZfVLceGLrx2NBs8aSqcuST1ugJfdXgN57jXKNV5n3T4/ S33LjIb8L2DdnVc7NHPxCuOdUbkU8lJuXBGWawC2tBsr6etBAbPrxZ1ZP609cSEIIlQY FTMg== X-Forwarded-Encrypted: i=1; AJvYcCWyToHKJGK2P6TDltDh9eBcqI8kHuNoBB9ueQD5VqZF85j7JPS2KA2hHtH4QFTxxGRFOAvfZehWHA==@kvack.org X-Gm-Message-State: AOJu0YxhJdMfw3oipQjUfdOOupzAvBT0dfWCiZ416Z7mstI3eQJk9YeG lg/eF4tgz7Rui9fSAt0A5uee+fPTKWfUimqufL6Nt6lpjTeMSyHSLudCD++7oUZFJlkF9tkAraE ng8/JWyoo4B3twPfP0rPXT1McWIX71B02kgqaxNbGqfJ7T+g2JfWt X-Gm-Gg: ASbGncssP5cHMImKvUJTBkwLi30pEhgI+M9K4Fr3RJy+vxfOy2poRjzKLPoXLtQEykQ EVJcUxhDcmUfIxfXY4wSshX8GB7qIv3md0swTmhO96YihP5EX53i0DjKoOMSw8QPaAb9D0k8rU+ sIpgjXxamSlFURsHNrcK1Lfy+PLJQHfKl8ezQ+e4QMnZNWZZzF5T32DEHqSUa5XmuZUqFV7HD7F 4Lq9rqTjZSA9mJQoKY2vxCY27I9hdevAnSvNgTLyAc53ZCc3R6bi8K2Jh1iR7ZMMuCB0Zxproqv OiWYH/+z4i38uXMo5fLNrU5jClAx7gsVutTEYJKB9UsIqiuWIYkrwRITqmIoWL6vXn54h+3OZzk Z628pEtCYxmZ5C7YDKPMl8NFKkBwL7VfB1R1NEdgyp3HvnA8= X-Received: by 2002:a05:600c:820c:b0:43c:eeee:b70a with SMTP id 5b1f17b1804b1-45351d76416mr76334865e9.22.1750267411236; Wed, 18 Jun 2025 10:23:31 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGWLOXcdGrXcCpooZZvZAIIwuZrYCyizxV+dBTel5EEmzbnVTkPUsz64b6qSvhtoJbS1GbG0g== X-Received: by 2002:a05:600c:820c:b0:43c:eeee:b70a with SMTP id 5b1f17b1804b1-45351d76416mr76334695e9.22.1750267410886; Wed, 18 Jun 2025 10:23:30 -0700 (PDT) Received: from ?IPV6:2003:d8:2f2d:2400:4052:3b5:fff9:4ed0? (p200300d82f2d2400405203b5fff94ed0.dip0.t-ipconnect.de. [2003:d8:2f2d:2400:4052:3b5:fff9:4ed0]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a568a7cb65sm17721293f8f.38.2025.06.18.10.23.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Jun 2025 10:23:30 -0700 (PDT) Message-ID: <4c7dc187-bd04-47c5-b619-b91b83cca913@redhat.com> Date: Wed, 18 Jun 2025 19:23:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] khugepaged: Optimize __collapse_huge_page_copy_succeeded() for large folios by PTE batching To: Lorenzo Stoakes Cc: Dev Jain , akpm@linux-foundation.org, ziy@nvidia.com, baolin.wang@linux.alibaba.com, Liam.Howlett@oracle.com, npache@redhat.com, ryan.roberts@arm.com, baohua@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250618102607.10551-1-dev.jain@arm.com> <738669ec-a9e5-4ba1-85a7-605cb4132d05@redhat.com> <42aa7d12-3f84-4ee6-a067-5aee30ec677d@lucifer.local> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <42aa7d12-3f84-4ee6-a067-5aee30ec677d@lucifer.local> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: lA84WFWB5cZnctRCqDQKsdCQ1xfbCAgZ_Jciju8CAuc_1750267411 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: A41F740004 X-Stat-Signature: yj8ic3qxkbig95zkb3hh6xwx98ubpg4q X-HE-Tag: 1750267415-927551 X-HE-Meta: U2FsdGVkX19ZXfkjs8MyVEx9iJnIOy3fOY2k6qdZ71Eqc8Vocdhni1CmCiwQSkHB0ETY0GpdySckRTLi2yHzQGolYN/mzjo/hYGrdsg1TeoUKuYLyGpLPsSa9i1kQQMt/vivllF9M85bjWQo5e2S0shwVN9rjU3uawZneGhIhlQ64lZYz/kR3N7u8iulluK8p2UyvgbWLmdkxl4MwrqAPWejY/qBwOTiMZGhE46dMqz1j+QNrSHHskKxXV3hE9eJvupn8ZtI/+UntdwE1ZV767UMV6v4yf6HKtX4dGuk9yepkb+Y2naDWgCMhvnXKcOBfPx2wzDbI+LBeBFWImvveUStGWbrbRkD/y/0EjOSoFxK1Z3O03KdhE7q4S6IMsvmQhTAL+GRQt3YEMmcyfTLAcq4R/VvOcr+qLiv89mSWqEnxmX3095D4G9auvjGhHFSLEvLHBvHKUssYrpdNCm9lyLyY6CczMxKOsSm0cfwVfMRK4kYeEsxuzX8+5DZGLpSilSnHMffO4naSpJK3g7VqP73ldg80t4aDIFdFIrKtFOgnD3/GHkHHdY/3teqbFvkFYUHGJxxWKRV0qjHMRi469Ar2JpBgnkj9dFMKcwBuatUhRtZtph7OzrngEz7s8C4WSHaFB9Mh9e83prN5ZHoMJeUM8Uuv9ladopip6XxPD6D/7/Bp+/1yZ5W+xz0vW1ZZBq6O74qNdRG2HBC55GpyjsOc0ZvRA3ONpvwkiRMYNyk1q76DdSO0bA8Tj3Z4oZCVlFjpIPiT6dq3Wiy8/2TWUk/x2VWRAYb8MNVl4ySMhittdnbOn5t05g2nLvj3BZDlDJhWYuijkz+vpPgx8JKvfwtvKOaEBhXYPA475UZF/cErfWLq2gUWpSFIFHEHAi69wF7gNlJPbrDZjS1kraYhPji8t1fD/opLfT8D7c0xacTshHEXEvNZRdrqnhfBEX1gRgFJfIqRyEy/2zy7HT 2SCIn9SW EGjFPDjPCeKv6dkYC/OzaLNMuwNwYTyiWAHRTd1iQYLh/W9fpXtEBPX0u5zC29Md2kFSLcFPYVCWrR0JfxNj0K9bTLxmgLfRm3yIvGBgtZxcTXs6YqyHi8T8J1Krh/Ew6Qx8M X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 18.06.25 19:10, Lorenzo Stoakes wrote: > On Wed, Jun 18, 2025 at 06:14:22PM +0200, David Hildenbrand wrote: >> On 18.06.25 12:26, Dev Jain wrote: >>> + >>> /* >>> * ptl mostly unnecessary, but preempt has to >>> * be disabled to update the per-cpu stats >>> * inside folio_remove_rmap_pte(). >>> */ >>> spin_lock(ptl); >> >> Existing code: The PTL locking should just be moved outside of the loop. > > Do we really want to hold the PTL for the duration of the loop? Are we sure > it's safe to do so? Are there any locks taken in other functions that might > sleep that'd mean holding a spinlock would be a problem? It's a very weird thing to not hold the PTL while walking page tables, and then only grabbing it for clearing entries just to make selected functions happy ... I mostly spotted the release_pte_folio(), which I think should be fine with a spinlock held. I missed the free_folio_and_swap_cache(), not sure if that is problematic. Interestingly, release_pte_folio() does a a) node_stat_mod_folio b) folio_unlock c) folio_putback_lru ... and folio_putback_lru() is documented to "lru_lock must not be held, interrupts must be enabled". Hmmmm. I suspect that doc is wrong. So yeah, maybe better keep that weird looking locking like it is :) -- Cheers, David / dhildenb