From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A61DC61DA4 for ; Thu, 16 Feb 2023 09:24:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 78F596B0071; Thu, 16 Feb 2023 04:24:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 73F6B6B0072; Thu, 16 Feb 2023 04:24:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 606DE6B0073; Thu, 16 Feb 2023 04:24:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 4D80F6B0071 for ; Thu, 16 Feb 2023 04:24:58 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 2086D8116B for ; Thu, 16 Feb 2023 09:24:58 +0000 (UTC) X-FDA: 80472620676.03.E349159 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf24.hostedemail.com (Postfix) with ESMTP id 333AA18000D for ; Thu, 16 Feb 2023 09:24:55 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=TJs4NBTZ; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676539496; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zbwN4ynIlaU5oA+cvdp2uCZwDHqo0yJ8G9tkzU+m17I=; b=WIN2RUk6dKOvg4shTit7TyQy43X2B7e9gv0Rwmo9fGhTH8t5idJOlk5i6wvveC8YVkmUIa 6zHYR1hz5L4eWbTrpXP0AQGOaESIDj5MDE8DhpFLvZbPU3eTttCbKRNA+yZhU5RqkvbpuP dKorDrfaa4mzmMsw9L7RqL+xq/LG7ns= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=TJs4NBTZ; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676539496; a=rsa-sha256; cv=none; b=dmsOZL4a0r2oBvfW1YYCvxKSj8HK0vjNEJ98BwMYyqSc8lpLx+dztARAsW6hJqDNyaK7Oq i3VrgVGNRsIeM2rGcgiGpnDiV39UPVpBYCbeJPxYY6xk2Sh6tl03Lrs/UYwyqtOkUrDWlR ahEeL61TyvcQIBwapwkje71LvSv8hYs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676539494; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zbwN4ynIlaU5oA+cvdp2uCZwDHqo0yJ8G9tkzU+m17I=; b=TJs4NBTZQpvH2yAznbvG/xXpzZCGMQ+2mN2H1bQ7CymAnMLekQ9YfcQ+i+YmcC0Bkx/6GN 9XFK/FuPGCSrFMzPFA3XksGALfXqHGLiIswln8j7yLud8TsO1sdWSnXGZ3tRSpD/Ul4ei0 Op6lMJE/2osmHkW5u3TPAw0/2gos8P8= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-247-7XTB94-iPLC8_dERnn3OFA-1; Thu, 16 Feb 2023 04:24:53 -0500 X-MC-Unique: 7XTB94-iPLC8_dERnn3OFA-1 Received: by mail-wr1-f72.google.com with SMTP id r11-20020a5d498b000000b002c5588d962fso138385wrq.10 for ; Thu, 16 Feb 2023 01:24:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=zbwN4ynIlaU5oA+cvdp2uCZwDHqo0yJ8G9tkzU+m17I=; b=TroMdf2xyBwFgY2nse6UlUD8WO6tKV5kSuLmtatCeVupARfWraoil4DPLXxDdix2iL 5nInqcPZBGQdo/hVSg24BbF2lquEdzdtDmcluVqvTUfY6ohO1HqkOTSVzfpVQGNhXaj7 Eyxz0i6MceX+sZXBkqjNFOtvN4hzHY2TMw2xFPS/onOrONl3QSGDsGEw+nChCfXQ+Xjp Pld01TinjuiLc4GBPUHvOjiBQzF+OM7I9CC1/yt+Rqm/2KuNgHZjxfx5IPBIVLjj/mt7 r2IZDq6ojH5AJBY/HUIIbKElwvVgjrKU0xzmOSyzqgIdsMsistdDmH/SeNUYG9vFb7n2 M53Q== X-Gm-Message-State: AO0yUKXClUEa3HgIMrYFs4WQaaHqxj97+v8Sf1eu9wf6iopAeqXdzk4n DM1+hEWway4bTR3qu9N+Wch21f5/ISEvDqwYPkHboACNBXfHtsv3d5dxSXyxNsmt/bwbZlHHsDV esH+Yt0V9yNg= X-Received: by 2002:a05:600c:1f06:b0:3dc:3b29:7a4 with SMTP id bd6-20020a05600c1f0600b003dc3b2907a4mr1193241wmb.0.1676539492009; Thu, 16 Feb 2023 01:24:52 -0800 (PST) X-Google-Smtp-Source: AK7set8yIWuMdBa6tQpAWLlLFZv6cp6xxL4vEB8AtZu0NusGqHmYuOPN2Xjv4WPCISM9752rdICA0w== X-Received: by 2002:a05:600c:1f06:b0:3dc:3b29:7a4 with SMTP id bd6-20020a05600c1f0600b003dc3b2907a4mr1193226wmb.0.1676539491674; Thu, 16 Feb 2023 01:24:51 -0800 (PST) Received: from ?IPV6:2003:cb:c708:bc00:2acb:9e46:1412:686a? (p200300cbc708bc002acb9e461412686a.dip0.t-ipconnect.de. [2003:cb:c708:bc00:2acb:9e46:1412:686a]) by smtp.gmail.com with ESMTPSA id u22-20020a05600c211600b003e2058a7109sm3927920wml.14.2023.02.16.01.24.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Feb 2023 01:24:51 -0800 (PST) Message-ID: <4d29a9ec-027d-06b9-8543-87d386e58c94@redhat.com> Date: Thu, 16 Feb 2023 10:24:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v4 2/2] mm/userfaultfd: add VM_WARN_ONCE() To: Muhammad Usama Anjum , peterx@redhat.com, Andrew Morton Cc: kernel@collabora.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20230216091656.2045471-1-usama.anjum@collabora.com> <20230216091656.2045471-2-usama.anjum@collabora.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230216091656.2045471-2-usama.anjum@collabora.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 333AA18000D X-Stat-Signature: f6o8y3qtc1xkqypouhiawqgnd6dpcgyq X-HE-Tag: 1676539495-976458 X-HE-Meta: U2FsdGVkX1+pFyommGOACebGM7yaxiB7iwy+zepyEKVHMsmilD2YYlHFRleJNRVIVpbVRQvVpux+EhHm76p5xQfItOcHHheMlKZEm27yWoAErgEgkeokQKpXubNp1PB8AdQxhDesMgeiw2i+W6Ci681BGySVB+yNP5xtS1NjPWQCkmgbkH87fyapX6YBHFPaHHewdId/Krhpr0r3Rt1oVyelgmq/JXlNOLvhRHGlrIkL6vHiIQELC8xWXN9NXU07A95qA1k3zhkn8u2QyntXnrq8niek4nVfVC9hGLh+SlED4SNLAFLjKC6qPlKHT7G3+By51aOAtIbjXP65EGYrler9mIhw4lxV/LQozotgZXl8e4GckdrE9MHbI63ou5jnMxHpxsDOpzQ1uQEQu8Ig41tmIjIZqCuFHmyspx9t+VRTynoH/M1IA74K9CEuOyX9ODCaj3RiV0/m6K4ZC29R+slez+WbIPfB0rLf5nfZRjcWuM1sr3zoeoeDUo+Oe5dfhvARanowSp8LGHi820wrAwGIoA1xwtFbFvfxB3P7/HVR4HAHUA+xjbKLrT/9uPesb/6l/Bk36+FMXaxqtWkhawd3Lfq6/TiUX4hdY5rnDSBNaBne8WhQbXV3/G5j7JSg/QAxUUwtrQF9ZS80qJ8Q/L4QwhoNDrtud1yVk3ZOyUdKzYgCVGUCrhvQPYvsuTkS51+VUv5euW+0yU0Q+NnR8RQJ6kM93mvl612tRZXOebgNGE8azzGSMSKMT2/4eiWIPb0oR5K4PgfvF6dE7196UAUvdEsLN4fdfJi92SKlH8j+6qK/HEFcRWXxd3kaAOmVIDgDxHGGYKLs1On6B7faWSlDJh6ouvPnaWvEE7O6pRHObUz0KFMLj3yEwhJ6+RLWJDLx2BdC9GATnnwiJknZP6Zmk+4IgezmfQay5VAlAHsSztwaFwTBCta24wxkadv454q5CUiEncMEGiLtpEV 7jqXvTam 4n9rnlSh8vag0hNMTOlt4Xn9ed5ZieJNVt6OsrB5XmCtI4PPn4PL4LV2OuPlFzDow6fCUFf+mdDRcaJLx7lUmRu4hH+FO5SUAcJ5/Xj2URUAf9Hku3FLVhl2j1YiR0JkGGHr8eFlsUs8RWlM6dRgPPl5f8FXgwTO4y6WaiRgCIXYrlY9NfArMnZa13ysMFGbyBz3emvdXyEqm7rmXoC1JefKeREImunXSxdCoAO/mJMy+OyJG+9L+PEipCfgIPaH64Gywk16Yy22bOeGH/iWSgyEKdnEjTM02q/h/QNBiVkSy9BCsa4QgEmRY/liXBDk+p1fSvUpfHJVma8wBKWTBombxyf6cdRdmhiR9ivtMT7QvK6Whtb4IeugKLZ0Wt43StDS/t1V7lveA23/C6fZPl9W42w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.008858, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 16.02.23 10:16, Muhammad Usama Anjum wrote: > Add VM_WARN_ONCE() to uffd_wp_range() to detect range (start, len) abuse. > > Signed-off-by: Muhammad Usama Anjum > --- > mm/userfaultfd.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/mm/userfaultfd.c b/mm/userfaultfd.c > index 77c5839e591c..d89ed44d2668 100644 > --- a/mm/userfaultfd.c > +++ b/mm/userfaultfd.c > @@ -717,6 +717,8 @@ long uffd_wp_range(struct mm_struct *dst_mm, struct vm_area_struct *dst_vma, > struct mmu_gather tlb; > long ret; > > + VM_WARN_ONCE(start < dst_vma->vm_start || start + len > dst_vma->vm_end, > + "The address range exceeds VMA boundary.\n"); VM_WARN_ON_ONCE is sufficient (sorry for spelling out the wrong variant earlier). These kinds of bugs are expected to be found early during testing, still it might make sense to implement a backup path if (WARN_ON_ONCE(...)) return -EINVAL; But we can't use VM_WARN_ON_ONCE here, so we can't compile it out anymore ... so I guess a simple VM_WARN_ON_ONCE() is sufficient. -- Thanks, David / dhildenb