From: David Hildenbrand <david@redhat.com>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>,
linux-mm@kvack.org, akpm@linux-foundation.org,
mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org,
npiggin@gmail.com, christophe.leroy@csgroup.eu
Cc: Oscar Salvador <osalvador@suse.de>,
Michal Hocko <mhocko@suse.com>,
Vishal Verma <vishal.l.verma@intel.com>
Subject: Re: [PATCH v6 6/7] mm/memory_hotplug: Embed vmem_altmap details in memory block
Date: Thu, 27 Jul 2023 13:17:44 +0200 [thread overview]
Message-ID: <4d6a1911-e2e2-a230-eb48-37bf0df9bbb0@redhat.com> (raw)
In-Reply-To: <20230727080232.667439-7-aneesh.kumar@linux.ibm.com>
> + /*
> + * Now that we are tracking alloc and free correctly
> + * we can add check to verify altmap free pages.
> + */
Better remove the history lesson from the comment.
"Verify that all vmemmap pages have actually been freed."
> + if (altmap) {
> + WARN(altmap->alloc, "Altmap not fully unmapped");
> + kfree(altmap);
> + }
> +
> if (IS_ENABLED(CONFIG_ARCH_KEEP_MEMBLOCK)) {
> memblock_phys_free(start, size);
> memblock_remove(start, size);
Acked-by: David Hildenbrand <david@redhat.com>
--
Cheers,
David / dhildenb
next prev parent reply other threads:[~2023-07-27 11:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-27 8:02 [PATCH v6 0/7] Add support for memmap on memory feature on ppc64 Aneesh Kumar K.V
2023-07-27 8:02 ` [PATCH v6 4/7] mm/memory_hotplug: Support memmap_on_memory when memmap is not aligned to pageblocks Aneesh Kumar K.V
2023-07-27 9:23 ` Michal Hocko
2023-07-27 9:27 ` Aneesh Kumar K V
2023-07-27 10:55 ` Michal Hocko
2023-07-27 8:02 ` [PATCH v6 5/7] powerpc/book3s64/memhotplug: Enable memmap on memory for radix Aneesh Kumar K.V
2023-07-27 8:02 ` [PATCH v6 6/7] mm/memory_hotplug: Embed vmem_altmap details in memory block Aneesh Kumar K.V
2023-07-27 9:25 ` Michal Hocko
2023-07-27 9:32 ` Aneesh Kumar K V
2023-07-27 10:56 ` Michal Hocko
2023-07-27 11:17 ` David Hildenbrand [this message]
[not found] ` <20230727080232.667439-8-aneesh.kumar@linux.ibm.com>
2023-07-27 9:26 ` [PATCH v6 7/7] mm/memory_hotplug: Enable runtime update of memmap_on_memory parameter Michal Hocko
2023-07-27 11:18 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d6a1911-e2e2-a230-eb48-37bf0df9bbb0@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.ibm.com \
--cc=christophe.leroy@csgroup.eu \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mhocko@suse.com \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=osalvador@suse.de \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).