From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A89F4C0015E for ; Thu, 27 Jul 2023 11:18:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F29D06B007D; Thu, 27 Jul 2023 07:18:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EB33E6B007E; Thu, 27 Jul 2023 07:18:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D53BA6B0080; Thu, 27 Jul 2023 07:18:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id C1D956B007D for ; Thu, 27 Jul 2023 07:18:06 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 8E067C10CE for ; Thu, 27 Jul 2023 11:18:06 +0000 (UTC) X-FDA: 81057142572.05.DE89384 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf30.hostedemail.com (Postfix) with ESMTP id 52C0680021 for ; Thu, 27 Jul 2023 11:18:04 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=TTsYiC1C; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690456684; a=rsa-sha256; cv=none; b=UaAh/jo3pRNll0K2QUQAQFOuOGZvn+5rFoKDt2XYvk+Wf5wgPXjIv0riBA58omRFQZ9HHH /F/J4dlsiugbSCIZwo6oEkpR15UyroW0n2+6TqhCQMYybJOC0rGGpkmVHmeJ3C2xJChrlZ UrjwSELWnnmyS8D9QvbAGiAQu2bN5XI= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=TTsYiC1C; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690456684; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=joTIkPI209sObt2TiAmgvJZNWubEOBjzxcWIZzxaGo0=; b=l+z5mXwpBmFmK4uxLfj5l0Qamz2Kan5dhwlIrMY4L96naIevug9XmQkmyoy/ifr7WLzHum kuC0WuOWgQYKyPtXoKWE59G1YUNB0Kepl8mzOepyCrLZD3ATpNPQE6oe6iklPpKc4IZwaH dkdd1EOj5dhu5GCn2IhaudlOSkL+5Og= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1690456683; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=joTIkPI209sObt2TiAmgvJZNWubEOBjzxcWIZzxaGo0=; b=TTsYiC1C1PWyvgfb4+q6b3699ixVGTpZEzvKkJnPtphJTHrGqvlaA63OaIR3TPXqTJf5o5 LtgMAVLP4b9MLlOALggmpRylgTasra7Yz2eefrt6goaq7ycwwh9mXn1DilY0og6/RNV7jB RXuuDpakadPsxAGRhPM5GjLNitDq0+w= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-141-ZtHLPGnMMu2ekFRpECnvPw-1; Thu, 27 Jul 2023 07:18:02 -0400 X-MC-Unique: ZtHLPGnMMu2ekFRpECnvPw-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-3fbffd088a9so4875505e9.1 for ; Thu, 27 Jul 2023 04:18:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690456666; x=1691061466; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=joTIkPI209sObt2TiAmgvJZNWubEOBjzxcWIZzxaGo0=; b=Qgbu8t83zylBYEjqr3NaxmdD+VVzUZeMasMqFmDyO5f6DOvFsNYLblfyZ78XkFErS3 vRiRQSMUtxYst/ZqP+D1LNncI3r2Bv+YEqrg1SoiN3vG9yZj9KWKYMgej9TYh0uxccr3 gP7QYujjMoN3oXt6Ll0G1WfMwXL4mi4LDWKQMqCRbTSd+j4ZkYPX3KzB4bV4VXfpgm57 PMVAakbl0vGqK92TvS4aqEWCs5dGgW1kgvf0Kz2e6IoELTJtvdd2lx28jyPcrzRzeVQz uCqTbb9LsIWGyejRASsz0rSsxw0yLEnNKlIqcBk2riCCxfvVlWVmHQztW/CzVM4MHsUu 7wDA== X-Gm-Message-State: ABy/qLYbuswmELn8H7x1p4SoVzO6bf5r1nuB1sZOf4heGEndancIvwKT nb6hbbbiGdNin1TymErGJqxKlZREP5DacmCMBxCC3rtT3nXR+uJHMM3tIOFKiMpTkr95PqMPKtY mZSdu+AfZ+2M= X-Received: by 2002:a7b:cd15:0:b0:3fb:e1d5:7f48 with SMTP id f21-20020a7bcd15000000b003fbe1d57f48mr1402320wmj.5.1690456665786; Thu, 27 Jul 2023 04:17:45 -0700 (PDT) X-Google-Smtp-Source: APBJJlEY5DqEGXXJW18qdo/6Ci5D9mGeSpbBJjJ6RB4X9iml5q95jsP91Fq+Tv53BM9RaPEt2tTOmQ== X-Received: by 2002:a7b:cd15:0:b0:3fb:e1d5:7f48 with SMTP id f21-20020a7bcd15000000b003fbe1d57f48mr1402304wmj.5.1690456665395; Thu, 27 Jul 2023 04:17:45 -0700 (PDT) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id p1-20020a7bcc81000000b003fa96fe2bebsm1558089wma.41.2023.07.27.04.17.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 Jul 2023 04:17:44 -0700 (PDT) Message-ID: <4d6a1911-e2e2-a230-eb48-37bf0df9bbb0@redhat.com> Date: Thu, 27 Jul 2023 13:17:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v6 6/7] mm/memory_hotplug: Embed vmem_altmap details in memory block To: "Aneesh Kumar K.V" , linux-mm@kvack.org, akpm@linux-foundation.org, mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org, npiggin@gmail.com, christophe.leroy@csgroup.eu Cc: Oscar Salvador , Michal Hocko , Vishal Verma References: <20230727080232.667439-1-aneesh.kumar@linux.ibm.com> <20230727080232.667439-7-aneesh.kumar@linux.ibm.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230727080232.667439-7-aneesh.kumar@linux.ibm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 52C0680021 X-Stat-Signature: j9n8yk1rizw8tagnm9xuodzr14aek9z9 X-HE-Tag: 1690456684-740222 X-HE-Meta: U2FsdGVkX1+CF3jOOG7b7q62ARplC1JuQig1GpQhRKRRnVzHKmhj8Nu9hv7xsovD4cEfGN5LeLa1Mx67BQN+JVVpLGces3wxk1y3ABDmM94qcG+nS32glJi7L1HfdtawC9rHBpV4fQvMMYP+aym3G5wk1oEGV9NfS1QTJVdal0WmzyjRVpzV5aw2Bjn3wdDdANGG+3/Nt8yF4/J5Fp0rP9+i1LSTpCMt2fmv30qJEWVwVAzOCJdd6ErtaFN0NDpmm5YBW7alNsHO2pZSSJqT/v06+HOkmDPrQUTtxSZycBgdUsaZmnvx+3N+ZTf1G4nB2u1SmfxYvd+JcF/GAEkbddAU1A/oliguYdUtAlQLvZ+IztUXy9pXaZW8CQJ9gZ2BztmDQPxhA7bfaOKTRUxbURtkiffDaTOI7ppcpp3D+gj2NIYQj6J5Mj968l8lNoNWotNPsOGasz/LV9mwRkgfi82Cka8LNWAk/XQxh6UCYEWH7WofLlhKWZPkDIAZcO+x4gFm2gFQLGoCN4VE4pTalUPkQbinesytwdU9olg+cb+ubQsdMvym2HHVyN8qqCOGwjvNdgN+cOm7/0DzG/puEwqktYY8gtw14zAjiEO68+Qo5oW2hoYYIo8HLBiPyxr8371+O3vN5Yl4fyCmCZ9mcI/ioSx0VRbMbIvmf1Bl95EZtYloGWdXRLAmnnqYDca0cN4jFjPRtDoVYF6h4HM4TAfQ42deShnNh6E3s6dYrBDsPoewI7GRgGr/Bjc9Y9NpTF+Q88rU7ywbOUeaJ0SnRoxkJ7Cw73LQ5GGmah1rSmy53giYzXp7OLo4oajec7iF1GdUdfWx1aD9bdSbIt0RYOGXysG4XaHEZhcbYhpR1K6N9l0zAZiBmUOE9h+MS1b32gy4OgHA/NHe8ngFsGyyZAGBC2yjC/nRyrX7hoUwxudHtJDXEeRvUlorwZYty1kUi6ur+l0gUhaDFpW1xgC t0OMsXYf 1gxRDA+sGySvJ7G+k8pLbRNxSQP7lWGvONMu8jzMBnWtc+BHB/aomyp13N0dn2NwN2HqE23nBekmH8ZR6C6o7LvGdAPe6nOLy7GIRY9P5xnsKaEkVlYfm0PIY6uYyRZgAdJe0JWSRMUVppPGNmTUaGiJItMcvtTvtgjOu670VJ/GKOCObBcx65WbxQi9gkN2sUJ4eWI6yniQwKMrpPAU2+eKSyOZIdM8xGrQkbNfvhBMTujCkrfu7JIu3eak6PzF+oGhIya4MphKcg5zLlgeXmx996mK7eOzXR3BXLXCGeTo/ZHjbkR8IYNewTOEu3QCODqShao/ZeaZZQ4CMunDnY8YHnZutFQ78LI5/H5zZyx2cyVixOGYe0I3rnD8JWj64s6fYXJj0ceA39XQZgAMU8wUEGQGeoWsWsMWy/UXAqBhnP24Z8TsjDINmtcmS+Q4cM/gqi/qZyFS8VV6RgfR552FdogGc7hUNNdnjCdBoHsVEdxMqjPngBi9czA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > + /* > + * Now that we are tracking alloc and free correctly > + * we can add check to verify altmap free pages. > + */ Better remove the history lesson from the comment. "Verify that all vmemmap pages have actually been freed." > + if (altmap) { > + WARN(altmap->alloc, "Altmap not fully unmapped"); > + kfree(altmap); > + } > + > if (IS_ENABLED(CONFIG_ARCH_KEEP_MEMBLOCK)) { > memblock_phys_free(start, size); > memblock_remove(start, size); Acked-by: David Hildenbrand -- Cheers, David / dhildenb