From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1379C5AE59 for ; Wed, 28 May 2025 07:42:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7F2A56B008C; Wed, 28 May 2025 03:42:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7A36C6B0092; Wed, 28 May 2025 03:42:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 691906B0093; Wed, 28 May 2025 03:42:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 491C16B008C for ; Wed, 28 May 2025 03:42:28 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id E901C80547 for ; Wed, 28 May 2025 07:42:27 +0000 (UTC) X-FDA: 83491523934.18.D26BDD9 Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) by imf15.hostedemail.com (Postfix) with ESMTP id EEDD8A000C for ; Wed, 28 May 2025 07:42:25 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=UCSn+f9F; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf15.hostedemail.com: domain of asml.silence@gmail.com designates 209.85.208.47 as permitted sender) smtp.mailfrom=asml.silence@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748418146; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eLPcSIp/DD1rCYzGKNk0Bn8Y+IA3lzvlJ6bnzdrWQSU=; b=DdtknWUp/L0RapTASiWDwuOHZdLXOiOs86bUl8db9RqoXrxVkQyqROylJp7ev1NzBVtK/b bfSB9z1NbIb1FkNRITJk6hj3hPmQNvh7FAjQtWptO9kRRMpFQDW38eva8893xvypbjpfVY p+o28mYO5tp0+/dMgruZhEnOc1QMy4E= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748418146; a=rsa-sha256; cv=none; b=3WuyPCHBabP31iEpJ5mJBzs5pNPhbhmS2g+1V6LQRpxIeU1JomwIbs58LuFtxm1CaXoyTe MgVNScY+ozFIjau1x5qp1ikYWp3+dk61m/5OivyLFBTjAewD9/toF3G3UrmRLxUKK4SHlA Ng9Uhxrz8gQseS4RyAcnNNqqb4Kcl0s= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=UCSn+f9F; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf15.hostedemail.com: domain of asml.silence@gmail.com designates 209.85.208.47 as permitted sender) smtp.mailfrom=asml.silence@gmail.com Received: by mail-ed1-f47.google.com with SMTP id 4fb4d7f45d1cf-604bde84d0fso4007933a12.3 for ; Wed, 28 May 2025 00:42:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1748418144; x=1749022944; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=eLPcSIp/DD1rCYzGKNk0Bn8Y+IA3lzvlJ6bnzdrWQSU=; b=UCSn+f9F0xpNTkC3JAdRqKrJN2cX+ywiAs5o9jGMAx+5ue7nhdkq5AMvmd7ElwZfg1 5DdVjOZvnfm3K/4HxQI8FfUPWIIKNKXQLOCIPYtEkXZOF4YGfY+q1xy7viOYno5PKxqp VDsLap+RywwncyzmLRqP3FCHn2UBagc3yJpoTOB/9ADxVPUUcAJ3+FZc6jeRNdpHBdAz W4xJRRc+CVQikk5K3wTJfZdvVS2UgDVlCq8q7lTIjXoQkeKAElBRoGgWfnbiiWCVJ7KR GGZmwUSI975e5T1vilA9wV3+3vpVinlfk0TqcIdBUEWHIGHAUA/Z5egKBFtjhlleW6dg 7IpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748418144; x=1749022944; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=eLPcSIp/DD1rCYzGKNk0Bn8Y+IA3lzvlJ6bnzdrWQSU=; b=NJUJTW4pJJZDTvTyR6jRPOZiUkxDb8inLWvU6THi3Bh5dX/OJb8vw+nz02yYW49fjB d3vb5S8b6jvZRRE1DsMkwpMvxnz0WpMNQYaY8KbIC0+VtlGFPaJUd7XRrfVY7SzO2NRZ +e2SfcekfqNYegg/sS+nZfj0R86ODhc9TEImQAlILsXZdNsqmc0ZAq1ibvkIIw1MtFpZ mBMrSIR1XC9SLwvbMXXejcT+J1dDzZbVW6xYoPokJljj8yWJx8MbQs0RvCJOQNRoq5CI MICUe1A9wa2JKWtEcTCNF81SxpX7R1asd4d3FtQcKBrDO5c4ki53OFkT1163kfBpVkhR fE6Q== X-Forwarded-Encrypted: i=1; AJvYcCWnviPLGOPRwHasixTUaxa5i2OYudUTpEwo4Onl4X7BZJUiW7utdrolI8cht1ptcSxU4Qv7lUZD2g==@kvack.org X-Gm-Message-State: AOJu0YzhWtha3LZd4APEYzqTLruCRS7YmGasmbduRCsHHqQBzDHjwV1c UTAVSgUv/0gd0Asxy9fEQKW1QFarP0wuR0H1v6slKV3nEDTI3zjgIumO X-Gm-Gg: ASbGnctTvsEfmnPkIO348H1LdF2vjpfh9i2OQU/EnCrhE85/6C4lOKw6n6yUPHTf578 3mT2JVezW/YC+phw98YJ3pV347i9O/4/qTG64k8ElwpV7Cmd/V6UmUvfRsWQrM1uais7TeBDWgh iXS6pvnY9/9EyzwPL9aqtDbDk7fsrHCS70TyCVylhhIHpNpDVVb9P7R/jrg2TWjBARM+7Zd0fcB 4PJ1EhRzsGSC8tJVEbciYiolsgylCKmYuubEIkK6rid4+eMofowrHknovLpwORSxCG+u7tSUY9q RENfzAzyPVW0Iy2gkL2Oq2PTa9x7vE/3MYttS95HhRXSgYOfeV8uYWWABwiTM1+DzkwE8AitCw= = X-Google-Smtp-Source: AGHT+IH8GIKLi3J19CB1X7s1vCnZGjRCWQBW0YxLPfQlCr0ZehSV3jt8AiU4iunzA8JJZOzdVmuDew== X-Received: by 2002:a17:907:d643:b0:ad5:3055:a025 with SMTP id a640c23a62f3a-ad85b0518aemr1514904966b.6.1748418144007; Wed, 28 May 2025 00:42:24 -0700 (PDT) Received: from ?IPV6:2620:10d:c096:325::6f? ([2620:10d:c092:600::1:c447]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6051d5d991esm392479a12.3.2025.05.28.00.42.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 May 2025 00:42:23 -0700 (PDT) Message-ID: <4d7a307f-d595-4020-8060-f3bc2f8f72ca@gmail.com> Date: Wed, 28 May 2025 08:43:34 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 01/18] netmem: introduce struct netmem_desc struct_group_tagged()'ed on struct net_iov To: Byungchul Park , Mina Almasry Cc: willy@infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel_team@skhynix.com, kuba@kernel.org, ilias.apalodimas@linaro.org, harry.yoo@oracle.com, hawk@kernel.org, akpm@linux-foundation.org, davem@davemloft.net, john.fastabend@gmail.com, andrew+netdev@lunn.ch, toke@redhat.com, tariqt@nvidia.com, edumazet@google.com, pabeni@redhat.com, saeedm@nvidia.com, leon@kernel.org, ast@kernel.org, daniel@iogearbox.net, david@redhat.com, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, vbabka@suse.cz, rppt@kernel.org, surenb@google.com, mhocko@suse.com, horms@kernel.org, linux-rdma@vger.kernel.org, bpf@vger.kernel.org, vishal.moola@gmail.com References: <20250523032609.16334-1-byungchul@sk.com> <20250523032609.16334-2-byungchul@sk.com> <20250527025047.GA71538@system.software.com> <20250528012152.GA2986@system.software.com> <20250528050346.GA59539@system.software.com> Content-Language: en-US From: Pavel Begunkov In-Reply-To: <20250528050346.GA59539@system.software.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: EEDD8A000C X-Stat-Signature: yh5xcca4tgbkpsw5k3gfjacced1jzhsr X-Rspam-User: X-HE-Tag: 1748418145-610069 X-HE-Meta: U2FsdGVkX199V6T6INhpJA88E1HPBA6708hmXyMEbdDT2exOfgN1yUEJTWTHh77OhuKgQV6EuNgKLZbB4t4QqeHRdmAvu37WrzFmrvFOb0OmVfhLEH1RqXvp8VzmAQAXC4dRnhI/Br1pPa1g1GQ/fyVG1xCYToO/1UWfiEYdaeU7nT3nbwlXw1ZmKZviAbcQAa/Z8Oharn/c63fl872V+uEhdzMk/Tl1Wlt6E8dyaBYdiOoMVjTJMaBIz48mSvG4f9qqYVE1x5SkedpIzTNUrBebaMGkVOUaRyz6FAW+u1VHEx2MOOyvoyWq4kiDtdSsCqk/JfajDpjQjXYh7uZViHR/gKaAshUrrKmD5YtZk+MTxaJUZ7Le4leiHS3ryT1z40LImDTEus+3bR0grWzQKLr8MT3t9QrrAetdpiOlQxJRtA+ICsyyVUD+chTUoolHyl3qePcJslP8c+HzZbZIrGbqePivUkNrtZIIDAX7SPl7k+UZNfj7lg+GZyPNZaVcA80AWXpGg+GvT4PJ9koSt3qPi/9Gmty02yABKL8whY4T3oC0U1TwuKXltgLkMo2KXZtaLFavl4khjcb8QuV1p5Q88YJPTMukwjBnAOpKlMPzhc4moGDjru859QeCMV0dXfCPR3E2PJ0uCkahECPCrzHW5/6t1c2pyBZDu9TzuQ6jngauuEbSaD9iPCDxh663DCpLO26YMrOzEA4EmAa6woGgSXMCPZVgLXoJROMJKgg7u6/7L7kiJmvOaF+cNrpmbf/TONdb+9Ed1fFWZ7i9XG8FOZ9xIOIRHF828Q7zj8HQdAwqnxCw6ZLVG9b2QfRXNr3wcoWULp5oAbD2KeLsrx8KxG6bHrG7DXCuC6Pf4Vgpk9ZXiMvbMyVIzW5If4xeLnwk9wTBenGma8yF11Qvc2kcANtC1QQXlelkBScPVbeHZleQoZ5mBNVq417kdWzpxMGlgqBsXYaBY4gPn2i ybXAphcY jhP/iSUQinZXYOcrpt7CdhuADvC3J8Bvn5OJVKhtiJ9iFyWcs6Fymf53azChgmdDpZ80DdqsM7jOPxzHMH9ZrQUj5IY+gNZtGWe9aPBJgX3RWQD3ZTthjDhmGyt1D4jt51eezVcKhEy3H3M/N2agKtQsF/L4AvMYDLzzdBcUW9HoftcSQkjadzDPOASD+wzP4O3UoZR6eitz1osodISO5Te/ftv27JMWxCL9BKZxj2ahcQ03eYIIcmBbUJVNjRAeDMc4t3oHiyl6n1d9VHi8kI/GM5Je16c4br4iVH/belw4rKOJiAei0/4jg28oAb7X25iYmuwpTQPXcEAjKbKn8evsPau2mwrYLMnzJTRjhfyrVqFL3DQLO1N1OXbXiy5KEAjrIxucOx35zBFUlGeXq41f0WjJeAElsgD1OstRR6mQg8DiKk/U0kVw3JlNdvI5nhckbMiTpdCmmn4AD92zwkw1bXKOCe0HV5RSpuyMpzInUBWE+wTq4ef0vft8aStvzcJZXKuBb/HwqyQrQll8vEjiMBaQT6dUDYE0eTXZjidanvRy/8by70zzr1e0lHubDaplF X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 5/28/25 06:03, Byungchul Park wrote: ...>> Thus abstractly different things maybe should not share the same >> in-kernel struct. >> >> One thing that maybe could work is if struct net_iov has a field in it >> which tells us whether it's actually a struct page that can be passed >> to mm apis, or not a struct page which cannot be passed to mm apis. >> >>> Or I should introduce another struct >> >> maybe introducing another struct is the answer. I'm not sure. The net > > The final form should be like: > > struct netmem_desc { > struct page_pool *pp; > unsigned long dma_addr; > atomic_long_t ref_count; > }; > > struct net_iov { > struct netmem_desc; > enum net_iov_type type; > struct net_iov_area *owner; > ... > }; > > However, now that overlaying on struct page is required, struct > netmem_desc should be almost same as struct net_iov. So I'm not sure if > we should introduce struct netmem_desc as a new struct along with struct > net_iov. Yes, you should. Mina already explained that net_iov is not the same thing as the net specific sub-struct of the page. They have common fields, but there are also net_iov (memory provider) specific fields as well. -- Pavel Begunkov