From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72679C64EC4 for ; Tue, 7 Feb 2023 00:00:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8BB5D6B0071; Mon, 6 Feb 2023 19:00:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 86A6C6B0073; Mon, 6 Feb 2023 19:00:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 732E96B007D; Mon, 6 Feb 2023 19:00:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 654486B0071 for ; Mon, 6 Feb 2023 19:00:50 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 309591C625A for ; Tue, 7 Feb 2023 00:00:50 +0000 (UTC) X-FDA: 80438539860.30.CEABA12 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by imf19.hostedemail.com (Postfix) with ESMTP id E3FF21A001D for ; Tue, 7 Feb 2023 00:00:47 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="dIVlS/MO"; spf=pass (imf19.hostedemail.com: domain of dave.jiang@intel.com designates 192.55.52.120 as permitted sender) smtp.mailfrom=dave.jiang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675728048; a=rsa-sha256; cv=none; b=OSNTxgL0uoH7WOH2gCAB3bhGaqebKSAyXpy2heEl4u/PFYS3Lok3hDxSfiM8Q4q65peiy7 CArh8/OJuv1gKLP7pVtJRWAy4AvsJr/XCCZLPT+/86Ut5TtKwUVQ8ULm+OoP4/emv2NIvY 9kkGdlI/mT535V30aFN8B4E4At2sxG4= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="dIVlS/MO"; spf=pass (imf19.hostedemail.com: domain of dave.jiang@intel.com designates 192.55.52.120 as permitted sender) smtp.mailfrom=dave.jiang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675728048; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=z9vmsc1WENwh8BIeVTTJkbU7Uyl7vvrSfwfMGbR44Rg=; b=pHLEfVnJ6egchsX2UMtgH7bFMPtz2OEcts2pW5wFPEdS8d8Mj1pNLGZwB6HZh0TCK/sVYz t7GgrEf4KoEbbxUhE9MizIhjzo7O56pUTcyJyC6aoMVWbUI8dwtIO0ZJLMpnSMcGjzdNIP XJReBgFaItzz6P8dVv3Nb9ej/gLAyds= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675728048; x=1707264048; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=kkLcdkLbgrI5YKBaLZkFwa+BwQtczIIiGVCz48/U8EA=; b=dIVlS/MOCBhy3CbSEof7/+bjWEgiC+OARAVaMiiOn4IBt2ZK3Ca3wDlk xOKNAUmg6pNk0Z32V1lH0+F5KUbSCKDBtOA+iiNJzzeaKXNbiahqElBzF muELRhUbGZRU2DoqVzJAnxaL/BrM1P6wnaEnbHHrGwKjtiCqjLLMyQilH /mCStdrZ606ow4SFNmnloQ5kyIWbfM+k0Ry7UB0OBK2vtHq1O0vhH1dmC 240qYDUEobPgOkasjseYiAfkUD1/6B8fedL5Mnyn8YBkIq2xJhe7rC2Db V0+248aUd6i8zekVejV66xuzf8ASUvP6uvkDZU2MLSyUYX2LXpt7J/CPZ A==; X-IronPort-AV: E=McAfee;i="6500,9779,10613"; a="327986269" X-IronPort-AV: E=Sophos;i="5.97,276,1669104000"; d="scan'208";a="327986269" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Feb 2023 16:00:16 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10613"; a="660004882" X-IronPort-AV: E=Sophos;i="5.97,276,1669104000"; d="scan'208";a="660004882" Received: from djiang5-mobl3.amr.corp.intel.com (HELO [10.212.111.195]) ([10.212.111.195]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Feb 2023 16:00:14 -0800 Message-ID: <4db0288f-09a7-5b60-899c-c6f555e1c55e@intel.com> Date: Mon, 6 Feb 2023 17:00:14 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.6.0 Subject: Re: [PATCH 10/18] cxl/region: Fix passthrough-decoder detection Content-Language: en-US To: Dan Williams , linux-cxl@vger.kernel.org Cc: stable@vger.kernel.org, dave.hansen@linux.intel.com, linux-mm@kvack.org, linux-acpi@vger.kernel.org References: <167564534874.847146.5222419648551436750.stgit@dwillia2-xfh.jf.intel.com> <167564540422.847146.13816934143225777888.stgit@dwillia2-xfh.jf.intel.com> From: Dave Jiang In-Reply-To: <167564540422.847146.13816934143225777888.stgit@dwillia2-xfh.jf.intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: E3FF21A001D X-Rspamd-Server: rspam01 X-Stat-Signature: cui5oofj6qh69mc61nsmac6o6nzkwy1z X-HE-Tag: 1675728047-357878 X-HE-Meta: U2FsdGVkX192Jx0SEKsRBLP7B4S/E2pqTy/GP38ekBh5/mww7xIkZ82HduqNI5+TD/CFRHnmRTxphuclUps7Gv4jGgXRSMxMc+RmfB5KHBUgZaPSFdF9HjdLo5YjrIFUUk2+M1IRp+HnbrbSfxDiVIpza4D9QWLHRSmdnd1Z7lvBumeXRqvXj8yyLYeCCdei0dJ7lS3xK0+4uSgTsBRQ7KLJw3rliFuDfFS7I6EGyewHMR4dMsNSNANHoAYnxoVx1d/mPK7fzj2u2Xi4701rcurzDAqprEN3D7TQcXlV1/Oon603yrtIgvrL98tVCC9MPBiWMfqA0ZsD2CuUswkKkDQP2QtysaVBfxjQHSpI676+JNeMfYPHRvdI4/N0O/4KYBZ3Cgx5GX/h+CVdro6tQQaDHXvsJftFC+sltZMqkhoQG0apuOBQNLJ+zjCetuOTgOl4fxHfsLsIImeuXKQ3is6x9to+QRAcZvqR4n60K9FxiPdE/P3bwwGuYSqxWI6Dj7805o6EI12Ad4HmqXKpABdLpOhWU84CDugIx2zovJrcRXwH3mrQ4kiHubTl4Aqg6G/C3+XYYOyXEZauAmYRmm8AfCJIOLrU8xFomEJGqzlBX8HEBwvFzQy9ZR/dI5puttE78MAPuZFu0/+hwGYpqsK4XmWLNT3ZCYiiI6oX/5oXwzr98yMXP7p5gX73sL/emDOwLli3PWVNChyvOGUc0XltISDAcxk4Fu62XbAmaHKOkrqDPNbULAAJ6I6yrMuMGMyUyRvo35VVI0A+6pmEGvQ7rHwWZOVVJh/b/pywteBV+HAz2r+NrmBtBCr4tob6LUw3Qh5Uwojnz9ZZ/2zB7+A2wqR+rzWlRaG+aetaGNwuhpYDKSp9IAUK2s/GYSN9t82/OaeelbXq8Ki1uFKBDKKSrSQpi0GZOhvZAEReT0bjIZUad7pcvZsjtrj2lLc8kM1dDP9w4Q/AJJ8D4Us J3rlKw0N QGqfS9qKj0WhEO3+8hXFpQ2sIPdrwvn7WO/wFuWLqNkUd1RgEavVePnabbFPW9Dc3977oLxQmRoPBG2UatHAVJYNr4qwV13U8wUehY6weaU2TeVNVYERBQaTzTVZv7048uQ2Bz8Qr70s7oZ0yGwSfuRRfA341kvgroUQyZbms1b3F9UPkaZdhKcLLZaC7G/7/YWJF7/nhr2hCKPkskecOceROWIb2Xu6+HZ4wH44W6V+t4bQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2/5/23 6:03 PM, Dan Williams wrote: > A passthrough decoder is a decoder that maps only 1 target. It is a > special case because it does not impose any constraints on the > interleave-math as compared to a decoder with multiple targets. Extend > the passthrough case to multi-target-capable decoders that only have one > target selected. I.e. the current code was only considering passthrough > *ports* which are only a subset of the potential passthrough decoder > scenarios. > > Fixes: e4f6dfa9ef75 ("cxl/region: Fix 'distance' calculation with passthrough ports") > Cc: > Signed-off-by: Dan Williams Reviewed-by: Dave Jiang > --- > drivers/cxl/core/region.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/cxl/core/region.c b/drivers/cxl/core/region.c > index c82d3b6f3d1f..34cf95217901 100644 > --- a/drivers/cxl/core/region.c > +++ b/drivers/cxl/core/region.c > @@ -1019,10 +1019,10 @@ static int cxl_port_setup_targets(struct cxl_port *port, > int i, distance; > > /* > - * Passthrough ports impose no distance requirements between > + * Passthrough decoders impose no distance requirements between > * peers > */ > - if (port->nr_dports == 1) > + if (cxl_rr->nr_targets == 1) > distance = 0; > else > distance = p->nr_targets / cxl_rr->nr_targets; >