From: Laura Abbott <labbott@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Dave Anderson <anderson@redhat.com>,
Kees Cook <keescook@chromium.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-arm-kernel@lists.infradead.org,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Ingo Molnar <mingo@kernel.org>, Andi Kleen <andi@firstfloor.org>
Subject: Re: [PATCH] proc/kcore: Don't bounds check against address 0
Date: Tue, 1 May 2018 15:26:00 -0700 [thread overview]
Message-ID: <4db64722-47b5-767c-4090-bdd9c1522e96@redhat.com> (raw)
In-Reply-To: <20180501144604.1cf872e7938bffc01a26349f@linux-foundation.org>
On 05/01/2018 02:46 PM, Andrew Morton wrote:
> On Tue, 1 May 2018 13:11:43 -0700 Laura Abbott <labbott@redhat.com> wrote:
>
>> The existing kcore code checks for bad addresses against
>> __va(0) with the assumption that this is the lowest address
>> on the system. This may not hold true on some systems (e.g.
>> arm64) and produce overflows and crashes. Switch to using
>> other functions to validate the address range.
>>
>> Tested-by: Dave Anderson <anderson@redhat.com>
>> Signed-off-by: Laura Abbott <labbott@redhat.com>
>> ---
>> I took your previous comments as a tested by, please let me know if that
>> was wrong. This should probably just go through -mm. I don't think this
>> is necessary for stable but I can request it later if necessary.
>
> I'm surprised. "overflows and crashes" sounds rather serious??
>
It's currently only seen on arm64 and it's not clear if anyone
wants to use that particular combination on a stable release.
I think a better phrase is "this is not urgent for stable".
Thanks,
Laura
prev parent reply other threads:[~2018-05-01 22:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1039518799.26129578.1525185916272.JavaMail.zimbra@redhat.com>
2018-05-01 20:11 ` [PATCH] proc/kcore: Don't bounds check against address 0 Laura Abbott
2018-05-01 21:46 ` Andrew Morton
2018-05-01 22:26 ` Laura Abbott [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4db64722-47b5-767c-4090-bdd9c1522e96@redhat.com \
--to=labbott@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=anderson@redhat.com \
--cc=andi@firstfloor.org \
--cc=ard.biesheuvel@linaro.org \
--cc=keescook@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).