From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1960BC433DF for ; Fri, 9 Oct 2020 06:39:19 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3A4DB22251 for ; Fri, 9 Oct 2020 06:39:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3A4DB22251 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9C2566B005C; Fri, 9 Oct 2020 02:39:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9721D6B005D; Fri, 9 Oct 2020 02:39:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 839F76B0062; Fri, 9 Oct 2020 02:39:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0097.hostedemail.com [216.40.44.97]) by kanga.kvack.org (Postfix) with ESMTP id 56E986B005C for ; Fri, 9 Oct 2020 02:39:16 -0400 (EDT) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id E1B4A180AD804 for ; Fri, 9 Oct 2020 06:39:15 +0000 (UTC) X-FDA: 77351435070.21.clock45_03112d1271de Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin21.hostedemail.com (Postfix) with ESMTP id C3592180442C0 for ; Fri, 9 Oct 2020 06:39:15 +0000 (UTC) X-HE-Tag: clock45_03112d1271de X-Filterd-Recvd-Size: 2669 Received: from huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf03.hostedemail.com (Postfix) with ESMTP for ; Fri, 9 Oct 2020 06:39:14 +0000 (UTC) Received: from dggeme703-chm.china.huawei.com (unknown [172.30.72.55]) by Forcepoint Email with ESMTP id AD46ABF5970B7BBD8726; Fri, 9 Oct 2020 14:39:04 +0800 (CST) Received: from dggeme753-chm.china.huawei.com (10.3.19.99) by dggeme703-chm.china.huawei.com (10.1.199.99) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1913.5; Fri, 9 Oct 2020 14:39:04 +0800 Received: from dggeme753-chm.china.huawei.com ([10.7.64.70]) by dggeme753-chm.china.huawei.com ([10.7.64.70]) with mapi id 15.01.1913.007; Fri, 9 Oct 2020 14:39:04 +0800 From: linmiaohe To: Andrew Morton CC: "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] mm: mmap: Fix general protection fault in unlink_file_vma() Thread-Topic: [PATCH] mm: mmap: Fix general protection fault in unlink_file_vma() Thread-Index: AdaeAjdrBFGByg+WTS2nogBIdhwMBg== Date: Fri, 9 Oct 2020 06:39:04 +0000 Message-ID: <4dcf86d0a9ac474c8dcb903aa6341b9f@huawei.com> Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.174.177.16] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-CFilter-Loop: Reflected X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Andrew Morton wrote: > On Thu, 8 Oct 2020 07:17:18 +0000 linmiaohe wrote: > >> Andrew Morton wrote: >> > On Wed, 16 Sep 2020 05:07:33 -0400 Miaohe Lin w= rote: >> > >> >> The syzbot reported the below general protection fault: >> >> > >> >is this using the correct file? I think it is, but please do check. >> > >>=20 >> Many thanks for your reply. >>=20 >> Yes, I think so too. We do deny_write_access and mapping_map_writable on= @file, so we should undo all of this on @file. >> Since @file is unchanged over the second vma_merge() time, we'are using = the correct @file to undo our temporary denial count. >>=20 >> But how should I check this explicitly ? I can't find out a way to do th= is. Could you please figure it out for me? > >I meant "please check (review) the code as it now is", not "please add a c= heck" ;) > Oh, I see. I have reviewed the code carefully. The @file should be right on= e as I explained in previous email. ;) Have a good day! ^_^