From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by ro-out-1112.google.com with SMTP id p7so419064roc.0 for ; Thu, 17 Jan 2008 08:33:16 -0800 (PST) Message-ID: <4df4ef0c0801170833p4b416b50h495c2b34a17ef77f@mail.gmail.com> Date: Thu, 17 Jan 2008 19:33:15 +0300 From: "Anton Salikhmetov" Subject: Re: [PATCH -v5 2/2] Updating ctime and mtime at syncing In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <12005314662518-git-send-email-salikhmetov@gmail.com> <4df4ef0c0801170416s5581ae28h90d91578baa77738@mail.gmail.com> <4df4ef0c0801170516k3f82dc69ieee836b5633378a@mail.gmail.com> <4df4ef0c0801170540p36d3c566w973251527fc3bca1@mail.gmail.com> <4df4ef0c0801170820i6af58e8u15e3c3b8e944c0c6@mail.gmail.com> Sender: owner-linux-mm@kvack.org Return-Path: To: Miklos Szeredi Cc: linux-mm@kvack.org, jakob@unthought.net, linux-kernel@vger.kernel.org, valdis.kletnieks@vt.edu, riel@redhat.com, ksm@42.dk, staubach@redhat.com, jesper.juhl@gmail.com, torvalds@linux-foundation.org, a.p.zijlstra@chello.nl, akpm@linux-foundation.org, protasnb@gmail.com, r.e.wolff@bitwizard.nl, hidave.darkstar@gmail.com, hch@infradead.org List-ID: 2008/1/17, Miklos Szeredi : > > The do_wp_page() function is called in mm/memory.c after locking PTE. > > And the file_update_time() routine calls the filesystem operation that can > > sleep. It's not accepted, I guess. > > do_wp_page() is called with the pte lock but drops it, so that's fine. OK, I agree. I'll take into account your suggestion to move updating time stamps from the __set_page_dirty() and __set_page_dirty_nobuffers() routines to do_wp_page(). Thank you! > > Miklos > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org