From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C42D9C4167D for ; Mon, 30 Oct 2023 16:34:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 48E6D6B024B; Mon, 30 Oct 2023 12:34:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 417B46B024C; Mon, 30 Oct 2023 12:34:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 26A3E6B024D; Mon, 30 Oct 2023 12:34:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 181136B024B for ; Mon, 30 Oct 2023 12:34:32 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id EB70E1603BC for ; Mon, 30 Oct 2023 16:34:31 +0000 (UTC) X-FDA: 81402675942.06.C907AD4 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf07.hostedemail.com (Postfix) with ESMTP id A945340021 for ; Mon, 30 Oct 2023 16:34:29 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gD1FC8yq; spf=pass (imf07.hostedemail.com: domain of pbonzini@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=pbonzini@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698683669; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ulhjanvCdPYtWw9EzE0x+t1LRIaefb0ftsJSrZGZk2I=; b=tH0DfAETMHnscnD2fFOgD3WZFxchpGDmPNv1oU8eQzE9timhzElT3DsrMmPfUr2dDVnfFI HGTtwyPGPdQUfCPaJ5SAxHTeFHjXaxk5taodCVCao/NHnKmCGuJKS/DXfBRQEhD1SbJm2G 7r3RcjEbM9APCg6RrI1fGmufXoRBlIo= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gD1FC8yq; spf=pass (imf07.hostedemail.com: domain of pbonzini@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=pbonzini@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698683669; a=rsa-sha256; cv=none; b=mGaewm8yJnsJnGFsVz/Ri+NmV7pti2UlKE2O5ANnAhpCgt6eBYPKJxhokNsz/GAlvE0kaS 8wimkeNg8f2kLawSWS0adQnOief9ru5RI2HLvV/LZQGdSBGB5PHsskQfKXHQH63HkDvnE8 TNIQ0LdEDZ2HOzuayhWb0dbZ9rSoFK8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1698683669; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ulhjanvCdPYtWw9EzE0x+t1LRIaefb0ftsJSrZGZk2I=; b=gD1FC8yq1RXGhMg9PI0MaLk3wUea71Oev+APxcyh3MycdcEkFazjR8+7vMhqfS+VlzOjdB dn7qdKy5xm6b61DPiHP+p/uUerjSndRNgsKGeqK2FfTG3R74Aw1dPki7bXmIrBXwuYL4s/ az5uy2iJVH2WtDtz7FrxT8enSxZXR48= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-677-t1Kj-9NPOWC095lWcGAuzQ-1; Mon, 30 Oct 2023 12:34:27 -0400 X-MC-Unique: t1Kj-9NPOWC095lWcGAuzQ-1 Received: by mail-lf1-f69.google.com with SMTP id 2adb3069b0e04-5079fe7cc7cso5621631e87.2 for ; Mon, 30 Oct 2023 09:34:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698683666; x=1699288466; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ulhjanvCdPYtWw9EzE0x+t1LRIaefb0ftsJSrZGZk2I=; b=XBKR0SMJM795F+Rrbhn0jcRiMhKv5aI1zopIwpBlUOo2DqmwqjV4b2hOxPEpCOMI4C H/qqP7tSYK8XMH08LlnG7I55L3lqIW8dw6QdD7bbqeffXGZZ3WagHc6rh9JQ5nwh02lf Lpx30HFtmMi0Z1NbpA7m/bFHJM06EHbUGorGkG7vhOxjFEviDCDCUbFw9Ma1DtAG+xNv 6h59DIVT+cOtCHDmtlmhlBJriLHX99xqBmKqeOGujnPaxpD4idmtdyBiOgBZkyUBBcOg QXoaj4m+YsQsovpNrrF0VaITI6KHycB7cggdk948yhzvA14Ah5SqHkPkaq7xBHU++1Bm qeMw== X-Gm-Message-State: AOJu0YyTozFMr81BgjBXBuu7yJs41zKRKy9duS7xMuvIqp+cWnvV49fB umnExpL6kIBlYUWd++jb+voFwNcz/LNcx+o7k1I63oHzZMbQ5UEmsiunjZH3C2p52spayW7iwxO gL68K+NOZEqM= X-Received: by 2002:a05:6512:401b:b0:509:e5e:232a with SMTP id br27-20020a056512401b00b005090e5e232amr5897960lfb.42.1698683666080; Mon, 30 Oct 2023 09:34:26 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE0aPhq7RmLOdQg/8nTPuKQcnNKQWBpA0tLrO9vQ6yVW69xTZheoxNXQCLJzHXUuVLJUPNNOQ== X-Received: by 2002:a05:6512:401b:b0:509:e5e:232a with SMTP id br27-20020a056512401b00b005090e5e232amr5897924lfb.42.1698683665637; Mon, 30 Oct 2023 09:34:25 -0700 (PDT) Received: from [192.168.1.174] ([151.81.68.207]) by smtp.googlemail.com with ESMTPSA id c8-20020a5d4cc8000000b003197869bcd7sm8612041wrt.13.2023.10.30.09.34.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Oct 2023 09:34:25 -0700 (PDT) Message-ID: <4e2eee77-721f-4b0f-a825-a664951640f0@redhat.com> Date: Mon, 30 Oct 2023 17:34:17 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v13 05/35] KVM: PPC: Drop dead code related to KVM_ARCH_WANT_MMU_NOTIFIER To: Sean Christopherson , Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexander Viro , Christian Brauner , "Matthew Wilcox (Oracle)" , Andrew Morton Cc: kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Xiaoyao Li , Xu Yilun , Chao Peng , Fuad Tabba , Jarkko Sakkinen , Anish Moorthy , David Matlack , Yu Zhang , Isaku Yamahata , =?UTF-8?B?TWlja2HDq2wgU2FsYcO8?= =?UTF-8?Q?n?= , Vlastimil Babka , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , David Hildenbrand , Quentin Perret , Michael Roth , Wang , Liam Merwick , Isaku Yamahata , "Kirill A . Shutemov" References: <20231027182217.3615211-1-seanjc@google.com> <20231027182217.3615211-6-seanjc@google.com> From: Paolo Bonzini Autocrypt: addr=pbonzini@redhat.com; keydata= xsEhBFRCcBIBDqDGsz4K0zZun3jh+U6Z9wNGLKQ0kSFyjN38gMqU1SfP+TUNQepFHb/Gc0E2 CxXPkIBTvYY+ZPkoTh5xF9oS1jqI8iRLzouzF8yXs3QjQIZ2SfuCxSVwlV65jotcjD2FTN04 hVopm9llFijNZpVIOGUTqzM4U55sdsCcZUluWM6x4HSOdw5F5Utxfp1wOjD/v92Lrax0hjiX DResHSt48q+8FrZzY+AUbkUS+Jm34qjswdrgsC5uxeVcLkBgWLmov2kMaMROT0YmFY6A3m1S P/kXmHDXxhe23gKb3dgwxUTpENDBGcfEzrzilWueOeUWiOcWuFOed/C3SyijBx3Av/lbCsHU Vx6pMycNTdzU1BuAroB+Y3mNEuW56Yd44jlInzG2UOwt9XjjdKkJZ1g0P9dwptwLEgTEd3Fo UdhAQyRXGYO8oROiuh+RZ1lXp6AQ4ZjoyH8WLfTLf5g1EKCTc4C1sy1vQSdzIRu3rBIjAvnC tGZADei1IExLqB3uzXKzZ1BZ+Z8hnt2og9hb7H0y8diYfEk2w3R7wEr+Ehk5NQsT2MPI2QBd wEv1/Aj1DgUHZAHzG1QN9S8wNWQ6K9DqHZTBnI1hUlkp22zCSHK/6FwUCuYp1zcAEQEAAc0j UGFvbG8gQm9uemluaSA8cGJvbnppbmlAcmVkaGF0LmNvbT7CwU0EEwECACMFAlRCcBICGwMH CwkIBwMCAQYVCAIJCgsEFgIDAQIeAQIXgAAKCRB+FRAMzTZpsbceDp9IIN6BIA0Ol7MoB15E 11kRz/ewzryFY54tQlMnd4xxfH8MTQ/mm9I482YoSwPMdcWFAKnUX6Yo30tbLiNB8hzaHeRj jx12K+ptqYbg+cevgOtbLAlL9kNgLLcsGqC2829jBCUTVeMSZDrzS97ole/YEez2qFpPnTV0 VrRWClWVfYh+JfzpXmgyhbkuwUxNFk421s4Ajp3d8nPPFUGgBG5HOxzkAm7xb1cjAuJ+oi/K CHfkuN+fLZl/u3E/fw7vvOESApLU5o0icVXeakfSz0LsygEnekDbxPnE5af/9FEkXJD5EoYG SEahaEtgNrR4qsyxyAGYgZlS70vkSSYJ+iT2rrwEiDlo31MzRo6Ba2FfHBSJ7lcYdPT7bbk9 AO3hlNMhNdUhoQv7M5HsnqZ6unvSHOKmReNaS9egAGdRN0/GPDWr9wroyJ65ZNQsHl9nXBqE AukZNr5oJO5vxrYiAuuTSd6UI/xFkjtkzltG3mw5ao2bBpk/V/YuePrJsnPFHG7NhizrxttB nTuOSCMo45pfHQ+XYd5K1+Cv/NzZFNWscm5htJ0HznY+oOsZvHTyGz3v91pn51dkRYN0otqr bQ4tlFFuVjArBZcapSIe6NV8C4cEiSTOwE0EVEJx7gEIAMeHcVzuv2bp9HlWDp6+RkZe+vtl KwAHplb/WH59j2wyG8V6i33+6MlSSJMOFnYUCCL77bucx9uImI5nX24PIlqT+zasVEEVGSRF m8dgkcJDB7Tps0IkNrUi4yof3B3shR+vMY3i3Ip0e41zKx0CvlAhMOo6otaHmcxr35sWq1Jk tLkbn3wG+fPQCVudJJECvVQ//UAthSSEklA50QtD2sBkmQ14ZryEyTHQ+E42K3j2IUmOLriF dNr9NvE1QGmGyIcbw2NIVEBOK/GWxkS5+dmxM2iD4Jdaf2nSn3jlHjEXoPwpMs0KZsgdU0pP JQzMUMwmB1wM8JxovFlPYrhNT9MAEQEAAcLBMwQYAQIACQUCVEJx7gIbDAAKCRB+FRAMzTZp sadRDqCctLmYICZu4GSnie4lKXl+HqlLanpVMOoFNnWs9oRP47MbE2wv8OaYh5pNR9VVgyhD OG0AU7oidG36OeUlrFDTfnPYYSF/mPCxHttosyt8O5kabxnIPv2URuAxDByz+iVbL+RjKaGM GDph56ZTswlx75nZVtIukqzLAQ5fa8OALSGum0cFi4ptZUOhDNz1onz61klD6z3MODi0sBZN Aj6guB2L/+2ZwElZEeRBERRd/uommlYuToAXfNRdUwrwl9gRMiA0WSyTb190zneRRDfpSK5d usXnM/O+kr3Dm+Ui+UioPf6wgbn3T0o6I5BhVhs4h4hWmIW7iNhPjX1iybXfmb1gAFfjtHfL xRUr64svXpyfJMScIQtBAm0ihWPltXkyITA92ngCmPdHa6M1hMh4RDX+Jf1fiWubzp1voAg0 JBrdmNZSQDz0iKmSrx8xkoXYfA3bgtFN8WJH2xgFL28XnqY4M6dLhJwV3z08tPSRqYFm4NMP dRsn0/7oymhneL8RthIvjDDQ5ktUjMe8LtHr70OZE/TT88qvEdhiIVUogHdo4qBrk41+gGQh b906Dudw5YhTJFU3nC6bbF2nrLlB4C/XSiH76ZvqzV0Z/cAMBo5NF/w= In-Reply-To: <20231027182217.3615211-6-seanjc@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: A945340021 X-Rspam-User: X-Stat-Signature: jxoms8mzdqrwbktw3wfbcfjogtzdjfyz X-Rspamd-Server: rspam01 X-HE-Tag: 1698683669-26032 X-HE-Meta: U2FsdGVkX1+u1t9R4ouRl5DSc1htcCbJduwvrnyNY91UN2f3J8df4cy3Dlpup2oQ5fdmQRzLC6b4XdseD0OTxjvSSvFafSgIhfs8NbLzgKnCqwDadHp3Hm8anU5J7Ahc7cotoabe6U91V3P/7EGs6OB29lGiDtndsHE/aC9VijvlJsLABULMfKd3U7NUstwRWEDsM92WPvvK+SAnvvHKcG2gf5xN2Y0/odg5yzguEZ61c2oHy07w9bQxkfP4pNRAzVMMypO3f/qqZRc7uNp78I32t/Fs1j3amoYgk8aiowISeD6bTmEaNnUVSM4FwMAW66xFEmirhyDvkUMsX+uXJe99T2SxnPIusbAPSTizvjXpFmeRY306N9dGs8FiPFf0ODAT5fisQpUKWKfYWwLU7vq5rwIRmXhdYBk1IdYERqnBh4N0qu3q2jTE8OZyW1uFPLzPcfg/gNdCi2EgRd/xSYotdRz7bVvBF+nLr6opgbcqwtD5r8I4iABEOlccGrmoAyr42NOdlD1dlxkzAUic6MA0ojao8lnzPpd90NrHp3ZrEiFDK9usrKgHicwYQI/5W47sh9iINajkbNZWc6cA6l7jPMLagZT1PbMubKemio2IRUZxP/JPb00X9jmONgfmchP+pB7P0TS6JGXwdrgA5NoW+xXV5Hy2kAgI9+yQtupVqCzTZC8pHzEgQX/iBVN+F89HPUB5/SdKu05TyCB/mnHJ9DSSE6p2KL4kl7LbdZ90BJopEdPHboZniHu200PSWl/WCgV2lZEHhKQv1JE/mse1r7vlplo0vFFerKoo6d7LbVZuujd+/0u1HTh7YVf0idfzUzOztdNJcmXLMujGdCdekQz+DP+msH1vy62xGiOwys+yQOWlaE59J0Z+HBjEflCsJruN6TL/0i+RAHMJuK7vRLbF3W9P9O8UoQ4a75spHe37IEmxLmz97B44wgcULjG+ErCYd91iKBnlzLr UWf1l8BQ o06EkTCI2nqs88lnXzUwLNBSZB7k0MglWkZ+RzkRMkLgUl+JT608v+pg9ugk6loT4vw7etPUY8IxXsMSnwytqIziboMkRkmyyoEL4eB0v1und7sjx8gUMpAV+N464PEaE2wYkPHFEWOMMbrIhAL/1c3VE3Ar2kWF/YGfoho5zh5Fdo7Vh/zWNGs8Et1fWL6P2eU3OUzoOfiwIU/wTZGKZh402XTjdAAqWyRv43yn2SFavNIA8+yBg4W2n4bvxw+JKtmdOwhqplmqP9DsRUki+5Kd/byvIFBlxlHldaMgsXEmcI6XMeKxwYr6ntywy13Sg+ZRTKi+W9KKFHVZ65WOcKUvu0aQHfjN7Z1SHTi5Kgfg2rS8WWz2pMVBRTBMQ4x4HYzzF0hG3j9T8emsZCCxMLh7dkQCLdARk9fY/6yroKsUNnaHH+/1ofuD2zyOYxoBd899NqBtNm1fVoXhus+Mj9BGukHkWkwvl58be8H2sUvhwlM9gdSFKfGjfNc4kFUeIle16YHHHVfiZSA1DVyMqICT94L7Nnnb0I1qpkhPSFJRYniCN03mH7pZmDUfXA6LA0Fp5 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10/27/23 20:21, Sean Christopherson wrote: > Assert that both KVM_ARCH_WANT_MMU_NOTIFIER and CONFIG_MMU_NOTIFIER are > defined when KVM is enabled, and return '1' unconditionally for the > CONFIG_KVM_BOOK3S_HV_POSSIBLE=n path. All flavors of PPC support for KVM > select MMU_NOTIFIER, and KVM_ARCH_WANT_MMU_NOTIFIER is unconditionally > defined by arch/powerpc/include/asm/kvm_host.h. > > Effectively dropping use of KVM_ARCH_WANT_MMU_NOTIFIER will simplify a > future cleanup to turn KVM_ARCH_WANT_MMU_NOTIFIER into a Kconfig, i.e. > will allow combining all of the > > #if defined(CONFIG_MMU_NOTIFIER) && defined(KVM_ARCH_WANT_MMU_NOTIFIER) > > checks into a single > > #ifdef CONFIG_KVM_GENERIC_MMU_NOTIFIER > > without having to worry about PPC's "bare" usage of > KVM_ARCH_WANT_MMU_NOTIFIER. > > Signed-off-by: Sean Christopherson > --- > arch/powerpc/kvm/powerpc.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/arch/powerpc/kvm/powerpc.c b/arch/powerpc/kvm/powerpc.c > index 7197c8256668..b0a512ede764 100644 > --- a/arch/powerpc/kvm/powerpc.c > +++ b/arch/powerpc/kvm/powerpc.c > @@ -632,12 +632,13 @@ int kvm_vm_ioctl_check_extension(struct kvm *kvm, long ext) > break; > #endif > case KVM_CAP_SYNC_MMU: > +#if !defined(CONFIG_MMU_NOTIFIER) || !defined(KVM_ARCH_WANT_MMU_NOTIFIER) > + BUILD_BUG(); > +#endif > #ifdef CONFIG_KVM_BOOK3S_HV_POSSIBLE > r = hv_enabled; > -#elif defined(KVM_ARCH_WANT_MMU_NOTIFIER) > - r = 1; > #else > - r = 0; > + r = 1; > #endif > break; > #ifdef CONFIG_KVM_BOOK3S_HV_POSSIBLE Reviewed-by: Paolo Bonzini