From: David Hildenbrand <david@redhat.com>
To: Dev Jain <dev.jain@arm.com>, akpm@linux-foundation.org
Cc: ryan.roberts@arm.com, willy@infradead.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, catalin.marinas@arm.com,
will@kernel.org, Liam.Howlett@oracle.com,
lorenzo.stoakes@oracle.com, vbabka@suse.cz, jannh@google.com,
anshuman.khandual@arm.com, peterx@redhat.com, joey.gouly@arm.com,
ioworker0@gmail.com, baohua@kernel.org, kevin.brodsky@arm.com,
quic_zhenhuah@quicinc.com, christophe.leroy@csgroup.eu,
yangyicong@hisilicon.com, linux-arm-kernel@lists.infradead.org,
hughd@google.com, yang@os.amperecomputing.com, ziy@nvidia.com
Subject: Re: [PATCH v5 6/7] mm: Optimize mprotect() by PTE batching
Date: Wed, 6 Aug 2025 10:56:13 +0200 [thread overview]
Message-ID: <4e6e0492-f2f3-44d8-ad02-084a47c9fa4b@redhat.com> (raw)
In-Reply-To: <a2fdcb87-9223-4091-8bda-9d9316c84cf4@arm.com>
>> While staring at this:
>>
>> Very broken indentation.
>
> Indeed, but then in order to fix the indentation if we start positioning
>
> every argument just below the opening bracket then it will take at least
> four lines :)
You are allowed to use more than 80 chars if there is good reason :)
--
Cheers,
David / dhildenb
next prev parent reply other threads:[~2025-08-06 8:56 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-18 9:02 [PATCH v5 0/7] Optimize mprotect() for large folios Dev Jain
2025-07-18 9:02 ` [PATCH v5 1/7] mm: Refactor MM_CP_PROT_NUMA skipping case into new function Dev Jain
2025-07-18 16:19 ` Lorenzo Stoakes
2025-07-20 23:44 ` Barry Song
2025-07-21 3:44 ` Dev Jain
2025-07-22 11:05 ` Dev Jain
2025-07-22 11:25 ` Ryan Roberts
2025-07-23 13:57 ` Zi Yan
2025-07-18 9:02 ` [PATCH v5 2/7] mm: Optimize mprotect() for MM_CP_PROT_NUMA by batch-skipping PTEs Dev Jain
2025-07-18 16:40 ` Lorenzo Stoakes
2025-07-22 11:26 ` Ryan Roberts
2025-07-23 14:25 ` Zi Yan
2025-07-18 9:02 ` [PATCH v5 3/7] mm: Add batched versions of ptep_modify_prot_start/commit Dev Jain
2025-07-18 17:05 ` Lorenzo Stoakes
2025-07-20 23:59 ` Barry Song
2025-07-22 11:35 ` Ryan Roberts
2025-07-23 15:09 ` Zi Yan
2025-07-18 9:02 ` [PATCH v5 4/7] mm: Introduce FPB_RESPECT_WRITE for PTE batching infrastructure Dev Jain
2025-07-18 17:12 ` Lorenzo Stoakes
2025-07-22 11:37 ` Ryan Roberts
2025-07-23 15:28 ` Zi Yan
2025-07-23 15:32 ` Dev Jain
2025-07-18 9:02 ` [PATCH v5 5/7] mm: Split can_change_pte_writable() into private and shared parts Dev Jain
2025-07-18 17:27 ` Lorenzo Stoakes
2025-07-23 15:40 ` Zi Yan
2025-07-18 9:02 ` [PATCH v5 6/7] mm: Optimize mprotect() by PTE batching Dev Jain
2025-07-18 18:49 ` Lorenzo Stoakes
2025-07-19 13:46 ` Dev Jain
2025-07-20 11:20 ` Lorenzo Stoakes
2025-07-20 14:39 ` Dev Jain
2025-07-24 19:55 ` Zi Yan
2025-08-06 8:08 ` David Hildenbrand
2025-08-06 8:12 ` David Hildenbrand
2025-08-06 8:15 ` Will Deacon
2025-08-06 8:19 ` David Hildenbrand
2025-08-06 8:53 ` Dev Jain
2025-08-06 8:56 ` David Hildenbrand [this message]
2025-08-06 9:12 ` Lorenzo Stoakes
2025-08-06 9:21 ` David Hildenbrand
2025-08-06 9:37 ` Dev Jain
2025-08-06 9:50 ` Lorenzo Stoakes
2025-08-06 10:04 ` Dev Jain
2025-08-06 10:07 ` Dev Jain
2025-08-06 10:12 ` David Hildenbrand
2025-08-06 10:11 ` David Hildenbrand
2025-08-06 10:20 ` Dev Jain
2025-08-06 10:28 ` David Hildenbrand
2025-08-06 10:45 ` Lorenzo Stoakes
2025-08-06 10:45 ` Lorenzo Stoakes
2025-07-18 9:02 ` [PATCH v5 7/7] arm64: Add batched versions of ptep_modify_prot_start/commit Dev Jain
2025-07-18 18:50 ` Lorenzo Stoakes
2025-07-21 15:57 ` Catalin Marinas
2025-07-18 9:50 ` [PATCH v5 0/7] Optimize mprotect() for large folios Dev Jain
2025-07-18 18:53 ` Lorenzo Stoakes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e6e0492-f2f3-44d8-ad02-084a47c9fa4b@redhat.com \
--to=david@redhat.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=baohua@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=christophe.leroy@csgroup.eu \
--cc=dev.jain@arm.com \
--cc=hughd@google.com \
--cc=ioworker0@gmail.com \
--cc=jannh@google.com \
--cc=joey.gouly@arm.com \
--cc=kevin.brodsky@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=peterx@redhat.com \
--cc=quic_zhenhuah@quicinc.com \
--cc=ryan.roberts@arm.com \
--cc=vbabka@suse.cz \
--cc=will@kernel.org \
--cc=willy@infradead.org \
--cc=yang@os.amperecomputing.com \
--cc=yangyicong@hisilicon.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).