From: Rik van Riel <riel@redhat.com>
To: Michal Hocko <mhocko@suse.cz>
Cc: Ying Han <yinghan@google.com>,
Johannes Weiner <hannes@cmpxchg.org>, Mel Gorman <mel@csn.ul.ie>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Hillf Danton <dhillf@gmail.com>, Hugh Dickins <hughd@google.com>,
KOSAKI Motohiro <kosaki.motohiro@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org
Subject: Re: [PATCH V7 2/2] mm: memcg detect no memcgs above softlimit under zone reclaim
Date: Tue, 31 Jul 2012 12:07:55 -0400 [thread overview]
Message-ID: <501802DB.5030600@redhat.com> (raw)
In-Reply-To: <20120731155932.GB16924@tiehlicka.suse.cz>
On 07/31/2012 11:59 AM, Michal Hocko wrote:
>> @@ -1899,6 +1907,11 @@ static void shrink_zone(struct zone *zone, struct scan_control *sc)
>> }
>> memcg = mem_cgroup_iter(root, memcg,&reclaim);
>> } while (memcg);
>> +
>> + if (!over_softlimit) {
>
> Is this ever false? At least root cgroup is always above the limit.
> Shouldn't we rather compare reclaimed pages?
Uh oh.
That could also result in us always reclaiming from the root cgroup
first...
Is that really what we want?
Having said that, in April I discussed an algorithm of LRU list
weighting with Ying and others that should work. Ying's patches
look like a good basis to implement that on top of...
--
All rights reversed
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-07-31 17:25 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-30 22:32 [PATCH V7 2/2] mm: memcg detect no memcgs above softlimit under zone reclaim Ying Han
2012-07-31 15:59 ` Michal Hocko
2012-07-31 16:07 ` Rik van Riel [this message]
2012-07-31 17:52 ` Ying Han
2012-07-31 17:54 ` Ying Han
2012-07-31 20:02 ` Michal Hocko
2012-07-31 20:59 ` Ying Han
2012-08-01 8:45 ` Michal Hocko
2012-08-01 19:04 ` Ying Han
2012-08-01 20:10 ` Rik van Riel
2012-08-02 0:09 ` Ying Han
2012-08-02 0:43 ` Rik van Riel
2012-08-06 14:03 ` Michal Hocko
2012-08-06 14:27 ` Rik van Riel
2012-08-06 15:11 ` Michal Hocko
2012-08-06 18:51 ` Rik van Riel
2012-08-06 21:18 ` Ying Han
2012-08-06 22:54 ` Rik van Riel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=501802DB.5030600@redhat.com \
--to=riel@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=dhillf@gmail.com \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kosaki.motohiro@gmail.com \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=mhocko@suse.cz \
--cc=yinghan@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).