From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx205.postini.com [74.125.245.205]) by kanga.kvack.org (Postfix) with SMTP id 0817D6B004D for ; Wed, 1 Aug 2012 16:55:32 -0400 (EDT) Message-ID: <5019975B.6010708@redhat.com> Date: Wed, 01 Aug 2012 16:53:47 -0400 From: Rik van Riel MIME-Version: 1.0 Subject: Re: [PATCH v4 1/3] mm: introduce compaction and migration for virtio ballooned pages References: <49f828a9331c9b729fcf77226006921ec5bc52fa.1342485774.git.aquini@redhat.com> <20120718054824.GA32341@bbox> <20120720194858.GA16249@t510.redhat.com> <20120723023332.GA6832@bbox> <20120723181952.GA27373@t510.redhat.com> In-Reply-To: <20120723181952.GA27373@t510.redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Rafael Aquini Cc: Minchan Kim , linux-mm@kvack.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, Rusty Russell , "Michael S. Tsirkin" , Mel Gorman , Andi Kleen , Andrew Morton , Konrad Rzeszutek Wilk , Rafael Aquini On 07/23/2012 02:19 PM, Rafael Aquini wrote: > In a glance, I believe this whole dance you're suggesting might just be too much > of an overcomplication, and the best approach would be simply teaching the > hotplug bits about the ballooned corner case just like it's being done to > compaction/migration. However, I'll look at it carefully before making any other > adjustments/propositions over here. Compaction and hotplug do essentially the same thing here: "collect all the movable pages from a page block, and move them elsewhere". Whether or not it is easier for them to share code, or to duplicate a few lines of code, is something that can be looked into later. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org