From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx186.postini.com [74.125.245.186]) by kanga.kvack.org (Postfix) with SMTP id 752046B0044 for ; Mon, 6 Aug 2012 14:39:00 -0400 (EDT) Message-ID: <50200F1F.7060605@redhat.com> Date: Mon, 06 Aug 2012 14:38:23 -0400 From: Rik van Riel MIME-Version: 1.0 Subject: Re: [PATCH v5 1/3] mm: introduce compaction and migration for virtio ballooned pages References: <212b5297df32cb4e3f60d5b76a8cb0629d328a4e.1344259054.git.aquini@redhat.com> In-Reply-To: <212b5297df32cb4e3f60d5b76a8cb0629d328a4e.1344259054.git.aquini@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Rafael Aquini Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, Rusty Russell , "Michael S. Tsirkin" , Mel Gorman , Andi Kleen , Andrew Morton , Konrad Rzeszutek Wilk , Minchan Kim On 08/06/2012 09:56 AM, Rafael Aquini wrote: > @@ -846,6 +861,21 @@ static int unmap_and_move(new_page_t get_new_page, unsigned long private, > goto out; > > rc = __unmap_and_move(page, newpage, force, offlining, mode); > + > + if (unlikely(is_balloon_page(newpage)&& > + balloon_compaction_enabled())) { Could that be collapsed into one movable_balloon_page(newpage) function call? -- All rights reversed -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org