From: Rik van Riel <riel@redhat.com>
To: Michal Hocko <mhocko@suse.cz>
Cc: Ying Han <yinghan@google.com>,
Johannes Weiner <hannes@cmpxchg.org>, Mel Gorman <mel@csn.ul.ie>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Hillf Danton <dhillf@gmail.com>, Hugh Dickins <hughd@google.com>,
KOSAKI Motohiro <kosaki.motohiro@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org
Subject: Re: [PATCH V7 2/2] mm: memcg detect no memcgs above softlimit under zone reclaim
Date: Mon, 06 Aug 2012 14:51:22 -0400 [thread overview]
Message-ID: <5020122A.5070704@redhat.com> (raw)
In-Reply-To: <20120806151115.GA4850@dhcp22.suse.cz>
On 08/06/2012 11:11 AM, Michal Hocko wrote:
> On Mon 06-08-12 10:27:25, Rik van Riel wrote:
>>> So you think we shouldn't do the full round over memcgs in shrink_zone a
>>> and rather do it oom way to pick up a victim and hammer it?
>>
>> Not hammer it too far. Only until its score ends up well
>> below (25% lower?) than that of the second highest scoring
>> list.
>>
>> That way all the lists get hammered a little bit, in turn.
>
> How do we provide the soft limit guarantee then?
>
> [...]
The easiest way would be to find the top 2 or 3 scoring memcgs
when we reclaim memory. After reclaiming some pages, recalculate
the scores of just these top lists, and see if the list we started
out with now has a lower score than the second one.
Once we have reclaimed some from each of the 2 or 3 lists, we can
go back and find the highest priority lists again.
Direct reclaim only reclaims a little bit at a time, anyway.
For kswapd, we could also remember the number of pages the group
has in excess of its soft limit, and recalculate after that...
--
All rights reversed
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-08-06 18:51 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-30 22:32 [PATCH V7 2/2] mm: memcg detect no memcgs above softlimit under zone reclaim Ying Han
2012-07-31 15:59 ` Michal Hocko
2012-07-31 16:07 ` Rik van Riel
2012-07-31 17:52 ` Ying Han
2012-07-31 17:54 ` Ying Han
2012-07-31 20:02 ` Michal Hocko
2012-07-31 20:59 ` Ying Han
2012-08-01 8:45 ` Michal Hocko
2012-08-01 19:04 ` Ying Han
2012-08-01 20:10 ` Rik van Riel
2012-08-02 0:09 ` Ying Han
2012-08-02 0:43 ` Rik van Riel
2012-08-06 14:03 ` Michal Hocko
2012-08-06 14:27 ` Rik van Riel
2012-08-06 15:11 ` Michal Hocko
2012-08-06 18:51 ` Rik van Riel [this message]
2012-08-06 21:18 ` Ying Han
2012-08-06 22:54 ` Rik van Riel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5020122A.5070704@redhat.com \
--to=riel@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=dhillf@gmail.com \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kosaki.motohiro@gmail.com \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=mhocko@suse.cz \
--cc=yinghan@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).