From: Glauber Costa <glommer@parallels.com>
To: Kamezawa Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
cgroups@vger.kernel.org, devel@openvz.org,
Michal Hocko <mhocko@suse.cz>,
Johannes Weiner <hannes@cmpxchg.org>,
Andrew Morton <akpm@linux-foundation.org>,
Christoph Lameter <cl@linux.com>,
David Rientjes <rientjes@google.com>,
Pekka Enberg <penberg@kernel.org>,
Pekka Enberg <penberg@cs.helsinki.fi>
Subject: Re: [PATCH v2 06/11] memcg: kmem controller infrastructure
Date: Tue, 14 Aug 2012 15:00:53 +0400 [thread overview]
Message-ID: <502A2FE5.4060809@parallels.com> (raw)
In-Reply-To: <50254475.4000201@jp.fujitsu.com>
On 08/10/2012 09:27 PM, Kamezawa Hiroyuki wrote:
>> +bool __memcg_kmem_new_page(gfp_t gfp, void *_handle, int order)
>> > +{
>> > + struct mem_cgroup *memcg;
>> > + struct mem_cgroup **handle = (struct mem_cgroup **)_handle;
>> > + bool ret = true;
>> > + size_t size;
>> > + struct task_struct *p;
>> > +
>> > + *handle = NULL;
>> > + rcu_read_lock();
>> > + p = rcu_dereference(current->mm->owner);
>> > + memcg = mem_cgroup_from_task(p);
>> > + if (!memcg_kmem_enabled(memcg))
>> > + goto out;
>> > +
>> > + mem_cgroup_get(memcg);
>> > +
> This mem_cgroup_get() will be a potentioal performance problem.
> Don't you have good idea to avoid accessing atomic counter here ?
> I think some kind of percpu counter or a feature to disable "move task"
> will be a help.
>
>
I have just sent out a proposal to deal with this. I tried the trick of
marking only the first charge and last uncharge, and it works quite
alright at the cost of a bit test on most calls to memcg_kmem_charge.
Please let me know what you think.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-08-14 11:04 UTC|newest]
Thread overview: 135+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-09 13:01 [PATCH v2 00/11] Request for Inclusion: kmem controller for memcg Glauber Costa
2012-08-09 13:01 ` [PATCH v2 01/11] memcg: Make it possible to use the stock for more than one page Glauber Costa
2012-08-10 15:12 ` Michal Hocko
2012-08-09 13:01 ` [PATCH v2 02/11] memcg: Reclaim when more than one page needed Glauber Costa
2012-08-10 15:42 ` Michal Hocko
2012-08-10 16:49 ` Kamezawa Hiroyuki
2012-08-10 17:28 ` Michal Hocko
2012-08-10 17:56 ` Kamezawa Hiroyuki
2012-08-10 17:30 ` Michal Hocko
2012-08-10 18:52 ` Michal Hocko
2012-08-10 18:54 ` Michal Hocko
2012-08-13 8:05 ` Glauber Costa
2012-08-13 13:10 ` Michal Hocko
2012-08-09 13:01 ` [PATCH v2 03/11] memcg: change defines to an enum Glauber Costa
2012-08-10 15:43 ` Michal Hocko
2012-08-09 13:01 ` [PATCH v2 04/11] kmem accounting basic infrastructure Glauber Costa
2012-08-10 17:02 ` Kamezawa Hiroyuki
2012-08-13 8:36 ` Glauber Costa
2012-08-17 2:38 ` Kamezawa Hiroyuki
2012-08-14 16:21 ` Michal Hocko
2012-08-15 9:33 ` Glauber Costa
2012-08-15 11:12 ` James Bottomley
2012-08-15 12:55 ` Michal Hocko
2012-08-15 13:29 ` James Bottomley
2012-08-15 12:39 ` Michal Hocko
2012-08-15 12:53 ` Glauber Costa
2012-08-15 13:02 ` Michal Hocko
2012-08-15 13:04 ` Glauber Costa
2012-08-15 13:26 ` Michal Hocko
2012-08-15 13:31 ` Glauber Costa
2012-08-15 14:10 ` Michal Hocko
2012-08-15 14:11 ` Glauber Costa
2012-08-15 14:47 ` Christoph Lameter
2012-08-15 15:11 ` Glauber Costa
2012-08-15 15:34 ` Christoph Lameter
2012-08-15 15:35 ` Glauber Costa
2012-08-15 17:26 ` Christoph Lameter
2012-08-15 18:11 ` Ying Han
2012-08-15 18:25 ` Christoph Lameter
2012-08-15 19:22 ` Glauber Costa
2012-08-15 18:07 ` Ying Han
2012-08-15 15:19 ` Greg Thelen
2012-08-15 15:36 ` Christoph Lameter
2012-08-15 18:01 ` Ying Han
2012-08-15 18:00 ` Glauber Costa
2012-08-15 19:50 ` Ying Han
2012-08-16 15:25 ` Michal Hocko
2012-08-17 5:58 ` Ying Han
2012-08-09 13:01 ` [PATCH v2 05/11] Add a __GFP_KMEMCG flag Glauber Costa
2012-08-10 17:07 ` Kamezawa Hiroyuki
2012-08-09 13:01 ` [PATCH v2 06/11] memcg: kmem controller infrastructure Glauber Costa
2012-08-10 17:27 ` Kamezawa Hiroyuki
2012-08-13 8:28 ` Glauber Costa
2012-08-14 18:58 ` Greg Thelen
2012-08-15 9:18 ` Glauber Costa
2012-08-15 16:38 ` Greg Thelen
2012-08-15 17:00 ` Glauber Costa
2012-08-15 17:12 ` Greg Thelen
2012-08-15 19:31 ` Glauber Costa
2012-08-16 3:37 ` Greg Thelen
2012-08-16 7:47 ` Glauber Costa
2012-08-20 13:36 ` Kamezawa Hiroyuki
2012-08-20 15:29 ` Glauber Costa
2012-08-17 2:36 ` Kamezawa Hiroyuki
2012-08-17 7:04 ` Glauber Costa
2012-08-14 11:00 ` Glauber Costa [this message]
2012-08-11 5:11 ` Greg Thelen
2012-08-13 8:07 ` Glauber Costa
2012-08-13 9:59 ` Glauber Costa
2012-08-13 21:21 ` Greg Thelen
2012-08-14 17:25 ` Michal Hocko
2012-08-15 9:42 ` Glauber Costa
2012-08-15 10:44 ` Glauber Costa
2012-08-15 13:09 ` Michal Hocko
2012-08-15 14:01 ` Glauber Costa
2012-08-15 14:23 ` Michal Hocko
2012-08-15 14:27 ` Glauber Costa
2012-08-16 9:53 ` Michal Hocko
2012-08-16 9:57 ` Glauber Costa
2012-08-16 15:05 ` Michal Hocko
2012-08-16 15:22 ` Glauber Costa
2012-08-21 21:50 ` Greg Thelen
2012-08-22 8:35 ` Glauber Costa
2012-08-23 0:07 ` Greg Thelen
2012-08-23 7:51 ` Glauber Costa
2012-08-09 13:01 ` [PATCH v2 07/11] mm: Allocate kernel pages to the right memcg Glauber Costa
2012-08-09 16:33 ` Greg Thelen
2012-08-09 16:42 ` Glauber Costa
2012-08-10 17:33 ` Kamezawa Hiroyuki
2012-08-13 8:03 ` Glauber Costa
2012-08-13 8:57 ` Mel Gorman
2012-08-10 17:36 ` Greg Thelen
2012-08-13 8:02 ` Glauber Costa
2012-08-14 15:16 ` Mel Gorman
2012-08-15 9:08 ` Glauber Costa
2012-08-15 13:22 ` Mel Gorman
2012-08-15 13:39 ` Glauber Costa
2012-08-15 13:51 ` Glauber Costa
2012-08-15 9:24 ` Michal Hocko
2012-08-09 13:01 ` [PATCH v2 08/11] memcg: disable kmem code when not in use Glauber Costa
2012-08-17 7:02 ` Michal Hocko
2012-08-17 7:01 ` Glauber Costa
2012-08-17 8:04 ` Michal Hocko
2012-08-09 13:01 ` [PATCH v2 09/11] memcg: propagate kmem limiting information to children Glauber Costa
2012-08-10 17:51 ` Kamezawa Hiroyuki
2012-08-13 8:01 ` Glauber Costa
2012-08-17 9:00 ` Michal Hocko
2012-08-17 9:15 ` Glauber Costa
2012-08-17 9:35 ` Michal Hocko
2012-08-17 10:07 ` Glauber Costa
2012-08-17 10:35 ` Michal Hocko
2012-08-17 10:36 ` Glauber Costa
2012-08-21 7:54 ` Michal Hocko
2012-08-21 8:35 ` Michal Hocko
2012-08-21 9:17 ` Glauber Costa
2012-08-21 9:22 ` Glauber Costa
2012-08-21 10:00 ` Michal Hocko
2012-08-21 10:01 ` Glauber Costa
2012-08-22 1:09 ` Greg Thelen
2012-08-22 8:22 ` Glauber Costa
2012-08-22 23:23 ` Greg Thelen
2012-08-23 7:55 ` Glauber Costa
2012-08-24 5:06 ` Greg Thelen
2012-08-24 5:23 ` Glauber Costa
2012-08-17 10:39 ` Glauber Costa
2012-08-09 13:01 ` [PATCH v2 10/11] memcg: allow a memcg with kmem charges to be destructed Glauber Costa
2012-08-21 8:22 ` Michal Hocko
2012-08-22 8:36 ` Glauber Costa
2012-08-09 13:01 ` [PATCH v2 11/11] protect architectures where THREAD_SIZE >= PAGE_SIZE against fork bombs Glauber Costa
2012-08-10 17:54 ` Kamezawa Hiroyuki
2012-08-21 9:35 ` Michal Hocko
2012-08-21 9:40 ` Glauber Costa
2012-08-21 10:57 ` Michal Hocko
2012-08-17 21:37 ` [PATCH v2 00/11] Request for Inclusion: kmem controller for memcg Ying Han
2012-08-20 7:51 ` Glauber Costa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=502A2FE5.4060809@parallels.com \
--to=glommer@parallels.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=cl@linux.com \
--cc=devel@openvz.org \
--cc=hannes@cmpxchg.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=penberg@cs.helsinki.fi \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).