linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Rik van Riel <riel@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Rafael Aquini <aquini@redhat.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	Rusty Russell <rusty@rustcorp.com.au>, Mel Gorman <mel@csn.ul.ie>,
	Andi Kleen <andi@firstfloor.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Minchan Kim <minchan@kernel.org>
Subject: Re: [PATCH v7 2/4] virtio_balloon: introduce migration primitives to balloon pages
Date: Wed, 15 Aug 2012 11:30:34 -0400	[thread overview]
Message-ID: <502BC09A.5050104@redhat.com> (raw)
In-Reply-To: <20120814213832.GA29180@redhat.com>

On 08/14/2012 05:38 PM, Michael S. Tsirkin wrote:

> And even ignoring that, global pointer to a device
> is an ugly hack and ugly hacks tend to explode.
>
> And even ignoring estetics, and if we decide we are fine
> with a single balloon, it needs to fail gracefully not
> crash like it does now.

Fair enough.  That certainly seems easy enough to fix.

Each balloon driver can have its own struct address_space,
and simply point mapping->host (or any of the others) at
a global balloon thing somewhere.

if (page->mapping && page->mapping->host == balloon_magic)


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2012-08-15 15:32 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-10 17:55 [PATCH v7 0/4] make balloon pages movable by compaction Rafael Aquini
2012-08-10 17:55 ` [PATCH v7 1/4] mm: introduce compaction and migration for virtio ballooned pages Rafael Aquini
2012-08-12 23:14   ` Minchan Kim
2012-08-13  8:26   ` Michael S. Tsirkin
2012-08-14 17:44     ` Rafael Aquini
2012-08-14 19:35       ` Michael S. Tsirkin
2012-08-14 19:48         ` Michael S. Tsirkin
2012-08-14 20:03           ` Rafael Aquini
2012-08-14 20:00         ` Rafael Aquini
2012-08-14 20:23           ` Michael S. Tsirkin
2012-08-15  8:52           ` Mel Gorman
2012-08-14 19:52       ` Michael S. Tsirkin
2012-08-10 17:55 ` [PATCH v7 2/4] virtio_balloon: introduce migration primitives to balloon pages Rafael Aquini
2012-08-13  8:41   ` Michael S. Tsirkin
2012-08-13 23:59     ` Rusty Russell
2012-08-14  8:33       ` Michael S. Tsirkin
2012-08-14 18:44         ` Rafael Aquini
2012-08-14 19:31           ` Michael S. Tsirkin
2012-08-15 12:34             ` Rafael Aquini
2012-08-15 14:40               ` Michael S. Tsirkin
2012-08-20  2:29                 ` Rusty Russell
2012-08-20  5:12                   ` Michael S. Tsirkin
2012-08-15  3:13         ` Rusty Russell
2012-08-14 18:22     ` Rafael Aquini
2012-08-14 19:51       ` Michael S. Tsirkin
2012-08-14 19:59         ` Michael S. Tsirkin
2012-08-14 20:08           ` Rafael Aquini
2012-08-14 20:24             ` Michael S. Tsirkin
2012-08-14 20:29               ` Rafael Aquini
2012-08-14 20:49                 ` Michael S. Tsirkin
2012-08-14 20:54                   ` Michael S. Tsirkin
2012-08-14 20:56                     ` Rik van Riel
2012-08-14 21:38                       ` Michael S. Tsirkin
2012-08-15 15:30                         ` Rik van Riel [this message]
2012-08-14 21:34                   ` Rafael Aquini
2012-08-14 22:48                     ` Michael S. Tsirkin
2012-08-14 20:11         ` Rafael Aquini
2012-08-14 20:31           ` Michael S. Tsirkin
2012-08-15  9:05           ` Mel Gorman
2012-08-15  9:25             ` Michael S. Tsirkin
2012-08-15  9:48               ` Mel Gorman
2012-08-15 10:01                 ` Michael S. Tsirkin
2012-08-15 11:16                   ` Mel Gorman
2012-08-15 11:28                     ` Michael S. Tsirkin
2012-08-21  5:31                       ` Rusty Russell
2012-08-22  0:37                         ` Michael S. Tsirkin
2012-08-10 17:55 ` [PATCH v7 3/4] mm: introduce putback_movable_pages() Rafael Aquini
2012-08-12 23:26   ` Minchan Kim
2012-08-10 17:55 ` [PATCH v7 4/4] mm: add vm event counters for balloon pages compaction Rafael Aquini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=502BC09A.5050104@redhat.com \
    --to=riel@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=andi@firstfloor.org \
    --cc=aquini@redhat.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mel@csn.ul.ie \
    --cc=minchan@kernel.org \
    --cc=mst@redhat.com \
    --cc=rusty@rustcorp.com.au \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).