From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx181.postini.com [74.125.245.181]) by kanga.kvack.org (Postfix) with SMTP id 60F1B6B002B for ; Wed, 15 Aug 2012 11:32:36 -0400 (EDT) Message-ID: <502BC09A.5050104@redhat.com> Date: Wed, 15 Aug 2012 11:30:34 -0400 From: Rik van Riel MIME-Version: 1.0 Subject: Re: [PATCH v7 2/4] virtio_balloon: introduce migration primitives to balloon pages References: <20120813084123.GF14081@redhat.com> <20120814182244.GB13338@t510.redhat.com> <20120814195139.GA28870@redhat.com> <20120814195916.GC28870@redhat.com> <20120814200830.GD22133@t510.redhat.com> <20120814202401.GB28990@redhat.com> <20120814202949.GF22133@t510.redhat.com> <20120814204906.GD28990@redhat.com> <20120814205426.GA29162@redhat.com> <502ABB9B.90108@redhat.com> <20120814213832.GA29180@redhat.com> In-Reply-To: <20120814213832.GA29180@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: "Michael S. Tsirkin" Cc: Rafael Aquini , linux-mm@kvack.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, Rusty Russell , Mel Gorman , Andi Kleen , Andrew Morton , Konrad Rzeszutek Wilk , Minchan Kim On 08/14/2012 05:38 PM, Michael S. Tsirkin wrote: > And even ignoring that, global pointer to a device > is an ugly hack and ugly hacks tend to explode. > > And even ignoring estetics, and if we decide we are fine > with a single balloon, it needs to fail gracefully not > crash like it does now. Fair enough. That certainly seems easy enough to fix. Each balloon driver can have its own struct address_space, and simply point mapping->host (or any of the others) at a global balloon thing somewhere. if (page->mapping && page->mapping->host == balloon_magic) -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org