From: Glauber Costa <glommer@parallels.com>
To: Ying Han <yinghan@google.com>
Cc: Michal Hocko <mhocko@suse.cz>,
Johannes Weiner <hannes@cmpxchg.org>, Mel Gorman <mel@csn.ul.ie>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Rik van Riel <riel@redhat.com>, Greg Thelen <gthelen@google.com>,
Christoph Lameter <cl@linux.com>,
KOSAKI Motohiro <kosaki.motohiro@gmail.com>,
linux-mm@kvack.org
Subject: Re: [RFC PATCH 2/6] memcg: add target_mem_cgroup, mem_cgroup fields to shrink_control
Date: Fri, 17 Aug 2012 09:30:07 +0400 [thread overview]
Message-ID: <502DD6DF.6070404@parallels.com> (raw)
In-Reply-To: <1345150434-30957-1-git-send-email-yinghan@google.com>
On 08/17/2012 12:53 AM, Ying Han wrote:
> Add target_mem_cgroup and mem_cgroup to shrink_control. The former one is the
> "root" memcg under pressure, and the latter one is the "current" memcg under
> pressure.
>
> The target_mem_cgroup is initialized with the scan_control's target_mem_cgroup
> under target reclaim and default to NULL for rest of the places including
> global reclaim.
>
> Signed-off-by: Ying Han <yinghan@google.com>
Maybe I'll change my mind while I advance in the patchset, but at first,
I don't see the point in having two memcg encoded in the shrinker
structure. It seems to me we should be able to do this internally from
memcg and hide it from the shrinker code.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-08-17 5:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-16 20:53 [RFC PATCH 2/6] memcg: add target_mem_cgroup, mem_cgroup fields to shrink_control Ying Han
2012-08-17 5:30 ` Glauber Costa [this message]
2012-08-17 5:41 ` Ying Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=502DD6DF.6070404@parallels.com \
--to=glommer@parallels.com \
--cc=cl@linux.com \
--cc=gthelen@google.com \
--cc=hannes@cmpxchg.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kosaki.motohiro@gmail.com \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=mhocko@suse.cz \
--cc=riel@redhat.com \
--cc=yinghan@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).