From: Glauber Costa <glommer@parallels.com>
To: Christoph Lameter <cl@linux.com>
Cc: Pekka Enberg <penberg@kernel.org>, Joonsoo Kim <js1304@gmail.com>,
linux-mm@kvack.org, David Rientjes <rientjes@google.com>
Subject: Re: C12 [12/19] Move kmem_cache allocations into common code.
Date: Thu, 23 Aug 2012 17:57:34 +0400 [thread overview]
Message-ID: <503636CE.20501@parallels.com> (raw)
In-Reply-To: <0000013953bebca6-5a541bae-58b7-4a3c-a3c2-69cc7bb9c04b-000000@email.amazonses.com>
On 08/23/2012 05:49 PM, Christoph Lameter wrote:
> On Thu, 23 Aug 2012, Glauber Costa wrote:
>
>> This code is prone to errors, as can be easily seen by the amount of
>> interactions it had, all of them with bugs. Our best friend in finding
>> those bugs is pinpointing the patch where it happens. Please make it easy.
>
> Yes this is pretty key stuff and I am definitely trying to make it as
> clean and easy possible.. I am trying my best but I have a limited time
> that I can spend on running tests.
>
That is understandable. The way to scale that is to have other people
testing the final result, and that is precisely what I am doing.
> It would help if you could try to understand the code, suggest
> improvements and verify that the changes are sane. So far I mostly see
> "this aint working" instead of an engagement with the code.
>
You can't be serious...
I tested every series you posted. I code reviewed all your iterations so
far. Found a bunch of bugs, debugged all of them up to v11. Pinpointed
to you the exact source of a lot of them, as a result of the
aforementioned debugging.
How isn't it engagement? Seriously?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-08-23 14:00 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20120820204021.494276880@linux.com>
2012-08-20 20:47 ` C12 [01/19] slub: Add debugging to verify correct cache use on kmem_cache_free() Christoph Lameter
2012-08-20 20:50 ` C12 [02/19] slub: Use kmem_cache for the kmem_cache structure Christoph Lameter
2012-08-20 20:50 ` C12 [01/19] slub: Add debugging to verify correct cache use on kmem_cache_free() Christoph Lameter
2012-08-20 20:50 ` C12 [04/19] Move list_add() to slab_common.c Christoph Lameter
2012-08-20 20:50 ` C12 [03/19] Improve error handling in kmem_cache_create Christoph Lameter
2012-08-20 20:50 ` C12 [05/19] Extract a common function for kmem_cache_destroy Christoph Lameter
2012-08-20 20:50 ` C12 [07/19] Move freeing of kmem_cache structure to common code Christoph Lameter
2012-08-20 20:50 ` C12 [11/19] Move sysfs_slab_add to common Christoph Lameter
2012-08-20 20:50 ` C12 [06/19] Always use the name "kmem_cache" for the slab cache with the kmem_cache structure Christoph Lameter
2012-08-20 20:50 ` C12 [09/19] Move duping of slab name to slab_common.c Christoph Lameter
2012-08-20 20:50 ` C12 [12/19] Move kmem_cache allocations into common code Christoph Lameter
2012-08-21 11:55 ` Glauber Costa
2012-08-21 20:58 ` Christoph Lameter
2012-08-22 8:42 ` Glauber Costa
2012-08-22 15:25 ` Christoph Lameter
2012-08-23 7:43 ` Glauber Costa
2012-08-23 13:49 ` Christoph Lameter
2012-08-23 13:57 ` Glauber Costa [this message]
2012-08-23 14:31 ` Christoph Lameter
2012-08-20 20:50 ` C12 [13/19] Shrink __kmem_cache_create() parameter lists Christoph Lameter
2012-08-20 20:50 ` C12 [10/19] Do slab aliasing call from common code Christoph Lameter
2012-08-20 20:50 ` C12 [08/19] Get rid of __kmem_cache_destroy Christoph Lameter
2012-08-20 20:50 ` C12 [14/19] Move kmem_cache refcounting to common code Christoph Lameter
2012-08-20 20:50 ` C12 [16/19] Create common functions for boot slab creation Christoph Lameter
2012-08-22 9:26 ` Glauber Costa
2012-08-22 15:35 ` Christoph Lameter
2012-08-23 8:09 ` Glauber Costa
2012-08-23 13:58 ` Christoph Lameter
2012-08-20 20:50 ` C12 [17/19] slub: Use a statically allocated kmem_cache boot structure for bootstrap Christoph Lameter
2012-08-20 21:01 ` C12 [18/19] slab: Use the new create_boot_cache function to simplify bootstrap Christoph Lameter
2012-08-20 21:01 ` C12 [15/19] slab: Simplify bootstrap Christoph Lameter
2012-08-20 21:01 ` C12 [19/19] Common alignment code Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=503636CE.20501@parallels.com \
--to=glommer@parallels.com \
--cc=cl@linux.com \
--cc=js1304@gmail.com \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).