* [PATCH 2/3] kmemleak: replace list_for_each_continue_rcu with new interface [not found] <502CB92F.2010700@linux.vnet.ibm.com> @ 2012-08-17 4:33 ` Michael Wang 2012-08-21 0:02 ` Paul E. McKenney 2012-08-24 0:52 ` Michael Wang 0 siblings, 2 replies; 5+ messages in thread From: Michael Wang @ 2012-08-17 4:33 UTC (permalink / raw) To: LKML, linux-mm; +Cc: catalin.marinas, paulmck@linux.vnet.ibm.com From: Michael Wang <wangyun@linux.vnet.ibm.com> This patch replaces list_for_each_continue_rcu() with list_for_each_entry_continue_rcu() to save a few lines of code and allow removing list_for_each_continue_rcu(). Signed-off-by: Michael Wang <wangyun@linux.vnet.ibm.com> --- mm/kmemleak.c | 6 ++---- 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/mm/kmemleak.c b/mm/kmemleak.c index 45eb621..0de83b4 100644 --- a/mm/kmemleak.c +++ b/mm/kmemleak.c @@ -1483,13 +1483,11 @@ static void *kmemleak_seq_next(struct seq_file *seq, void *v, loff_t *pos) { struct kmemleak_object *prev_obj = v; struct kmemleak_object *next_obj = NULL; - struct list_head *n = &prev_obj->object_list; + struct kmemleak_object *obj = prev_obj; ++(*pos); - list_for_each_continue_rcu(n, &object_list) { - struct kmemleak_object *obj = - list_entry(n, struct kmemleak_object, object_list); + list_for_each_entry_continue_rcu(obj, &object_list, object_list) { if (get_object(obj)) { next_obj = obj; break; -- 1.7.4.1 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 2/3] kmemleak: replace list_for_each_continue_rcu with new interface 2012-08-17 4:33 ` [PATCH 2/3] kmemleak: replace list_for_each_continue_rcu with new interface Michael Wang @ 2012-08-21 0:02 ` Paul E. McKenney 2012-08-24 0:52 ` Michael Wang 1 sibling, 0 replies; 5+ messages in thread From: Paul E. McKenney @ 2012-08-21 0:02 UTC (permalink / raw) To: Michael Wang; +Cc: LKML, linux-mm, catalin.marinas On Fri, Aug 17, 2012 at 12:33:34PM +0800, Michael Wang wrote: > From: Michael Wang <wangyun@linux.vnet.ibm.com> > > This patch replaces list_for_each_continue_rcu() with > list_for_each_entry_continue_rcu() to save a few lines > of code and allow removing list_for_each_continue_rcu(). > > Signed-off-by: Michael Wang <wangyun@linux.vnet.ibm.com> Reviewed-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> > --- > mm/kmemleak.c | 6 ++---- > 1 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/mm/kmemleak.c b/mm/kmemleak.c > index 45eb621..0de83b4 100644 > --- a/mm/kmemleak.c > +++ b/mm/kmemleak.c > @@ -1483,13 +1483,11 @@ static void *kmemleak_seq_next(struct seq_file *seq, void *v, loff_t *pos) > { > struct kmemleak_object *prev_obj = v; > struct kmemleak_object *next_obj = NULL; > - struct list_head *n = &prev_obj->object_list; > + struct kmemleak_object *obj = prev_obj; > > ++(*pos); > > - list_for_each_continue_rcu(n, &object_list) { > - struct kmemleak_object *obj = > - list_entry(n, struct kmemleak_object, object_list); > + list_for_each_entry_continue_rcu(obj, &object_list, object_list) { > if (get_object(obj)) { > next_obj = obj; > break; > -- > 1.7.4.1 > > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/3] kmemleak: replace list_for_each_continue_rcu with new interface 2012-08-17 4:33 ` [PATCH 2/3] kmemleak: replace list_for_each_continue_rcu with new interface Michael Wang 2012-08-21 0:02 ` Paul E. McKenney @ 2012-08-24 0:52 ` Michael Wang 2012-08-24 10:05 ` Catalin Marinas 1 sibling, 1 reply; 5+ messages in thread From: Michael Wang @ 2012-08-24 0:52 UTC (permalink / raw) To: LKML, linux-mm; +Cc: catalin.marinas, paulmck@linux.vnet.ibm.com On 08/17/2012 12:33 PM, Michael Wang wrote: > From: Michael Wang <wangyun@linux.vnet.ibm.com> > > This patch replaces list_for_each_continue_rcu() with > list_for_each_entry_continue_rcu() to save a few lines > of code and allow removing list_for_each_continue_rcu(). Hi, Catalin Could I get some comments on this patch? Regards, Michael Wang > > Signed-off-by: Michael Wang <wangyun@linux.vnet.ibm.com> > --- > mm/kmemleak.c | 6 ++---- > 1 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/mm/kmemleak.c b/mm/kmemleak.c > index 45eb621..0de83b4 100644 > --- a/mm/kmemleak.c > +++ b/mm/kmemleak.c > @@ -1483,13 +1483,11 @@ static void *kmemleak_seq_next(struct seq_file *seq, void *v, loff_t *pos) > { > struct kmemleak_object *prev_obj = v; > struct kmemleak_object *next_obj = NULL; > - struct list_head *n = &prev_obj->object_list; > + struct kmemleak_object *obj = prev_obj; > > ++(*pos); > > - list_for_each_continue_rcu(n, &object_list) { > - struct kmemleak_object *obj = > - list_entry(n, struct kmemleak_object, object_list); > + list_for_each_entry_continue_rcu(obj, &object_list, object_list) { > if (get_object(obj)) { > next_obj = obj; > break; > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/3] kmemleak: replace list_for_each_continue_rcu with new interface 2012-08-24 0:52 ` Michael Wang @ 2012-08-24 10:05 ` Catalin Marinas 2012-08-24 19:53 ` Paul E. McKenney 0 siblings, 1 reply; 5+ messages in thread From: Catalin Marinas @ 2012-08-24 10:05 UTC (permalink / raw) To: Michael Wang; +Cc: LKML, linux-mm@kvack.org, paulmck@linux.vnet.ibm.com On Fri, Aug 24, 2012 at 01:52:50AM +0100, Michael Wang wrote: > On 08/17/2012 12:33 PM, Michael Wang wrote: > > From: Michael Wang <wangyun@linux.vnet.ibm.com> > > > > This patch replaces list_for_each_continue_rcu() with > > list_for_each_entry_continue_rcu() to save a few lines > > of code and allow removing list_for_each_continue_rcu(). > > Could I get some comments on this patch? Sorry, busy with other things and forgot about this. Acked-by: Catalin Marinas <catalin.marinas@arm.com> -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/3] kmemleak: replace list_for_each_continue_rcu with new interface 2012-08-24 10:05 ` Catalin Marinas @ 2012-08-24 19:53 ` Paul E. McKenney 0 siblings, 0 replies; 5+ messages in thread From: Paul E. McKenney @ 2012-08-24 19:53 UTC (permalink / raw) To: Catalin Marinas; +Cc: Michael Wang, LKML, linux-mm@kvack.org On Fri, Aug 24, 2012 at 11:05:05AM +0100, Catalin Marinas wrote: > On Fri, Aug 24, 2012 at 01:52:50AM +0100, Michael Wang wrote: > > On 08/17/2012 12:33 PM, Michael Wang wrote: > > > From: Michael Wang <wangyun@linux.vnet.ibm.com> > > > > > > This patch replaces list_for_each_continue_rcu() with > > > list_for_each_entry_continue_rcu() to save a few lines > > > of code and allow removing list_for_each_continue_rcu(). > > > > Could I get some comments on this patch? > > Sorry, busy with other things and forgot about this. > > Acked-by: Catalin Marinas <catalin.marinas@arm.com> Queued, thank you both! Thanx, Paul -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-08-24 19:54 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <502CB92F.2010700@linux.vnet.ibm.com>
2012-08-17 4:33 ` [PATCH 2/3] kmemleak: replace list_for_each_continue_rcu with new interface Michael Wang
2012-08-21 0:02 ` Paul E. McKenney
2012-08-24 0:52 ` Michael Wang
2012-08-24 10:05 ` Catalin Marinas
2012-08-24 19:53 ` Paul E. McKenney
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).