Linux-mm Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Vlastimil Babka (SUSE)" <vbabka@kernel.org>
To: Harry Yoo <harry@kernel.org>, Andrew Morton <akpm@linux-foundation.org>
Cc: Hao Li <hao.li@linux.dev>, Uladzislau Rezki <urezki@gmail.com>,
	Christoph Lameter <cl@gentwo.org>,
	David Rientjes <rientjes@google.com>,
	Roman Gushchin <roman.gushchin@linux.dev>,
	linux-mm@kvack.org, rcu@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/slab: stop exporting kvfree_rcu_barrier[_on_cache]()
Date: Mon, 3 Aug 2026 10:01:42 +0200	[thread overview]
Message-ID: <50432ae2-1d2e-4f76-aea4-28b16874f472@kernel.org> (raw)
In-Reply-To: <20260730-unexport-barriers-v1-1-852f6641abe9@kernel.org>

On 7/30/26 16:32, Vlastimil Babka (SUSE) wrote:
> No module code calls these functions directly. Seems it was always the
> case. Remove the exports.
> 
> Signed-off-by: Vlastimil Babka (SUSE) <vbabka@kernel.org>
> ---
> Based on slab/for-7.3/kfree_rcu_nolock

Applied to that branch and slab/for-next

> ---
>  mm/slab_common.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/mm/slab_common.c b/mm/slab_common.c
> index 6750dfa27367..cd155ffc2762 100644
> --- a/mm/slab_common.c
> +++ b/mm/slab_common.c
> @@ -1329,14 +1329,12 @@ void kvfree_rcu_barrier(void)
>  	deferred_work_barrier();
>  	rcu_barrier();
>  }
> -EXPORT_SYMBOL_GPL(kvfree_rcu_barrier);
>  
>  void kvfree_rcu_barrier_on_cache(struct kmem_cache *s)
>  {
>  	deferred_work_barrier();
>  	rcu_barrier();
>  }
> -EXPORT_SYMBOL_GPL(kvfree_rcu_barrier_on_cache);
>  
>  void __init kvfree_rcu_init(void)
>  {
> @@ -2163,7 +2161,6 @@ void kvfree_rcu_barrier(void)
>  	flush_all_rcu_sheaves();
>  	__kvfree_rcu_barrier();
>  }
> -EXPORT_SYMBOL_GPL(kvfree_rcu_barrier);
>  
>  /**
>   * kvfree_rcu_barrier_on_cache - Wait for in-flight kvfree_rcu() calls on a
> @@ -2186,7 +2183,6 @@ void kvfree_rcu_barrier_on_cache(struct kmem_cache *s)
>  	rcu_barrier();
>  	__kvfree_rcu_barrier();
>  }
> -EXPORT_SYMBOL_GPL(kvfree_rcu_barrier_on_cache);
>  
>  static unsigned long
>  kfree_rcu_shrink_count(struct shrinker *shrink, struct shrink_control *sc)
> 
> ---
> base-commit: b01f6ed9ff0c4581fc669044fa5b82a93b4ef144
> change-id: 20260730-unexport-barriers-439b3f69f791
> 



      parent reply	other threads:[~2026-08-03  8:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-30 14:32 [PATCH] mm/slab: stop exporting kvfree_rcu_barrier[_on_cache]() Vlastimil Babka (SUSE)
2026-07-30 20:59 ` Paul E. McKenney
2026-08-03  7:59   ` Vlastimil Babka (SUSE)
2026-08-03 12:26     ` Harry Yoo
2026-08-03 15:37       ` Paul E. McKenney
2026-08-01 12:51 ` Harry Yoo
2026-08-03  8:01 ` Vlastimil Babka (SUSE) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50432ae2-1d2e-4f76-aea4-28b16874f472@kernel.org \
    --to=vbabka@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=cl@gentwo.org \
    --cc=hao.li@linux.dev \
    --cc=harry@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=rcu@vger.kernel.org \
    --cc=rientjes@google.com \
    --cc=roman.gushchin@linux.dev \
    --cc=urezki@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox