From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx142.postini.com [74.125.245.142]) by kanga.kvack.org (Postfix) with SMTP id 235BC6B0044 for ; Thu, 27 Sep 2012 08:44:23 -0400 (EDT) Received: by oagk14 with SMTP id k14so2208483oag.14 for ; Thu, 27 Sep 2012 05:44:22 -0700 (PDT) Message-ID: <50644A1B.3070108@gmail.com> Date: Thu, 27 Sep 2012 20:44:11 +0800 From: Ni zhan Chen MIME-Version: 1.0 Subject: Re: [PATCH 4/4] memory-hotplug: auto offline page_cgroup when onlining memory block failed References: <1348724705-23779-1-git-send-email-wency@cn.fujitsu.com> <1348724705-23779-5-git-send-email-wency@cn.fujitsu.com> In-Reply-To: <1348724705-23779-5-git-send-email-wency@cn.fujitsu.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: wency@cn.fujitsu.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, rientjes@google.com, liuj97@gmail.com, len.brown@intel.com, benh@kernel.crashing.org, paulus@samba.org, minchan.kim@gmail.com, akpm@linux-foundation.org, kosaki.motohiro@jp.fujitsu.com, isimatu.yasuaki@jp.fujitsu.com On 09/27/2012 01:45 PM, wency@cn.fujitsu.com wrote: > From: Wen Congyang > > When a memory block is onlined, we will try allocate memory on that node > to store page_cgroup. If onlining the memory block failed, we don't > offline the page cgroup, and we have no chance to offline this page cgroup > unless the memory block is onlined successfully again. It will cause > that we can't hot-remove the memory device on that node, because some > memory is used to store page cgroup. If onlining the memory block > is failed, there is no need to stort page cgroup for this memory. So > auto offline page_cgroup when onlining memory block failed. looks reasonable to me. thanks. > > CC: David Rientjes > CC: Jiang Liu > CC: Len Brown > CC: Benjamin Herrenschmidt > CC: Paul Mackerras > Cc: Minchan Kim > CC: Andrew Morton > CC: KOSAKI Motohiro > CC: Yasuaki Ishimatsu > Signed-off-by: Wen Congyang > --- > mm/page_cgroup.c | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/mm/page_cgroup.c b/mm/page_cgroup.c > index 5ddad0c..44db00e 100644 > --- a/mm/page_cgroup.c > +++ b/mm/page_cgroup.c > @@ -251,6 +251,9 @@ static int __meminit page_cgroup_callback(struct notifier_block *self, > mn->nr_pages, mn->status_change_nid); > break; > case MEM_CANCEL_ONLINE: > + offline_page_cgroup(mn->start_pfn, > + mn->nr_pages, mn->status_change_nid); > + break; > case MEM_GOING_OFFLINE: > break; > case MEM_ONLINE: -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org