From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx185.postini.com [74.125.245.185]) by kanga.kvack.org (Postfix) with SMTP id 970A86B005D for ; Mon, 1 Oct 2012 04:02:19 -0400 (EDT) Message-ID: <50694D3C.8000603@parallels.com> Date: Mon, 1 Oct 2012 11:58:52 +0400 From: Glauber Costa MIME-Version: 1.0 Subject: Re: [PATCH] slab: Ignore internal flags in cache creation References: <1348571866-31738-1-git-send-email-glommer@parallels.com> <00000139fe408877-40bc98e3-322c-4ba2-be72-e298ff28e694-000000@email.amazonses.com> <5062C029.308@parallels.com> <5063F94C.4090600@parallels.com> <0000013a0d390e11-03bf6f97-a8b7-4229-9f69-84aa85795b7e-000000@email.amazonses.com> In-Reply-To: Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Pekka Enberg Cc: David Rientjes , Christoph Lameter , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Michal Hocko On 10/01/2012 11:28 AM, Pekka Enberg wrote: > Hello, > > [ Found this in my @cs.helsinki.fi inbox, grmbl. ] > > On Fri, Sep 28, 2012 at 11:39 PM, David Rientjes wrote: >> The first prototype, SLAM XP1, will be posted in October. I'd simply like >> to avoid reverting this patch down the road and having all of us >> reconsider the topic again when clear alternatives exist that, in my >> opinion, make the code cleaner. > > David, I'm sure you know we don't work speculatively against > out-of-tree code that may or may not be include in the future... > > That said, I don't like Glauber's patch because it leaves CREATE_MASK > in mm/slab.c. And I'm not totally convinced a generic SLAB_INTERNAL is > going to cut it either. Hmm. > > Pekka > How about we require allocators to define their own CREATE_MASK, and then in slab_common.c we mask out any flags outside that mask? This way we can achieve masking in common code while still leaving the decision to the allocators. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org