From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx142.postini.com [74.125.245.142]) by kanga.kvack.org (Postfix) with SMTP id 6F1FD6B009F for ; Wed, 3 Oct 2012 19:11:13 -0400 (EDT) Received: by padfa10 with SMTP id fa10so7986895pad.14 for ; Wed, 03 Oct 2012 16:11:12 -0700 (PDT) Message-ID: <506CC607.8060703@gmail.com> Date: Thu, 04 Oct 2012 07:11:03 +0800 From: Ni zhan Chen MIME-Version: 1.0 Subject: Re: [PATCH] CPU hotplug, writeback: Don't call writeback_set_ratelimit() too often during hotplug References: <20120924102324.GA22303@aftab.osrc.amd.com> <20120924142305.GD12264@quack.suse.cz> <20120924143609.GH22303@aftab.osrc.amd.com> <20120924201650.6574af64.conny.seidel@amd.com> <20120924181927.GA25762@aftab.osrc.amd.com> <5060AB0E.3070809@linux.vnet.ibm.com> <5060C714.8030606@linux.vnet.ibm.com> <20120928122719.GA3067@localhost> In-Reply-To: <20120928122719.GA3067@localhost> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Fengguang Wu Cc: "Srivatsa S. Bhat" , Borislav Petkov , Conny Seidel , Jan Kara , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Peter Zijlstra , Andrew Morton , Johannes Weiner , "Paul E. McKenney" , Thomas Gleixner On 09/28/2012 08:27 PM, Fengguang Wu wrote: > On Tue, Sep 25, 2012 at 02:18:20AM +0530, Srivatsa S. Bhat wrote: >> From: Srivatsa S. Bhat >> >> The CPU hotplug callback related to writeback calls writeback_set_ratelimit() >> during every state change in the hotplug sequence. This is unnecessary >> since num_online_cpus() changes only once during the entire hotplug operation. >> >> So invoke the function only once per hotplug, thereby avoiding the >> unnecessary repetition of those costly calculations. >> >> Signed-off-by: Srivatsa S. Bhat >> --- > Looks good to me. I'll include it in the writeback tree. Hi Fengguang, Could you tell me when inode->i_state & I_DIRTY will be set? thanks. Regards, Chen > > Thanks, > Fengguang > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: email@kvack.org > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org