Re: [PATCH] mm: use standard page table accessors

Ryan Roberts
2025-11-26T10:19:17Z

+ Anshuman

On 26/11/2025 09:09, David Hildenbrand (Red Hat) wrote:
> On 11/26/25 07:47, Wei Yang wrote:
>> Use standard page table accessors i.e pxdp_get() to get the value of
>> pxdp.
>>
>
> Isn't this covered by
>
> https://lkml.kernel.org/r/20251113014656.2605447-1-samuel.holland@sifive.com
>
> In particular
>
> https://lkml.kernel.org/r/20251113014656.2605447-7-samuel.holland@sifive.com
>
> ?

Ahh this is very interesting - I wasn't aware of this new attempt! We could
benefit from this on arm64 too.

We have some experience and opinions about this; I'll reply to the patch with
some details...

But as for this patch, I don't see the value in changing just a few instances.
I'd prefer to see it converted systematically, taking into consideration all the
complexities.

Thanks,
Ryan