From: Wen Congyang <wency@cn.fujitsu.com>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
Cc: x86@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org,
linux-acpi@vger.kernel.org, rientjes@google.com,
liuj97@gmail.com, len.brown@intel.com, cl@linux.com,
minchan.kim@gmail.com, akpm@linux-foundation.org
Subject: Re: [PATCH 1/4] acpi,memory-hotplug : add memory offline code to acpi_memory_device_remove()
Date: Wed, 17 Oct 2012 17:52:02 +0800 [thread overview]
Message-ID: <507E7FC2.8@cn.fujitsu.com> (raw)
In-Reply-To: <CAHGf_=oNufcAQhxWtvq56qwF==+14+Cm7r9eiTGdY=B=ENwPQg@mail.gmail.com>
At 10/17/2012 05:18 PM, KOSAKI Motohiro Wrote:
>>>>>> Hmm, it doesn't move the code. It just reuse the code in acpi_memory_powerdown_device().
>>>>>
>>>>> Even if reuse or not reuse, you changed the behavior. If any changes
>>>>> has no good rational, you cannot get an ack.
>>>>
>>>> I don't understand this? IIRC, the behavior isn't changed.
>>>
>>> Heh, please explain why do you think so.
>>
>> We just introduce a function, and move codes from acpi_memory_disable_device() to the new
>> function. We call the new function in acpi_memory_disable_device(), so the function
>> acpi_memory_disable_device()'s behavior isn't changed.
>>
>> Maybe I don't understand what do you want to say.
>
> Ok, now you agreed you moved the code, yes? So then, you should explain why
> your code moving makes zero impact other acpi_memory_disable_device() caller.
We just move the code, and don't change the acpi_memory_disable_device()'s behavior.
I look it the change again, and found some diffs:
1. we treat !info->enabled as error, while it isn't a error without this patch
2. we remove memory info from the list, it is a bug fix because we free the memory
that stores memory info.(I have sent a patch to fix this bug, and it is in akpm's tree now)
I guess you mean 1 will change the behavior. In the last version, I don't do it.
Ishimatsu changes this and I don't notify this.
To Ishimatsu:
Why do you change this?
Thanks
Wen Congyang
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-10-17 10:47 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-03 9:52 [PATCH 0/4] acpi,memory-hotplug : implement framework for hot removing memory Yasuaki Ishimatsu
2012-10-03 9:58 ` [PATCH 1/4] acpi,memory-hotplug : add memory offline code to acpi_memory_device_remove() Yasuaki Ishimatsu
2012-10-04 20:53 ` KOSAKI Motohiro
2012-10-08 6:58 ` Wen Congyang
2012-10-12 19:10 ` KOSAKI Motohiro
2012-10-17 6:48 ` Wen Congyang
2012-10-17 8:59 ` KOSAKI Motohiro
2012-10-17 9:08 ` Wen Congyang
2012-10-17 9:18 ` KOSAKI Motohiro
2012-10-17 9:52 ` Wen Congyang [this message]
2012-10-18 1:25 ` Yasuaki Ishimatsu
2012-10-19 7:35 ` Wen Congyang
2012-10-17 9:18 ` Wen Congyang
2012-10-18 19:44 ` KOSAKI Motohiro
2012-10-19 9:08 ` Wen Congyang
2012-10-19 18:19 ` KOSAKI Motohiro
2012-10-20 5:02 ` Wen Congyang
2012-10-22 15:11 ` KOSAKI Motohiro
2012-10-22 15:34 ` KOSAKI Motohiro
2012-10-03 10:02 ` [PATCH 2/4] acpi,memory-hotplug : rename remove_memory() to offline_memory() Yasuaki Ishimatsu
2012-10-04 21:31 ` KOSAKI Motohiro
2012-10-08 6:45 ` Wen Congyang
2012-10-12 18:57 ` KOSAKI Motohiro
2012-10-03 10:09 ` [PATCH 3/6] acpi,memory-hotplug : add physical memory hotplug code to acpi_memhotplug.c Yasuaki Ishimatsu
2012-10-05 18:54 ` KOSAKI Motohiro
2012-10-03 10:11 ` [PATCH 4/4] acpi,memory-hotplug : store the node id in acpi_memory_device Yasuaki Ishimatsu
2012-10-05 18:56 ` KOSAKI Motohiro
2012-10-08 6:47 ` Wen Congyang
2012-10-12 18:59 ` KOSAKI Motohiro
2012-10-06 14:22 ` [PATCH 0/4] acpi,memory-hotplug : implement framework for hot removing memory Ni zhan Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=507E7FC2.8@cn.fujitsu.com \
--to=wency@cn.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liuj97@gmail.com \
--cc=minchan.kim@gmail.com \
--cc=rientjes@google.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).