From: Glauber Costa <glommer@parallels.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, cgroups@vger.kernel.org,
Mel Gorman <mgorman@suse.de>, Tejun Heo <tj@kernel.org>,
Michal Hocko <mhocko@suse.cz>,
Johannes Weiner <hannes@cmpxchg.org>,
kamezawa.hiroyu@jp.fujitsu.com, Christoph Lameter <cl@linux.com>,
David Rientjes <rientjes@google.com>,
Pekka Enberg <penberg@kernel.org>,
devel@openvz.org, linux-kernel@vger.kernel.org,
Pekka Enberg <penberg@cs.helsinki.fi>,
Suleiman Souhlal <suleiman@google.com>
Subject: Re: [PATCH v5 11/14] memcg: allow a memcg with kmem charges to be destructed.
Date: Thu, 18 Oct 2012 13:33:54 +0400 [thread overview]
Message-ID: <507FCD02.106@parallels.com> (raw)
In-Reply-To: <20121017151235.1e5d6f21.akpm@linux-foundation.org>
On 10/18/2012 02:12 AM, Andrew Morton wrote:
> On Tue, 16 Oct 2012 14:16:48 +0400
> Glauber Costa <glommer@parallels.com> wrote:
>
>> Because the ultimate goal of the kmem tracking in memcg is to track slab
>> pages as well,
>
> It is? For a major patchset such as this, it's pretty important to
> discuss such long-term plans in the top-level discussion. Covering
> things such as expected complexity, expected performance hit, how these
> plans affected the current implementation, etc.
>
> The main reason for this is that if the future plans appear to be of
> doubtful feasibility and the current implementation isn't sufficiently
> useful without the future stuff, we shouldn't merge the current
> implementation. It's a big issue!
>
Not really. I am not talking about plans when it comes to slab. The code
is there, and usually always posted to linux-mm a few days after I post
this series. It also lives in the kmemcg-slab branch in my git tree.
I am trying to logically split it in two to aid reviewers work. I may
have made a mistake by splitting it this way, but so far I think it was
the right decision: it allowed people to focus on a part of the work
first, instead of going all the way in a 30-patch patch series that
would be merged atomically.
I believe they should be merged separately, to allow us to find any
issues easier. But I also believe that this "separate" should ultimately
live in the same merge window.
Pekka, from the slab side, already stated that 3.8 would not be
unreasonable.
As for the perfomance hit, my latest benchmark, quoted in the opening
mail of this series already include results for both patchsets.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-10-18 9:34 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-16 10:16 [PATCH v5 00/14] kmem controller for memcg Glauber Costa
2012-10-16 10:16 ` [PATCH v5 01/14] memcg: Make it possible to use the stock for more than one page Glauber Costa
2012-10-17 22:11 ` Andrew Morton
2012-10-18 16:54 ` Glauber Costa
2012-10-16 10:16 ` [PATCH v5 02/14] memcg: Reclaim when more than one page needed Glauber Costa
2012-10-17 21:46 ` David Rientjes
2012-10-16 10:16 ` [PATCH v5 03/14] memcg: change defines to an enum Glauber Costa
2012-10-17 21:50 ` David Rientjes
2012-10-16 10:16 ` [PATCH v5 04/14] kmem accounting basic infrastructure Glauber Costa
2012-10-16 12:14 ` Michal Hocko
2012-10-17 22:08 ` David Rientjes
2012-10-18 17:01 ` Glauber Costa
2012-10-18 19:47 ` Tejun Heo
2012-10-18 19:37 ` Tejun Heo
2012-10-17 22:12 ` Andrew Morton
2012-10-18 17:03 ` Glauber Costa
2012-10-16 10:16 ` [PATCH v5 05/14] Add a __GFP_KMEMCG flag Glauber Costa
2012-10-16 12:15 ` Michal Hocko
2012-10-17 22:09 ` David Rientjes
2012-10-16 10:16 ` [PATCH v5 06/14] memcg: kmem controller infrastructure Glauber Costa
2012-10-17 6:40 ` Kamezawa Hiroyuki
2012-10-17 22:12 ` Andrew Morton
2012-10-18 9:16 ` Glauber Costa
2012-10-18 22:06 ` David Rientjes
2012-10-19 9:10 ` Glauber Costa
2012-10-19 9:31 ` David Rientjes
2012-10-19 10:00 ` Glauber Costa
2012-10-17 22:37 ` David Rientjes
2012-10-18 9:23 ` Glauber Costa
2012-10-18 21:59 ` David Rientjes
2012-10-19 10:08 ` Glauber Costa
2012-10-19 20:34 ` David Rientjes
2012-10-22 12:34 ` Glauber Costa
2012-10-22 12:51 ` Michal Hocko
2012-10-22 12:52 ` Glauber Costa
2012-10-16 10:16 ` [PATCH v5 07/14] mm: Allocate kernel pages to the right memcg Glauber Costa
2012-10-16 15:31 ` Christoph Lameter
2012-10-16 18:55 ` Glauber Costa
2012-10-17 22:12 ` Andrew Morton
2012-10-18 9:24 ` Glauber Costa
2012-10-18 20:44 ` Andrew Morton
2012-10-18 11:53 ` Glauber Costa
2012-10-17 22:43 ` David Rientjes
2012-10-16 10:16 ` [PATCH v5 08/14] res_counter: return amount of charges after res_counter_uncharge Glauber Costa
2012-10-17 23:23 ` David Rientjes
2012-10-16 10:16 ` [PATCH v5 09/14] memcg: kmem accounting lifecycle management Glauber Costa
2012-10-17 23:28 ` David Rientjes
2012-10-18 6:14 ` Michal Hocko
2012-10-18 9:42 ` Glauber Costa
2012-10-16 10:16 ` [PATCH v5 10/14] memcg: use static branches when code not in use Glauber Costa
2012-10-16 10:16 ` [PATCH v5 11/14] memcg: allow a memcg with kmem charges to be destructed Glauber Costa
2012-10-17 22:12 ` Andrew Morton
2012-10-18 9:33 ` Glauber Costa [this message]
2012-10-16 10:16 ` [PATCH v5 12/14] execute the whole memcg freeing in free_worker Glauber Costa
2012-10-17 6:56 ` Kamezawa Hiroyuki
2012-10-16 10:16 ` [PATCH v5 13/14] protect architectures where THREAD_SIZE >= PAGE_SIZE against fork bombs Glauber Costa
2012-10-17 22:12 ` Andrew Morton
2012-10-18 9:37 ` Glauber Costa
2012-10-16 10:16 ` [PATCH v5 14/14] Add documentation about the kmem controller Glauber Costa
2012-10-16 12:23 ` Michal Hocko
2012-10-16 18:25 ` Christoph Lameter
2012-10-16 18:55 ` Aristeu Rozanski
2012-10-16 19:02 ` Glauber Costa
2012-10-16 19:30 ` Christoph Lameter
2012-10-17 22:12 ` Andrew Morton
2012-10-18 9:38 ` Glauber Costa
2012-10-17 22:11 ` [PATCH v5 00/14] kmem controller for memcg Andrew Morton
2012-10-18 16:51 ` Glauber Costa
2012-10-18 19:21 ` Andrew Morton
2012-10-19 9:55 ` Glauber Costa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=507FCD02.106@parallels.com \
--to=glommer@parallels.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=cl@linux.com \
--cc=devel@openvz.org \
--cc=hannes@cmpxchg.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@suse.cz \
--cc=penberg@cs.helsinki.fi \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=suleiman@google.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).