From: Glauber Costa <glommer@parallels.com>
To: Ezequiel Garcia <elezegarcia@gmail.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Tim Bird <tim.bird@am.sony.com>,
Christoph Lameter <cl@linux-foundation.org>,
Pekka Enberg <penberg@kernel.org>, Matt Mackall <mpm@selenic.com>
Subject: Re: [PATCH 2/2] mm/slob: Use free_page instead of put_page for page-size kmalloc allocations
Date: Mon, 22 Oct 2012 16:07:43 +0400 [thread overview]
Message-ID: <5085370F.80204@parallels.com> (raw)
In-Reply-To: <1350907471-2236-1-git-send-email-elezegarcia@gmail.com>
On 10/22/2012 04:04 PM, Ezequiel Garcia wrote:
> When freeing objects, the slob allocator currently free empty pages
> calling __free_pages(). However, page-size kmallocs are disposed
> using put_page() instead.
>
> It makes no sense to call put_page() for kernel pages that are provided
> by the object allocator, so we shouldn't be doing this ourselves.
>
> This is based on:
> commit d9b7f22623b5fa9cc189581dcdfb2ac605933bf4
> Author: Glauber Costa <glommer@parallels.com>
Acked-by: Glauber Costa <glommer@parallels.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-10-22 12:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-22 12:04 [PATCH 2/2] mm/slob: Use free_page instead of put_page for page-size kmalloc allocations Ezequiel Garcia
2012-10-22 12:07 ` Glauber Costa [this message]
2012-10-31 6:56 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5085370F.80204@parallels.com \
--to=glommer@parallels.com \
--cc=cl@linux-foundation.org \
--cc=elezegarcia@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mpm@selenic.com \
--cc=penberg@kernel.org \
--cc=tim.bird@am.sony.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).