From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx185.postini.com [74.125.245.185]) by kanga.kvack.org (Postfix) with SMTP id AB2B66B006E for ; Mon, 29 Oct 2012 11:20:48 -0400 (EDT) Message-ID: <508E9F5B.5010402@redhat.com> Date: Mon, 29 Oct 2012 11:23:07 -0400 From: Rik van Riel MIME-Version: 1.0 Subject: Re: [PATCH 1/3] x86/mm: only do a local TLB flush in ptep_set_access_flags() References: <20121025121617.617683848@chello.nl> <20121025124832.840241082@chello.nl> <5089F5B5.1050206@redhat.com> <508A0A0D.4090001@redhat.com> <508A8D31.9000106@redhat.com> <20121026132601.GC9886@gmail.com> <20121026144419.7e666023@dull> <508AE1A3.6030607@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Linus Torvalds Cc: Ingo Molnar , Andi Kleen , Michel Lespinasse , Peter Zijlstra , Andrea Arcangeli , Mel Gorman , Johannes Weiner , Thomas Gleixner , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org On 10/26/2012 03:18 PM, Linus Torvalds wrote: > On Fri, Oct 26, 2012 at 12:16 PM, Rik van Riel wrote: >> >> I can change the text of the changelog, however it looks >> like do_wp_page does actually use ptep_set_access_flags >> to set the write bit in the pte... >> >> I guess both need to be reflected in the changelog text >> somehow? > > Yeah, and by now, after all this discussion, I suspect it should be > committed with a comment too. Commit messages are good and all, but > unless chasing a particular bug they introduced, we shouldn't expect > people to read them for background information. Now that we have the TLB things taken care of, and comments to patches 10/31 and 26/31 have been addressed, is there anything else that needs to be done before these NUMA patches can be merged? Anyone, this is a good time to speak up. We have some time to address whatever concern you may have. (besides waiting for the next merge window) -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org