From: Wen Congyang <wency@cn.fujitsu.com>
To: Wen Congyang <wency@cn.fujitsu.com>
Cc: linux-mm@kvack.org, lkml <linux-kernel@vger.kernel.org>,
Jiang Liu <liuj97@gmail.com>, Len Brown <len.brown@intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Yasuaki ISIMATU <isimatu.yasuaki@jp.fujitsu.com>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
lai jiangshan <laijs@cn.fujitsu.com>
Subject: Re: [PATCH v2] memory-hotplug: fix NR_FREE_PAGES mismatch's fix
Date: Thu, 08 Nov 2012 17:22:35 +0800 [thread overview]
Message-ID: <509B79DB.1010208@cn.fujitsu.com> (raw)
In-Reply-To: <509B75FF.6070806@cn.fujitsu.com>
At 11/08/2012 05:06 PM, Wen Congyang Wrote:
>
> When a page is freed and put into pcp list, get_freepage_migratetype()
> doesn't return MIGRATE_ISOLATE even if this pageblock is isolated.
> So we should use get_freepage_migratetype() instead of mt to check
> whether it is isolated.
In my local tree, there are some patches from isimatu, so I don't add
-s option when generating the patch. So I forgot to add:
Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
Reported-by: Jianguo Wu <wujianguo106@gmail.com>
> ---
> mm/page_alloc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index 027afd0..795875f 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -667,7 +667,7 @@ static void free_pcppages_bulk(struct zone *zone, int count,
> /* MIGRATE_MOVABLE list may include MIGRATE_RESERVEs */
> __free_one_page(page, zone, 0, mt);
> trace_mm_page_pcpu_drain(page, 0, mt);
> - if (likely(mt != MIGRATE_ISOLATE)) {
> + if (likely(get_pageblock_migratetype(page) != MIGRATE_ISOLATE)) {
> __mod_zone_page_state(zone, NR_FREE_PAGES, 1);
> if (is_migrate_cma(mt))
> __mod_zone_page_state(zone, NR_FREE_CMA_PAGES, 1);
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2012-11-08 9:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-08 9:06 [PATCH v2] memory-hotplug: fix NR_FREE_PAGES mismatch's fix Wen Congyang
2012-11-08 9:22 ` Wen Congyang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=509B79DB.1010208@cn.fujitsu.com \
--to=wency@cn.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=laijs@cn.fujitsu.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liuj97@gmail.com \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).