* [PATCH v2] memory-hotplug: fix NR_FREE_PAGES mismatch's fix
@ 2012-11-08 9:06 Wen Congyang
2012-11-08 9:22 ` Wen Congyang
0 siblings, 1 reply; 2+ messages in thread
From: Wen Congyang @ 2012-11-08 9:06 UTC (permalink / raw)
To: linux-mm, lkml
Cc: Jiang Liu, Len Brown, Andrew Morton, KOSAKI Motohiro,
Yasuaki ISIMATU, Rafael J. Wysocki, lai jiangshan, Wen congyang
When a page is freed and put into pcp list, get_freepage_migratetype()
doesn't return MIGRATE_ISOLATE even if this pageblock is isolated.
So we should use get_freepage_migratetype() instead of mt to check
whether it is isolated.
---
mm/page_alloc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 027afd0..795875f 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -667,7 +667,7 @@ static void free_pcppages_bulk(struct zone *zone, int count,
/* MIGRATE_MOVABLE list may include MIGRATE_RESERVEs */
__free_one_page(page, zone, 0, mt);
trace_mm_page_pcpu_drain(page, 0, mt);
- if (likely(mt != MIGRATE_ISOLATE)) {
+ if (likely(get_pageblock_migratetype(page) != MIGRATE_ISOLATE)) {
__mod_zone_page_state(zone, NR_FREE_PAGES, 1);
if (is_migrate_cma(mt))
__mod_zone_page_state(zone, NR_FREE_CMA_PAGES, 1);
--
1.8.0
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] memory-hotplug: fix NR_FREE_PAGES mismatch's fix
2012-11-08 9:06 [PATCH v2] memory-hotplug: fix NR_FREE_PAGES mismatch's fix Wen Congyang
@ 2012-11-08 9:22 ` Wen Congyang
0 siblings, 0 replies; 2+ messages in thread
From: Wen Congyang @ 2012-11-08 9:22 UTC (permalink / raw)
To: Wen Congyang
Cc: linux-mm, lkml, Jiang Liu, Len Brown, Andrew Morton,
KOSAKI Motohiro, Yasuaki ISIMATU, Rafael J. Wysocki,
lai jiangshan
At 11/08/2012 05:06 PM, Wen Congyang Wrote:
>
> When a page is freed and put into pcp list, get_freepage_migratetype()
> doesn't return MIGRATE_ISOLATE even if this pageblock is isolated.
> So we should use get_freepage_migratetype() instead of mt to check
> whether it is isolated.
In my local tree, there are some patches from isimatu, so I don't add
-s option when generating the patch. So I forgot to add:
Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
Reported-by: Jianguo Wu <wujianguo106@gmail.com>
> ---
> mm/page_alloc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index 027afd0..795875f 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -667,7 +667,7 @@ static void free_pcppages_bulk(struct zone *zone, int count,
> /* MIGRATE_MOVABLE list may include MIGRATE_RESERVEs */
> __free_one_page(page, zone, 0, mt);
> trace_mm_page_pcpu_drain(page, 0, mt);
> - if (likely(mt != MIGRATE_ISOLATE)) {
> + if (likely(get_pageblock_migratetype(page) != MIGRATE_ISOLATE)) {
> __mod_zone_page_state(zone, NR_FREE_PAGES, 1);
> if (is_migrate_cma(mt))
> __mod_zone_page_state(zone, NR_FREE_CMA_PAGES, 1);
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-11-08 9:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-08 9:06 [PATCH v2] memory-hotplug: fix NR_FREE_PAGES mismatch's fix Wen Congyang
2012-11-08 9:22 ` Wen Congyang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).