From: Dave Young <dyoung@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Andi Kleen <andi@firstfloor.org>,
linux-mm@kvack.org, Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH] Add a test program for variable page sizes in mmap/shmget v2
Date: Mon, 12 Nov 2012 17:35:46 +0800 [thread overview]
Message-ID: <50A0C2F2.6060100@redhat.com> (raw)
In-Reply-To: <20121108132946.c2b9e8b7.akpm@linux-foundation.org>
On 11/09/2012 05:29 AM, Andrew Morton wrote:
> On Thu, 8 Nov 2012 13:01:26 -0800
> Andi Kleen <andi@firstfloor.org> wrote:
>
>> From: Andi Kleen <ak@linux.intel.com>
>>
>> Not hooked up to the harness so far, because it usually needs
>> special boot options for 1GB pages.
>
> This isn't the case from my reading: we *can* hook it up now?
>
>> index b336b24..7300d07 100644
>> --- a/tools/testing/selftests/vm/Makefile
>> +++ b/tools/testing/selftests/vm/Makefile
>> @@ -1,9 +1,9 @@
>> # Makefile for vm selftests
>>
>> CC = $(CROSS_COMPILE)gcc
>> -CFLAGS = -Wall -Wextra
>> +CFLAGS = -Wall
>
> Why this? It doesn't change anything with my gcc so I think
> I'll revert that.
>
>>
>> ...
>>
>
> Also...
>
> I just tried a `make run_vmtests' and it fell on its face.
> There's a little comment in there saying "please run as root", but we
> don't *want* that. The selftests should be runnable as non-root and
> should, where unavoidable, emit a warning and proceed if elevated
> permissions are required.
Hi andrew:
below code need root, I agree warning in case non-root is good, If you
like I can fix it.
echo $(( $lackpgs + $nr_hugepgs )) > /proc/sys/vm/nr_hugepages
>
> I tried running it as root and my workstation hung, requiring a reboot.
> Won't be doing that again.
>
> Dave, could you please have a dig at this sometime?
I can not reproduce the hang, will keep an eye on this.
--
Thanks
Dave
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2012-11-12 9:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-08 21:01 [PATCH] Add a test program for variable page sizes in mmap/shmget v2 Andi Kleen
2012-11-08 21:29 ` Andrew Morton
2012-11-08 22:01 ` Andi Kleen
2012-11-08 22:09 ` Andrew Morton
2012-11-09 0:38 ` Andi Kleen
2012-11-12 9:35 ` Dave Young [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50A0C2F2.6060100@redhat.com \
--to=dyoung@redhat.com \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).