From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx205.postini.com [74.125.245.205]) by kanga.kvack.org (Postfix) with SMTP id DEEBE6B0087 for ; Tue, 13 Nov 2012 09:49:27 -0500 (EST) Message-ID: <50A25DE5.1040202@redhat.com> Date: Tue, 13 Nov 2012 09:49:09 -0500 From: Rik van Riel MIME-Version: 1.0 Subject: Re: [PATCH 12/19] mm: migrate: Introduce migrate_misplaced_page() References: <1352193295-26815-1-git-send-email-mgorman@suse.de> <1352193295-26815-13-git-send-email-mgorman@suse.de> <20121113093644.GA21522@gmail.com> <20121113114344.GA26305@gmail.com> In-Reply-To: <20121113114344.GA26305@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Ingo Molnar Cc: Mel Gorman , Peter Zijlstra , Andrea Arcangeli , Johannes Weiner , Hugh Dickins , Thomas Gleixner , Linus Torvalds , Andrew Morton , Linux-MM , LKML On 11/13/2012 06:43 AM, Ingo Molnar wrote: > > * Ingo Molnar wrote: > >> >> * Mel Gorman wrote: >> >>> From: Peter Zijlstra >>> >>> Note: This was originally based on Peter's patch "mm/migrate: Introduce >>> migrate_misplaced_page()" but borrows extremely heavily from Andrea's >>> "autonuma: memory follows CPU algorithm and task/mm_autonuma stats >>> collection". The end result is barely recognisable so signed-offs >>> had to be dropped. If original authors are ok with it, I'll >>> re-add the signed-off-bys. >>> >>> Add migrate_misplaced_page() which deals with migrating pages from >>> faults. >>> >>> Based-on-work-by: Lee Schermerhorn >>> Based-on-work-by: Peter Zijlstra >>> Based-on-work-by: Andrea Arcangeli >>> Signed-off-by: Mel Gorman >>> --- >>> include/linux/migrate.h | 8 ++++ >>> mm/migrate.c | 104 ++++++++++++++++++++++++++++++++++++++++++++++- >>> 2 files changed, 110 insertions(+), 2 deletions(-) >> >> That's a nice patch - the TASK_NUMA_FAULT approach in the >> original patch was not very elegant. >> >> I've started testing it to see how well your version works. > > Hm, I'm seeing some instability - see the boot crash below. If I > undo your patch it goes away. > > ( To help debugging this I've attached migration.patch which > applies your patch on top of Peter's latest queue of patches. > If I revert this patch then the crash goes away. ) > > I've gone back to the well-tested page migration code from Peter > for the time being. Is there a place we can see your code? Peter's patch with MIGRATE_FAULT is very much NAKed, so this approach does need to be made to work... You can either make the working tree public somewhere, so we can help, or figure it out yourself. Your choice :) -- All rights reversed -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org