linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: "Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com>
To: Dave Hansen <dave@linux.vnet.ibm.com>
Cc: Mel Gorman <mgorman@suse.de>,
	Vaidyanathan Srinivasan <svaidy@linux.vnet.ibm.com>,
	akpm@linux-foundation.org, mjg59@srcf.ucam.org,
	paulmck@linux.vnet.ibm.com, maxime.coquelin@stericsson.com,
	loic.pallardy@stericsson.com, arjan@linux.intel.com,
	kmpark@infradead.org, kamezawa.hiroyu@jp.fujitsu.com,
	lenb@kernel.org, rjw@sisk.pl, gargankita@gmail.com,
	amit.kachhap@linaro.org, thomas.abraham@linaro.org,
	santosh.shilimkar@ti.com, linux-pm@vger.kernel.org,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	andi@firstfloor.org,
	SrinivasPandruvada <srinivas.pandruvada@linux.intel.com>
Subject: Re: [RFC PATCH 0/8][Sorted-buddy] mm: Linux VM Infrastructure to support Memory Power Management
Date: Sat, 17 Nov 2012 00:02:37 +0530	[thread overview]
Message-ID: <50A686C5.7080103@linux.vnet.ibm.com> (raw)
In-Reply-To: <509D34DA.5090303@linux.vnet.ibm.com>

On 11/09/2012 10:22 PM, Srivatsa S. Bhat wrote:
> On 11/09/2012 10:13 PM, Srivatsa S. Bhat wrote:
>> On 11/09/2012 10:04 PM, Srivatsa S. Bhat wrote:
>>> On 11/09/2012 09:43 PM, Dave Hansen wrote:
>>>> On 11/09/2012 07:23 AM, Srivatsa S. Bhat wrote:
>>>>> FWIW, kernbench is actually (and surprisingly) showing a slight performance
>>>>> *improvement* with this patchset, over vanilla 3.7-rc3, as I mentioned in
>>>>> my other email to Dave.
>>>>>
>>>>> https://lkml.org/lkml/2012/11/7/428
>>>>>
>>>>> I don't think I can dismiss it as an experimental error, because I am seeing
>>>>> those results consistently.. I'm trying to find out what's behind that.
>>>>
>>>> The only numbers in that link are in the date. :)  Let's see the
>>>> numbers, please.
>>>>
>>>
>>> Sure :) The reason I didn't post the numbers very eagerly was that I didn't
>>> want it to look ridiculous if it later turned out to be really an error in the
>>> experiment ;) But since I have seen it happening consistently I think I can
>>> post the numbers here with some non-zero confidence.
>>>
>>>> If you really have performance improvement to the memory allocator (or
>>>> something else) here, then surely it can be pared out of your patches
>>>> and merged quickly by itself.  Those kinds of optimizations are hard to
>>>> come by!
>>>>
>>>
>>> :-)
>>>
>>> Anyway, here it goes:
>>>
>>> Test setup:
>>> ----------
>>> x86 2-socket quad-core machine. (CONFIG_NUMA=n because I figured that my
>>> patchset might not handle NUMA properly). Mem region size = 512 MB.
>>>
>>
>> For CONFIG_NUMA=y on the same machine, the difference between the 2 kernels
>> was much lesser, but nevertheless, this patchset performed better. I wouldn't
>> vouch that my patchset handles NUMA correctly, but here are the numbers from
>> that run anyway (at least to show that I really found the results to be
>> repeatable):
>>

I fixed up the NUMA case (I'll post the updated patch for that soon) and
ran a fresh set of kernbench runs. The difference between mainline and this
patchset is quite tiny; so we can't really say that this patchset shows a
performance improvement over mainline. However, I can safely conclude that
this patchset doesn't show any performance _degradation_ w.r.t mainline
in kernbench.

Results from one of the recent kernbench runs:
---------------------------------------------

Kernbench log for Vanilla 3.7-rc3
=================================
Kernel: 3.7.0-rc3
Average Optimal load -j 32 Run (std deviation):
Elapsed Time 330.39 (0.746257)
User Time 4283.63 (3.39617)
System Time 604.783 (2.72629)
Percent CPU 1479 (3.60555)
Context Switches 845634 (6031.22)
Sleeps 833655 (6652.17)


Kernbench log for Sorted-buddy
==============================
Kernel: 3.7.0-rc3-sorted-buddy
Average Optimal load -j 32 Run (std deviation):
Elapsed Time 329.967 (2.76789)
User Time 4230.02 (2.15324)
System Time 599.793 (1.09988)
Percent CPU 1463.33 (11.3725)
Context Switches 840530 (1646.75)
Sleeps 833732 (2227.68)

Regards,
Srivatsa S. Bhat

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2012-11-16 18:34 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-06 19:52 [RFC PATCH 0/8][Sorted-buddy] mm: Linux VM Infrastructure to support Memory Power Management Srivatsa S. Bhat
2012-11-06 19:52 ` [RFC PATCH 1/8] mm: Introduce memory regions data-structure to capture region boundaries within node Srivatsa S. Bhat
2012-11-06 23:03   ` Dave Hansen
2012-11-07 20:12     ` Srivatsa S. Bhat
2012-11-06 19:52 ` [RFC PATCH 2/8] mm: Initialize node memory regions during boot Srivatsa S. Bhat
2012-12-04  8:25   ` wujianguo
2012-11-06 19:53 ` [RFC PATCH 3/8] mm: Introduce and initialize zone memory regions Srivatsa S. Bhat
2012-11-06 19:53 ` [RFC PATCH 4/8] mm: Add helpers to retrieve node region and zone region for a given page Srivatsa S. Bhat
2012-11-16 18:39   ` [RFC PATCH UPDATED " Srivatsa S. Bhat
2012-11-06 19:53 ` [RFC PATCH 5/8] mm: Add data-structures to describe memory regions within the zones' freelists Srivatsa S. Bhat
2012-11-06 19:53 ` [RFC PATCH 6/8] mm: Demarcate and maintain pageblocks in region-order in " Srivatsa S. Bhat
2012-11-06 21:49   ` Dave Hansen
2012-11-07 20:15     ` Srivatsa S. Bhat
2012-11-09  6:22       ` Ankita Garg
2012-11-09  6:01   ` Ankita Garg
2012-11-09  9:03     ` Srivatsa S. Bhat
2012-11-06 19:54 ` [RFC PATCH 7/8] mm: Add an optimized version of del_from_freelist to keep page allocation fast Srivatsa S. Bhat
2012-11-06 19:54 ` [RFC PATCH 8/8] mm: Print memory region statistics to understand the buddy allocator behavior Srivatsa S. Bhat
2012-11-08 18:02 ` [RFC PATCH 0/8][Sorted-buddy] mm: Linux VM Infrastructure to support Memory Power Management Mel Gorman
2012-11-08 19:38   ` Srivatsa S. Bhat
2012-11-09  5:14   ` Vaidyanathan Srinivasan
2012-11-09  9:00     ` Mel Gorman
2012-11-09 14:51       ` Srivatsa S. Bhat
2012-11-09 15:23         ` Srivatsa S. Bhat
2012-11-09 16:13           ` Dave Hansen
2012-11-09 16:34             ` Srivatsa S. Bhat
2012-11-09 16:43               ` Srivatsa S. Bhat
2012-11-09 16:52                 ` Srivatsa S. Bhat
2012-11-16 18:32                   ` Srivatsa S. Bhat [this message]
2012-11-09 15:34     ` Arjan van de Ven
     [not found]   ` <loom.20121109T172910-394@post.gmane.org>
2012-11-12 16:14     ` Srivatsa S. Bhat
2012-12-04 10:51 ` wujianguo
2012-12-06  6:32   ` Srivatsa S. Bhat
  -- strict thread matches above, loose matches on Subject: below --
2012-11-09 18:14 Srinivas Pandruvada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50A686C5.7080103@linux.vnet.ibm.com \
    --to=srivatsa.bhat@linux.vnet.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=amit.kachhap@linaro.org \
    --cc=andi@firstfloor.org \
    --cc=arjan@linux.intel.com \
    --cc=dave@linux.vnet.ibm.com \
    --cc=gargankita@gmail.com \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=kmpark@infradead.org \
    --cc=lenb@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=loic.pallardy@stericsson.com \
    --cc=maxime.coquelin@stericsson.com \
    --cc=mgorman@suse.de \
    --cc=mjg59@srcf.ucam.org \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=rjw@sisk.pl \
    --cc=santosh.shilimkar@ti.com \
    --cc=srinivas.pandruvada@linux.intel.com \
    --cc=svaidy@linux.vnet.ibm.com \
    --cc=thomas.abraham@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).