From: Jaegeuk Hanse <jaegeuk.hanse@gmail.com>
To: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Andrea Arcangeli <aarcange@redhat.com>,
linux-mm@kvack.org, Andi Kleen <ak@linux.intel.com>,
"H. Peter Anvin" <hpa@linux.intel.com>,
linux-kernel@vger.kernel.org,
"Kirill A. Shutemov" <kirill@shutemov.name>,
David Rientjes <rientjes@google.com>
Subject: Re: [PATCH v6 10/12] thp: implement refcounting for huge zero page
Date: Mon, 19 Nov 2012 18:20:01 +0800 [thread overview]
Message-ID: <50AA07D1.7030906@gmail.com> (raw)
In-Reply-To: <20121119095615.GA23869@otc-wbsnb-06>
On 11/19/2012 05:56 PM, Kirill A. Shutemov wrote:
> On Sun, Nov 18, 2012 at 02:23:44PM +0800, Jaegeuk Hanse wrote:
>> On 11/16/2012 03:27 AM, Kirill A. Shutemov wrote:
>>> From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
>>>
>>> H. Peter Anvin doesn't like huge zero page which sticks in memory forever
>>> after the first allocation. Here's implementation of lockless refcounting
>>> for huge zero page.
>>>
>>> We have two basic primitives: {get,put}_huge_zero_page(). They
>>> manipulate reference counter.
>>>
>>> If counter is 0, get_huge_zero_page() allocates a new huge page and
>>> takes two references: one for caller and one for shrinker. We free the
>>> page only in shrinker callback if counter is 1 (only shrinker has the
>>> reference).
>>>
>>> put_huge_zero_page() only decrements counter. Counter is never zero
>>> in put_huge_zero_page() since shrinker holds on reference.
>>>
>>> Freeing huge zero page in shrinker callback helps to avoid frequent
>>> allocate-free.
>>>
>>> Refcounting has cost. On 4 socket machine I observe ~1% slowdown on
>>> parallel (40 processes) read page faulting comparing to lazy huge page
>>> allocation. I think it's pretty reasonable for synthetic benchmark.
>> Hi Kirill,
>>
>> I see your and Andew's hot discussion in v4 resend thread.
>>
>> "I also tried another scenario: usemem -n16 100M -r 1000. It creates
>> real memory pressure - no easy reclaimable memory. This time
>> callback called with nr_to_scan > 0 and we freed hzp. "
>>
>> What's "usemem"? Is it a tool and how to get it?
> http://www.spinics.net/lists/linux-mm/attachments/gtarazbJaHPaAT.gtar
Thanks for your response. But how to use it, I even can't compile the
files.
# ./case-lru-file-mmap-read
./case-lru-file-mmap-read: line 3: hw_vars: No such file or directory
./case-lru-file-mmap-read: line 7: 10 * mem / nr_cpu: division by 0
(error token is "nr_cpu")
# gcc usemem.c -o usemem
/tmp/ccFkIDWk.o: In function `do_task':
usemem.c:(.text+0x9f2): undefined reference to `pthread_create'
usemem.c:(.text+0xa44): undefined reference to `pthread_join'
collect2: ld returned 1 exit status
>
>> It's hard for me to
>> find nr_to_scan > 0 in every callset, how can nr_to_scan > 0 in your
>> scenario?
> shrink_slab() calls the callback with nr_to_scan > 0 if system is under
> pressure -- look for do_shrinker_shrink().
Why Andrew's example(dd if=/fast-disk/large-file) doesn't call this
path? I think it also can add memory pressure, where I miss?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-11-19 10:20 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-15 19:26 [PATCH v6 00/12] Introduce huge zero page Kirill A. Shutemov
2012-11-15 19:26 ` [PATCH v6 01/12] thp: huge zero page: basic preparation Kirill A. Shutemov
2012-11-15 19:26 ` [PATCH v6 02/12] thp: zap_huge_pmd(): zap huge zero pmd Kirill A. Shutemov
2012-11-15 19:26 ` [PATCH v6 03/12] thp: copy_huge_pmd(): copy huge zero page Kirill A. Shutemov
2012-11-15 22:32 ` [patch] thp: copy_huge_pmd(): copy huge zero page v6 fix David Rientjes
2012-11-15 19:26 ` [PATCH v6 04/12] thp: do_huge_pmd_wp_page(): handle huge zero page Kirill A. Shutemov
2012-11-15 19:26 ` [PATCH v6 05/12] thp: change_huge_pmd(): keep huge zero page write-protected Kirill A. Shutemov
2012-11-15 19:26 ` [PATCH v6 06/12] thp: change split_huge_page_pmd() interface Kirill A. Shutemov
2012-11-15 19:26 ` [PATCH v6 07/12] thp: implement splitting pmd for huge zero page Kirill A. Shutemov
2012-11-15 19:26 ` [PATCH v6 08/12] thp: setup huge zero page on non-write page fault Kirill A. Shutemov
2012-11-15 19:26 ` [PATCH v6 09/12] thp: lazy huge zero page allocation Kirill A. Shutemov
2012-11-15 19:27 ` [PATCH v6 10/12] thp: implement refcounting for huge zero page Kirill A. Shutemov
2012-11-18 6:23 ` Jaegeuk Hanse
2012-11-19 9:56 ` Kirill A. Shutemov
2012-11-19 10:20 ` Jaegeuk Hanse [this message]
2012-11-19 10:23 ` Kirill A. Shutemov
2012-11-19 11:02 ` Jaegeuk Hanse
2012-11-19 11:09 ` Kirill A. Shutemov
2012-11-19 11:29 ` Jaegeuk Hanse
2012-11-15 19:27 ` [PATCH v6 11/12] thp, vmstat: implement HZP_ALLOC and HZP_ALLOC_FAILED events Kirill A. Shutemov
2012-11-15 19:27 ` [PATCH v6 12/12] thp: introduce sysfs knob to disable huge zero page Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50AA07D1.7030906@gmail.com \
--to=jaegeuk.hanse@gmail.com \
--cc=aarcange@redhat.com \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=hpa@linux.intel.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).