From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx166.postini.com [74.125.245.166]) by kanga.kvack.org (Postfix) with SMTP id 9948D6B0070 for ; Mon, 19 Nov 2012 21:13:11 -0500 (EST) Received: by mail-ob0-f169.google.com with SMTP id lz20so6905601obb.14 for ; Mon, 19 Nov 2012 18:13:10 -0800 (PST) Message-ID: <50AAE72E.3090101@gmail.com> Date: Tue, 20 Nov 2012 10:13:02 +0800 From: Jaegeuk Hanse MIME-Version: 1.0 Subject: Re: [RFT PATCH v1 0/5] fix up inaccurate zone->present_pages References: <20121115112454.e582a033.akpm@linux-foundation.org> <1353254850-27336-1-git-send-email-jiang.liu@huawei.com> In-Reply-To: <1353254850-27336-1-git-send-email-jiang.liu@huawei.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Jiang Liu Cc: Andrew Morton , Wen Congyang , David Rientjes , Jiang Liu , Maciej Rutecki , Chris Clayton , "Rafael J . Wysocki" , Mel Gorman , Minchan Kim , KAMEZAWA Hiroyuki , Michal Hocko , Jianguo Wu , linux-mm@kvack.org, linux-kernel@vger.kernel.org On 11/19/2012 12:07 AM, Jiang Liu wrote: > The commit 7f1290f2f2a4 ("mm: fix-up zone present pages") tries to > resolve an issue caused by inaccurate zone->present_pages, but that > fix is incomplete and causes regresions with HIGHMEM. And it has been > reverted by commit > 5576646 revert "mm: fix-up zone present pages" > > This is a following-up patchset for the issue above. It introduces a > new field named "managed_pages" to struct zone, which counts pages > managed by the buddy system from the zone. And zone->present_pages > is used to count pages existing in the zone, which is > spanned_pages - absent_pages. > > But that way, zone->present_pages will be kept in consistence with > pgdat->node_present_pages, which is sum of zone->present_pages. > > This patchset has only been tested on x86_64 with nobootmem.c. So need > help to test this patchset on machines: > 1) use bootmem.c If only x86_32 use bootmem.c instead of nobootmem.c? How could I confirm it? > 2) have highmem > > This patchset applies to "f4a75d2e Linux 3.7-rc6" from > git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > > Any comments and helps are welcomed! > > Jiang Liu (5): > mm: introduce new field "managed_pages" to struct zone > mm: replace zone->present_pages with zone->managed_pages if > appreciated > mm: set zone->present_pages to number of existing pages in the zone > mm: provide more accurate estimation of pages occupied by memmap > mm: increase totalram_pages when free pages allocated by bootmem > allocator > > include/linux/mmzone.h | 1 + > mm/bootmem.c | 14 ++++++++ > mm/memory_hotplug.c | 6 ++++ > mm/mempolicy.c | 2 +- > mm/nobootmem.c | 15 ++++++++ > mm/page_alloc.c | 89 +++++++++++++++++++++++++++++++----------------- > mm/vmscan.c | 16 ++++----- > mm/vmstat.c | 8 +++-- > 8 files changed, 108 insertions(+), 43 deletions(-) > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org