From: Rik van Riel <riel@redhat.com>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Johannes Hirte <johannes.hirte@fem.tu-ilmenau.de>,
akpm@linux-foundation.org, mgorman@suse.de,
Valdis.Kletnieks@vt.edu, jirislaby@gmail.com, jslaby@suse.cz,
zkabelac@redhat.com, mm-commits@vger.kernel.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
torvalds@linux-foundation.org
Subject: Re: [PATCH] mm,vmscan: only loop back if compaction would fail in all zones
Date: Mon, 26 Nov 2012 10:32:12 -0500 [thread overview]
Message-ID: <50B38B7C.2080201@redhat.com> (raw)
In-Reply-To: <20121126041041.GD2799@cmpxchg.org>
On 11/25/2012 11:10 PM, Johannes Weiner wrote:
> From: Johannes Weiner <hannes@cmpxchg.org>
> Subject: [patch] mm: vmscan: fix endless loop in kswapd balancing
>
> Kswapd does not in all places have the same criteria for when it
> considers a zone balanced. This leads to zones being not reclaimed
> because they are considered just fine and the compaction checks to
> loop over the zonelist again because they are considered unbalanced,
> causing kswapd to run forever.
>
> Add a function, zone_balanced(), that checks the watermark and if
> compaction has enough free memory to do its job. Then use it
> uniformly for when kswapd needs to check if a zone is balanced.
>
> Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
Reviewed-by: Rik van Riel <riel@redhat.com>
--
All rights reversed
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-11-26 15:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20121119202152.4B0E420004E@hpza10.eem.corp.google.com>
[not found] ` <20121125175728.3db4ac6a@fem.tu-ilmenau.de>
2012-11-25 18:29 ` [PATCH] mm,vmscan: free pages if compaction_suitable tells us to Rik van Riel
2012-11-25 22:44 ` Johannes Weiner
2012-11-25 23:31 ` Rik van Riel
2012-11-26 0:16 ` [PATCH] mm,vmscan: only loop back if compaction would fail in all zones Rik van Riel
2012-11-26 3:15 ` Johannes Weiner
2012-11-26 4:10 ` Johannes Weiner
2012-11-26 11:17 ` Johannes Hirte
2012-11-26 15:32 ` Rik van Riel [this message]
2012-11-27 22:35 ` Valdis.Kletnieks
2012-11-26 1:21 ` [PATCH] mm,vmscan: free pages if compaction_suitable tells us to Jaegeuk Hanse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50B38B7C.2080201@redhat.com \
--to=riel@redhat.com \
--cc=Valdis.Kletnieks@vt.edu \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=jirislaby@gmail.com \
--cc=johannes.hirte@fem.tu-ilmenau.de \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mm-commits@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=zkabelac@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).