From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx205.postini.com [74.125.245.205]) by kanga.kvack.org (Postfix) with SMTP id EF76B6B0044 for ; Sun, 2 Dec 2012 12:53:44 -0500 (EST) Message-ID: <50BB9595.6040300@redhat.com> Date: Sun, 02 Dec 2012 12:53:25 -0500 From: Rik van Riel MIME-Version: 1.0 Subject: Re: [PATCH 2/2, v2] mm/migration: Make rmap_walk_anon() and try_to_unmap_anon() more scalable References: <1354305521-11583-1-git-send-email-mingo@kernel.org> <20121201094927.GA12366@gmail.com> <20121201122649.GA20322@gmail.com> <20121201184135.GA32449@gmail.com> <20121201201538.GB2704@gmail.com> <50BA69B7.30002@redhat.com> <20121202151232.GB12911@gmail.com> In-Reply-To: <20121202151232.GB12911@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Ingo Molnar Cc: Linus Torvalds , Linux Kernel Mailing List , linux-mm , Peter Zijlstra , Paul Turner , Lee Schermerhorn , Christoph Lameter , Mel Gorman , Andrew Morton , Andrea Arcangeli , Thomas Gleixner , Johannes Weiner , Hugh Dickins On 12/02/2012 10:12 AM, Ingo Molnar wrote: > Rename anon_vma_[un]lock() => anon_vma_[un]lock_write(), > to make it clearer that it's an exclusive write-lock in > that case - suggested by Rik van Riel. ... close, but you forgot to actually rename the unlock function :) > diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h > index 7f5a552..81a9dee 100644 > --- a/include/linux/huge_mm.h > +++ b/include/linux/huge_mm.h > @@ -101,7 +101,7 @@ extern void __split_huge_page_pmd(struct mm_struct *mm, pmd_t *pmd); > #define wait_split_huge_page(__anon_vma, __pmd) \ > do { \ > pmd_t *____pmd = (__pmd); \ > - anon_vma_lock(__anon_vma); \ > + anon_vma_lock_write(__anon_vma); \ > anon_vma_unlock(__anon_vma); \ > BUG_ON(pmd_trans_splitting(*____pmd) || \ -- All rights reversed -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org